All of lore.kernel.org
 help / color / mirror / Atom feed
From: Naresh Kamboju <naresh.kamboju at linaro.org>
To: mptcp at lists.01.org
Subject: [MPTCP] Re: [PATCH net-next] mptcp: update rtx timeout only if required.
Date: Thu, 19 Nov 2020 19:49:16 +0530	[thread overview]
Message-ID: <CA+G9fYstUYSeXh=w2YSmytHfBg2=tnwyAx_hCJtn2Dfi_Ts91g@mail.gmail.com> (raw)
In-Reply-To: d69c8138-311b-f94e-74b8-1e759846eec0@linux.intel.com

[-- Attachment #1: Type: text/plain, Size: 962 bytes --]

On Thu, 19 Nov 2020 at 06:13, Mat Martineau
<mathew.j.martineau(a)linux.intel.com> wrote:
>
>
> On Wed, 18 Nov 2020, Paolo Abeni wrote:
>
> > We must start the retransmission timer only there are
> > pending data in the rtx queue.
> > Otherwise we can hit a WARN_ON in mptcp_reset_timer(),
> > as syzbot demonstrated.
> >
> > Reported-and-tested-by: syzbot+42aa53dafb66a07e5a24(a)syzkaller.appspotmail.com
> > Fixes: d9ca1de8c0cd ("mptcp: move page frag allocation in mptcp_sendmsg()")
> > Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
> > ---
> > net/mptcp/protocol.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
>
> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>

Reported-by: Naresh Kamboju <naresh.kamboju(a)linaro.org>
Tested-by: Naresh Kamboju <naresh.kamboju(a)linaro.org>

The reported kernel warning was fixed after applying this fix on top of
Linux next tag  20201119.

- Naresh

WARNING: multiple messages have this Message-ID (diff)
From: Naresh Kamboju <naresh.kamboju@linaro.org>
To: Mat Martineau <mathew.j.martineau@linux.intel.com>
Cc: Paolo Abeni <pabeni@redhat.com>, Netdev <netdev@vger.kernel.org>,
	Jakub Kicinski <kuba@kernel.org>,
	mptcp@lists.01.org
Subject: Re: [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required.
Date: Thu, 19 Nov 2020 19:49:16 +0530	[thread overview]
Message-ID: <CA+G9fYstUYSeXh=w2YSmytHfBg2=tnwyAx_hCJtn2Dfi_Ts91g@mail.gmail.com> (raw)
In-Reply-To: <d69c8138-311b-f94e-74b8-1e759846eec0@linux.intel.com>

On Thu, 19 Nov 2020 at 06:13, Mat Martineau
<mathew.j.martineau@linux.intel.com> wrote:
>
>
> On Wed, 18 Nov 2020, Paolo Abeni wrote:
>
> > We must start the retransmission timer only there are
> > pending data in the rtx queue.
> > Otherwise we can hit a WARN_ON in mptcp_reset_timer(),
> > as syzbot demonstrated.
> >
> > Reported-and-tested-by: syzbot+42aa53dafb66a07e5a24@syzkaller.appspotmail.com
> > Fixes: d9ca1de8c0cd ("mptcp: move page frag allocation in mptcp_sendmsg()")
> > Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> > ---
> > net/mptcp/protocol.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
>
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

Reported-by: Naresh Kamboju <naresh.kamboju@linaro.org>
Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>

The reported kernel warning was fixed after applying this fix on top of
Linux next tag  20201119.

- Naresh

             reply	other threads:[~2020-11-19 14:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 14:19 Naresh Kamboju [this message]
2020-11-19 14:19 ` [MPTCP] [PATCH net-next] mptcp: update rtx timeout only if required Naresh Kamboju
  -- strict thread matches above, loose matches on Subject: below --
2020-11-20  5:55 [MPTCP] " Jakub Kicinski
2020-11-20  5:55 ` [MPTCP] " Jakub Kicinski
2020-11-19  0:42 [MPTCP] " Mat Martineau
2020-11-19  0:42 ` [MPTCP] " Mat Martineau
2020-11-18 22:05 Paolo Abeni
2020-11-18 22:05 ` Paolo Abeni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+G9fYstUYSeXh=w2YSmytHfBg2=tnwyAx_hCJtn2Dfi_Ts91g@mail.gmail.com' \
    --to=unknown@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.