From: Tomasz Figa <tomasz.figa@gmail.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Kukjin Kim <kgene@kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-clk@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH] clk: samsung: Suppress unbinding to prevent theoretical attacks
Date: Sat, 18 Jun 2016 23:37:31 +0900 [thread overview]
Message-ID: <CA+Ln22E13nm4nsgWoi6gNc_Jh+UqqE5MgwANH02GZF7bQye+yw@mail.gmail.com> (raw)
In-Reply-To: <1463469974-13340-1-git-send-email-k.kozlowski@samsung.com>
Hi,
2016-05-17 16:26 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> Although unbinding a driver requires root privileges but it still might
> be used theoretically in certain attacks (by triggering NULL pointer
> exception or memory corruption if driver does not provide proper remove
> callbacks or core does not handle it).
>
> Samsung clock drivers are essential for system operation so their
> removal is not expected. More over, the Exynos3250 ISP clock driver does
> not implement remove() driver callback and it is not buildable as
> modules.
>
> Suppress the unbind interface for Exynos3250 ISP and S3C2410 DCLK clock
> drivers.
>
> Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/clk/samsung/clk-exynos3250.c | 1 +
> drivers/clk/samsung/clk-s3c2410-dclk.c | 5 +++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
Makes sense. (By the way, I wonder if we ever see a solution for the
unbind problem with .remove implemented and some resources that can't
be released at the time .unbind is attempted...)
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: samsung: Suppress unbinding to prevent theoretical attacks
Date: Sat, 18 Jun 2016 23:37:31 +0900 [thread overview]
Message-ID: <CA+Ln22E13nm4nsgWoi6gNc_Jh+UqqE5MgwANH02GZF7bQye+yw@mail.gmail.com> (raw)
In-Reply-To: <1463469974-13340-1-git-send-email-k.kozlowski@samsung.com>
Hi,
2016-05-17 16:26 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> Although unbinding a driver requires root privileges but it still might
> be used theoretically in certain attacks (by triggering NULL pointer
> exception or memory corruption if driver does not provide proper remove
> callbacks or core does not handle it).
>
> Samsung clock drivers are essential for system operation so their
> removal is not expected. More over, the Exynos3250 ISP clock driver does
> not implement remove() driver callback and it is not buildable as
> modules.
>
> Suppress the unbind interface for Exynos3250 ISP and S3C2410 DCLK clock
> drivers.
>
> Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Cc: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/clk/samsung/clk-exynos3250.c | 1 +
> drivers/clk/samsung/clk-s3c2410-dclk.c | 5 +++--
> 2 files changed, 4 insertions(+), 2 deletions(-)
Makes sense. (By the way, I wonder if we ever see a solution for the
unbind problem with .remove implemented and some resources that can't
be released at the time .unbind is attempted...)
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
Best regards,
Tomasz
next prev parent reply other threads:[~2016-06-18 14:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 7:26 [PATCH] clk: samsung: Suppress unbinding to prevent theoretical attacks Krzysztof Kozlowski
2016-05-17 7:26 ` Krzysztof Kozlowski
2016-05-21 2:30 ` Javier Martinez Canillas
2016-05-21 2:30 ` Javier Martinez Canillas
2016-06-18 14:37 ` Tomasz Figa [this message]
2016-06-18 14:37 ` Tomasz Figa
2016-06-18 14:37 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+Ln22E13nm4nsgWoi6gNc_Jh+UqqE5MgwANH02GZF7bQye+yw@mail.gmail.com \
--to=tomasz.figa@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mturquette@baylibre.com \
--cc=s.nawrocki@samsung.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.