From: Benjamin Gaignard <benjamin.gaignard@linaro.org>
To: Philippe CORNU <philippe.cornu@st.com>
Cc: Yannick Fertre <yannick.fertre@st.com>,
Vincent Abriou <vincent.abriou@st.com>,
David Airlie <airlied@linux.ie>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Fabien Dessenne <fabien.dessenne@st.com>,
Mickael Reulier <mickael.reulier@st.com>,
Gabriel Fernandez <gabriel.fernandez@st.com>,
Ludovic Barre <ludovic.barre@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH v1 6/7] drm/stm: ltdc: Cleanup rename returned value
Date: Thu, 20 Jul 2017 11:31:36 +0200 [thread overview]
Message-ID: <CA+M3ks5Hh_9v_ZpMFL=N_jajKFuSu6CqLmu0jmGq2pwsO4bT8w@mail.gmail.com> (raw)
In-Reply-To: <1500373219-20233-7-git-send-email-philippe.cornu@st.com>
2017-07-18 12:20 GMT+02:00 Philippe CORNU <philippe.cornu@st.com>:
Commit message is missing here
> Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
> ---
> drivers/gpu/drm/stm/ltdc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index f4ed21a..8cd1b9b 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -760,7 +760,7 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> struct ltdc_device *ldev = ddev->dev_private;
> struct drm_plane *primary, *overlay;
> unsigned int i;
> - int res;
> + int ret;
>
> primary = ltdc_plane_create(ddev, DRM_PLANE_TYPE_PRIMARY);
> if (!primary) {
> @@ -768,9 +768,9 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> return -EINVAL;
> }
>
> - res = drm_crtc_init_with_planes(ddev, crtc, primary, NULL,
> + ret = drm_crtc_init_with_planes(ddev, crtc, primary, NULL,
> <dc_crtc_funcs, NULL);
> - if (res) {
> + if (ret) {
> DRM_ERROR("Can not initialize CRTC\n");
> goto cleanup;
> }
> @@ -783,7 +783,7 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
> for (i = 1; i < ldev->caps.nb_layers; i++) {
> overlay = ltdc_plane_create(ddev, DRM_PLANE_TYPE_OVERLAY);
> if (!overlay) {
> - res = -ENOMEM;
> + ret = -ENOMEM;
> DRM_ERROR("Can not create overlay plane %d\n", i);
> goto cleanup;
> }
> @@ -793,7 +793,7 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
>
> cleanup:
> ltdc_plane_destroy_all(ddev);
> - return res;
> + return ret;
> }
>
> /*
> --
> 1.9.1
>
--
Benjamin Gaignard
Graphic Study Group
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-07-20 9:31 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-18 10:20 [PATCH v1 0/7] drm/stm: Various cleanups Philippe CORNU
2017-07-18 10:20 ` Philippe CORNU
2017-07-18 10:20 ` [PATCH v1 1/7] drm/stm: drv: Rename platform driver name Philippe CORNU
2017-07-18 10:20 ` Philippe CORNU
2017-07-20 9:27 ` Benjamin Gaignard
2017-07-20 9:27 ` Benjamin Gaignard
2017-07-18 10:20 ` [PATCH v1 2/7] drm/stm: ltdc: Cleanup signal polarity defines Philippe CORNU
2017-07-18 10:20 ` Philippe CORNU
2017-07-20 9:27 ` Benjamin Gaignard
2017-07-18 10:20 ` [PATCH v1 3/7] drm/stm: ltdc: Lindent and minor cleanups Philippe CORNU
2017-07-18 10:20 ` Philippe CORNU
2017-07-20 9:28 ` Benjamin Gaignard
2017-07-20 9:28 ` Benjamin Gaignard
2017-07-18 10:20 ` [PATCH v1 4/7] drm/stm: ltdc: Constify funcs structures Philippe CORNU
2017-07-18 10:20 ` Philippe CORNU
2017-07-20 9:28 ` Benjamin Gaignard
2017-07-20 9:28 ` Benjamin Gaignard
2017-07-18 10:20 ` [PATCH v1 5/7] drm/stm: ltdc: add devm_reset_control & platform_get_ressource Philippe CORNU
2017-07-18 10:20 ` Philippe CORNU
2017-07-20 9:30 ` Benjamin Gaignard
2017-07-20 9:30 ` Benjamin Gaignard
2017-07-18 10:20 ` [PATCH v1 6/7] drm/stm: ltdc: Cleanup rename returned value Philippe CORNU
2017-07-18 10:20 ` Philippe CORNU
2017-07-20 9:31 ` Benjamin Gaignard [this message]
2017-07-18 10:20 ` [PATCH v1 7/7] drm/stm: dsi: Constify phy ops structure Philippe CORNU
2017-07-18 10:20 ` Philippe CORNU
2017-07-20 9:32 ` Benjamin Gaignard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+M3ks5Hh_9v_ZpMFL=N_jajKFuSu6CqLmu0jmGq2pwsO4bT8w@mail.gmail.com' \
--to=benjamin.gaignard@linaro.org \
--cc=airlied@linux.ie \
--cc=alexandre.torgue@st.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=fabien.dessenne@st.com \
--cc=gabriel.fernandez@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.barre@st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=mickael.reulier@st.com \
--cc=philippe.cornu@st.com \
--cc=vincent.abriou@st.com \
--cc=yannick.fertre@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.