From: Benjamin Gaignard <benjamin.gaignard@linaro.org> To: Mihail Atanassov <Mihail.Atanassov@arm.com> Cc: "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, nd <nd@arm.com>, Vincent Abriou <vincent.abriou@st.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v2 27/28] drm/sti: Use drm_bridge_init() Date: Thu, 5 Dec 2019 14:39:05 +0100 [thread overview] Message-ID: <CA+M3ks74aJH1EComQ24i6NeDftGHg-LPZ9VH7vje4W=a13-yDw@mail.gmail.com> (raw) In-Reply-To: <20191204114732.28514-28-mihail.atanassov@arm.com> Le mer. 4 déc. 2019 à 12:48, Mihail Atanassov <Mihail.Atanassov@arm.com> a écrit : > > No functional change. > > v2: > - Also apply drm_bridge_init() in sti_hdmi.c and sti_hda.c (Sam, > Benjamin) > > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > --- > drivers/gpu/drm/sti/sti_dvo.c | 4 +--- > drivers/gpu/drm/sti/sti_hda.c | 3 +-- > drivers/gpu/drm/sti/sti_hdmi.c | 3 +-- > 3 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c > index 68289b0b063a..20a3956b33bc 100644 > --- a/drivers/gpu/drm/sti/sti_dvo.c > +++ b/drivers/gpu/drm/sti/sti_dvo.c > @@ -462,9 +462,7 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data) > if (!bridge) > return -ENOMEM; > > - bridge->driver_private = dvo; > - bridge->funcs = &sti_dvo_bridge_funcs; > - bridge->of_node = dvo->dev.of_node; > + drm_bridge_init(bridge, &dvo->dev, &sti_dvo_bridge_funcs, NULL, dvo); > drm_bridge_add(bridge); > > err = drm_bridge_attach(encoder, bridge, NULL); > diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c > index 8f7bf33815fd..c7296e354a34 100644 > --- a/drivers/gpu/drm/sti/sti_hda.c > +++ b/drivers/gpu/drm/sti/sti_hda.c > @@ -699,8 +699,7 @@ static int sti_hda_bind(struct device *dev, struct device *master, void *data) > if (!bridge) > return -ENOMEM; > > - bridge->driver_private = hda; > - bridge->funcs = &sti_hda_bridge_funcs; > + drm_bridge_init(bridge, dev, &sti_hda_bridge_funcs, NULL, hda); > drm_bridge_attach(encoder, bridge, NULL); > > connector->encoder = encoder; > diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c > index 814560ead4e1..c9ae3e18fa5d 100644 > --- a/drivers/gpu/drm/sti/sti_hdmi.c > +++ b/drivers/gpu/drm/sti/sti_hdmi.c > @@ -1279,8 +1279,7 @@ static int sti_hdmi_bind(struct device *dev, struct device *master, void *data) > if (!bridge) > return -EINVAL; > > - bridge->driver_private = hdmi; > - bridge->funcs = &sti_hdmi_bridge_funcs; > + drm_bridge_init(bridge, dev, &sti_hdmi_bridge_funcs, NULL, hdmi); > drm_bridge_attach(encoder, bridge, NULL); > > connector->encoder = encoder; > -- > 2.23.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Gaignard <benjamin.gaignard@linaro.org> To: Mihail Atanassov <Mihail.Atanassov@arm.com> Cc: David Airlie <airlied@linux.ie>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, nd <nd@arm.com>, Vincent Abriou <vincent.abriou@st.com> Subject: Re: [PATCH v2 27/28] drm/sti: Use drm_bridge_init() Date: Thu, 5 Dec 2019 14:39:05 +0100 [thread overview] Message-ID: <CA+M3ks74aJH1EComQ24i6NeDftGHg-LPZ9VH7vje4W=a13-yDw@mail.gmail.com> (raw) In-Reply-To: <20191204114732.28514-28-mihail.atanassov@arm.com> Le mer. 4 déc. 2019 à 12:48, Mihail Atanassov <Mihail.Atanassov@arm.com> a écrit : > > No functional change. > > v2: > - Also apply drm_bridge_init() in sti_hdmi.c and sti_hda.c (Sam, > Benjamin) > > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> Reviewed-by: Benjamin Gaignard <benjamin.gaignard@linaro.org> > --- > drivers/gpu/drm/sti/sti_dvo.c | 4 +--- > drivers/gpu/drm/sti/sti_hda.c | 3 +-- > drivers/gpu/drm/sti/sti_hdmi.c | 3 +-- > 3 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/sti/sti_dvo.c b/drivers/gpu/drm/sti/sti_dvo.c > index 68289b0b063a..20a3956b33bc 100644 > --- a/drivers/gpu/drm/sti/sti_dvo.c > +++ b/drivers/gpu/drm/sti/sti_dvo.c > @@ -462,9 +462,7 @@ static int sti_dvo_bind(struct device *dev, struct device *master, void *data) > if (!bridge) > return -ENOMEM; > > - bridge->driver_private = dvo; > - bridge->funcs = &sti_dvo_bridge_funcs; > - bridge->of_node = dvo->dev.of_node; > + drm_bridge_init(bridge, &dvo->dev, &sti_dvo_bridge_funcs, NULL, dvo); > drm_bridge_add(bridge); > > err = drm_bridge_attach(encoder, bridge, NULL); > diff --git a/drivers/gpu/drm/sti/sti_hda.c b/drivers/gpu/drm/sti/sti_hda.c > index 8f7bf33815fd..c7296e354a34 100644 > --- a/drivers/gpu/drm/sti/sti_hda.c > +++ b/drivers/gpu/drm/sti/sti_hda.c > @@ -699,8 +699,7 @@ static int sti_hda_bind(struct device *dev, struct device *master, void *data) > if (!bridge) > return -ENOMEM; > > - bridge->driver_private = hda; > - bridge->funcs = &sti_hda_bridge_funcs; > + drm_bridge_init(bridge, dev, &sti_hda_bridge_funcs, NULL, hda); > drm_bridge_attach(encoder, bridge, NULL); > > connector->encoder = encoder; > diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c > index 814560ead4e1..c9ae3e18fa5d 100644 > --- a/drivers/gpu/drm/sti/sti_hdmi.c > +++ b/drivers/gpu/drm/sti/sti_hdmi.c > @@ -1279,8 +1279,7 @@ static int sti_hdmi_bind(struct device *dev, struct device *master, void *data) > if (!bridge) > return -EINVAL; > > - bridge->driver_private = hdmi; > - bridge->funcs = &sti_hdmi_bridge_funcs; > + drm_bridge_init(bridge, dev, &sti_hdmi_bridge_funcs, NULL, hdmi); > drm_bridge_attach(encoder, bridge, NULL); > > connector->encoder = encoder; > -- > 2.23.0 > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-12-05 13:39 UTC|newest] Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-12-04 11:48 [PATCH v2 00/28] drm/bridge: Consolidate initialization Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 01/28] drm: Introduce drm_bridge_init() Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 13:10 ` Daniel Vetter 2019-12-04 13:10 ` Daniel Vetter 2019-12-05 12:40 ` Laurent Pinchart 2019-12-05 12:40 ` Laurent Pinchart 2019-12-05 14:25 ` Mihail Atanassov 2019-12-05 14:25 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 02/28] drm/bridge: adv7511: Use drm_bridge_init() Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 03/28] drm/bridge/analogix: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-05 13:29 ` Laurent Pinchart 2019-12-05 13:29 ` Laurent Pinchart 2019-12-04 11:48 ` [PATCH v2 04/28] drm/bridge: cdns: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 05/28] drm/bridge: dumb-vga-dac: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 06/28] drm/bridge: lvds-encoder: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 07/28] drm/bridge: megachips-stdpxxxx-ge-b850v3-fw: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 08/28] drm/bridge: nxp-ptn3460: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 10/28] drm/bridge: ps8622: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 09/28] drm/bridge: panel: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 11/28] drm/bridge: sii902x: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 12/28] gpu: drm: bridge: sii9234: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-05 12:10 ` Neil Armstrong 2019-12-05 12:10 ` Neil Armstrong 2019-12-05 14:25 ` Mihail Atanassov 2019-12-05 14:25 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 13/28] drm/bridge: sil_sii8620: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 14/28] drm/bridge/synopsys: dw-hdmi: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 15/28] drm/bridge/synopsys: dsi: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 16/28] drm/bridge: tc358764: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 17/28] drm/bridge: tc358767: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 19/28] drm/bridge: ti-sn65dsi86: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 18/28] drm/bridge: thc63: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-05 13:33 ` Laurent Pinchart 2019-12-05 13:33 ` Laurent Pinchart 2019-12-04 11:48 ` [PATCH v2 20/28] drm/bridge: ti-tfp410: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 21/28] drm/exynos: mic: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 22/28] drm/i2c: tda998x: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 23/28] drm/mcde: dsi: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` [PATCH v2 25/28] drm: rcar-du: lvds: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-05 13:31 ` Laurent Pinchart 2019-12-05 13:31 ` Laurent Pinchart 2019-12-04 11:48 ` [PATCH v2 24/28] drm/mediatek: hdmi: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-10 1:24 ` CK Hu 2019-12-10 1:24 ` CK Hu 2019-12-10 1:24 ` CK Hu 2019-12-10 1:24 ` CK Hu 2019-12-04 11:48 ` [PATCH v2 26/28] drm: rcar-du: lvds: Don't set drm_bridge private pointer Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-05 13:31 ` Laurent Pinchart 2019-12-05 13:31 ` Laurent Pinchart 2019-12-04 11:48 ` [PATCH v2 27/28] drm/sti: Use drm_bridge_init() Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-05 13:39 ` Benjamin Gaignard [this message] 2019-12-05 13:39 ` Benjamin Gaignard 2019-12-04 11:48 ` [PATCH v2 28/28] drm/msm: " Mihail Atanassov 2019-12-04 11:48 ` Mihail Atanassov 2019-12-05 13:34 ` [PATCH v2 00/28] drm/bridge: Consolidate initialization Laurent Pinchart 2019-12-05 13:34 ` Laurent Pinchart 2019-12-05 13:34 ` Laurent Pinchart 2019-12-09 10:39 ` Neil Armstrong 2019-12-09 10:39 ` Neil Armstrong 2019-12-09 10:39 ` Neil Armstrong 2019-12-09 10:39 ` Neil Armstrong 2019-12-09 11:08 ` Mihail Atanassov 2019-12-09 11:08 ` Mihail Atanassov 2019-12-09 11:08 ` Mihail Atanassov 2019-12-09 11:08 ` Mihail Atanassov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CA+M3ks74aJH1EComQ24i6NeDftGHg-LPZ9VH7vje4W=a13-yDw@mail.gmail.com' \ --to=benjamin.gaignard@linaro.org \ --cc=Mihail.Atanassov@arm.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=nd@arm.com \ --cc=vincent.abriou@st.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.