From: Rahul Pathak <rpathak@ventanamicro.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: Alistair Francis <Alistair.Francis@wdc.com>,
Bin Meng <bmeng.cn@gmail.com>,
"open list:RISC-V" <qemu-riscv@nongnu.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [PATCH v2 0/2] mconfigptr support
Date: Thu, 28 Oct 2021 08:04:05 +0530 [thread overview]
Message-ID: <CA+Oz1=aCVsyxV38QtfWa001Gr6M6iqyToR9mTzu_B4jh9fDqTA@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKNrje6W0kzHgfRf6k9gVAz4c12zdKYYbsSJaHNFdbnQXA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On Wed, Oct 27, 2021 at 8:14 AM Alistair Francis <alistair23@gmail.com>
wrote:
> On Mon, Oct 25, 2021 at 10:51 PM Rahul Pathak <rpathak@ventanamicro.com>
> wrote:
> >
> > Patches add the mconfigptr csr support.
> > mconfigptr is newly incorporated in risc-v privileged architecture
> > specification 1.12 version.
> > priv spec 1.12.0 version check is also added.
> >
> >
> > qemu-system-riscv64 -nographic -machine virt -cpu rv64,priv_spec=v1.12.0
>
> Thanks for the patches!
>
> I gave some comments in line with the code changes. Overall this looks
> good, we just need to add the other v1.12.0 features.
>
> Alistair
Thanks Alistair, I will work on the comments and send the
next version.
>
>
>
> > Changelog:
> >
> > v1->v2
> > ------
> > 1. Added privileged architecture spec version 1.12 ("v1.12.0") check
> > 2. Added predicate function for mconfigptr which verifies
> > for priv spec version v1.12.0 or higher.
> >
> > Thanks
> > Rahul
> >
> > Rahul Pathak (2):
> > target/riscv: Add priv spec 1.12.0 version check
> > target/riscv: csr: Implement mconfigptr CSR
> >
> > target/riscv/cpu.c | 4 +++-
> > target/riscv/cpu.h | 1 +
> > target/riscv/cpu_bits.h | 1 +
> > target/riscv/csr.c | 19 +++++++++++++++----
> > 4 files changed, 20 insertions(+), 5 deletions(-)
> >
> > --
> > 2.25.1
> >
> >
>
[-- Attachment #2: Type: text/html, Size: 2688 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Rahul Pathak <rpathak@ventanamicro.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: "open list:RISC-V" <qemu-riscv@nongnu.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Bin Meng <bmeng.cn@gmail.com>,
Alistair Francis <Alistair.Francis@wdc.com>
Subject: Re: [PATCH v2 0/2] mconfigptr support
Date: Thu, 28 Oct 2021 08:04:05 +0530 [thread overview]
Message-ID: <CA+Oz1=aCVsyxV38QtfWa001Gr6M6iqyToR9mTzu_B4jh9fDqTA@mail.gmail.com> (raw)
In-Reply-To: <CAKmqyKNrje6W0kzHgfRf6k9gVAz4c12zdKYYbsSJaHNFdbnQXA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On Wed, Oct 27, 2021 at 8:14 AM Alistair Francis <alistair23@gmail.com>
wrote:
> On Mon, Oct 25, 2021 at 10:51 PM Rahul Pathak <rpathak@ventanamicro.com>
> wrote:
> >
> > Patches add the mconfigptr csr support.
> > mconfigptr is newly incorporated in risc-v privileged architecture
> > specification 1.12 version.
> > priv spec 1.12.0 version check is also added.
> >
> >
> > qemu-system-riscv64 -nographic -machine virt -cpu rv64,priv_spec=v1.12.0
>
> Thanks for the patches!
>
> I gave some comments in line with the code changes. Overall this looks
> good, we just need to add the other v1.12.0 features.
>
> Alistair
Thanks Alistair, I will work on the comments and send the
next version.
>
>
>
> > Changelog:
> >
> > v1->v2
> > ------
> > 1. Added privileged architecture spec version 1.12 ("v1.12.0") check
> > 2. Added predicate function for mconfigptr which verifies
> > for priv spec version v1.12.0 or higher.
> >
> > Thanks
> > Rahul
> >
> > Rahul Pathak (2):
> > target/riscv: Add priv spec 1.12.0 version check
> > target/riscv: csr: Implement mconfigptr CSR
> >
> > target/riscv/cpu.c | 4 +++-
> > target/riscv/cpu.h | 1 +
> > target/riscv/cpu_bits.h | 1 +
> > target/riscv/csr.c | 19 +++++++++++++++----
> > 4 files changed, 20 insertions(+), 5 deletions(-)
> >
> > --
> > 2.25.1
> >
> >
>
[-- Attachment #2: Type: text/html, Size: 2688 bytes --]
next prev parent reply other threads:[~2021-10-28 2:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-25 12:43 [PATCH v2 0/2] mconfigptr support Rahul Pathak
2021-10-25 12:43 ` [PATCH v2 1/2] target/riscv: Add priv spec 1.12.0 version check Rahul Pathak
2021-10-27 2:38 ` Alistair Francis
2021-10-27 2:38 ` Alistair Francis
2021-10-28 2:32 ` Rahul Pathak
2021-10-28 2:32 ` Rahul Pathak
2021-10-25 12:43 ` [PATCH v2 2/2] target/riscv: csr: Implement mconfigptr CSR Rahul Pathak
2021-10-27 2:42 ` Alistair Francis
2021-10-27 2:42 ` Alistair Francis
2021-10-28 2:31 ` Rahul Pathak
2021-10-28 2:31 ` Rahul Pathak
2021-10-27 2:44 ` [PATCH v2 0/2] mconfigptr support Alistair Francis
2021-10-27 2:44 ` Alistair Francis
2021-10-28 2:34 ` Rahul Pathak [this message]
2021-10-28 2:34 ` Rahul Pathak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+Oz1=aCVsyxV38QtfWa001Gr6M6iqyToR9mTzu_B4jh9fDqTA@mail.gmail.com' \
--to=rpathak@ventanamicro.com \
--cc=Alistair.Francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.