From: Andrey Konovalov <andreyknvl@gmail.com>
To: Haibo Li <haibo.li@mediatek.com>, jannh@google.com
Cc: akpm@linux-foundation.org,
angelogioacchino.delregno@collabora.com, dvyukov@google.com,
glider@google.com, kasan-dev@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
linux-mm@kvack.org, mark.rutland@arm.com, matthias.bgg@gmail.com,
ryabinin.a.a@gmail.com, vincenzo.frascino@arm.com,
xiaoming.yu@mediatek.com
Subject: Re: [PATCH] kasan:fix access invalid shadow address when input is illegal
Date: Fri, 15 Sep 2023 18:50:48 +0200 [thread overview]
Message-ID: <CA+fCnZfuaovc4fk6Z+p1haLk7iemgtpF522sej3oWYARhBYYUQ@mail.gmail.com> (raw)
In-Reply-To: <20230915024559.32806-1-haibo.li@mediatek.com>
On Fri, Sep 15, 2023 at 4:46 AM 'Haibo Li' via kasan-dev
<kasan-dev@googlegroups.com> wrote:
>
> The patch checks each shadow address,so it introduces extra overhead.
Ack. Could still be fine, depends on the overhead.
But if the message printed by kasan_non_canonical_hook is good enough
for your use case, I would rather stick to that.
> Now kasan_non_canonical_hook only works for CONFIG_KASAN_INLINE.
>
> And CONFIG_KASAN_OUTLINE is set in my case.
>
> Is it possible to make kasan_non_canonical_hook works for both
> INLINE and OUTLINE by simply remove the "#ifdef CONFIG_KASAN_INLINE"?
Yes, it should just work if you remove the ifdefs in mm/kasan/report.c
and in include/linux/kasan.h.
Jann, do you have any objections to enabling kasan_non_canonical_hook
for the outline mode too?
> Since kasan_non_canonical_hook is only used after kernel fault,it
> is better if there is no limit.
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@gmail.com>
To: Haibo Li <haibo.li@mediatek.com>, jannh@google.com
Cc: akpm@linux-foundation.org,
angelogioacchino.delregno@collabora.com, dvyukov@google.com,
glider@google.com, kasan-dev@googlegroups.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org, linux-mm@kvack.org,
mark.rutland@arm.com, matthias.bgg@gmail.com,
ryabinin.a.a@gmail.com, vincenzo.frascino@arm.com,
xiaoming.yu@mediatek.com
Subject: Re: [PATCH] kasan:fix access invalid shadow address when input is illegal
Date: Fri, 15 Sep 2023 18:50:48 +0200 [thread overview]
Message-ID: <CA+fCnZfuaovc4fk6Z+p1haLk7iemgtpF522sej3oWYARhBYYUQ@mail.gmail.com> (raw)
In-Reply-To: <20230915024559.32806-1-haibo.li@mediatek.com>
On Fri, Sep 15, 2023 at 4:46 AM 'Haibo Li' via kasan-dev
<kasan-dev@googlegroups.com> wrote:
>
> The patch checks each shadow address,so it introduces extra overhead.
Ack. Could still be fine, depends on the overhead.
But if the message printed by kasan_non_canonical_hook is good enough
for your use case, I would rather stick to that.
> Now kasan_non_canonical_hook only works for CONFIG_KASAN_INLINE.
>
> And CONFIG_KASAN_OUTLINE is set in my case.
>
> Is it possible to make kasan_non_canonical_hook works for both
> INLINE and OUTLINE by simply remove the "#ifdef CONFIG_KASAN_INLINE"?
Yes, it should just work if you remove the ifdefs in mm/kasan/report.c
and in include/linux/kasan.h.
Jann, do you have any objections to enabling kasan_non_canonical_hook
for the outline mode too?
> Since kasan_non_canonical_hook is only used after kernel fault,it
> is better if there is no limit.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-09-15 16:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-14 8:08 [PATCH] kasan:fix access invalid shadow address when input is illegal Haibo Li
2023-09-14 8:08 ` Haibo Li
2023-09-14 17:46 ` Andrey Konovalov
2023-09-14 17:46 ` Andrey Konovalov
2023-09-14 18:29 ` Andrew Morton
2023-09-14 18:29 ` Andrew Morton
2023-09-14 20:34 ` Andrey Konovalov
2023-09-14 20:34 ` Andrey Konovalov
2023-09-14 20:40 ` Jann Horn
2023-09-14 20:40 ` Jann Horn
2023-09-15 1:51 ` Andrey Konovalov
2023-09-15 1:51 ` Andrey Konovalov
2023-09-15 2:45 ` Haibo Li
2023-09-15 2:45 ` Haibo Li
2023-09-15 9:40 ` Haibo Li
2023-09-15 9:40 ` Haibo Li
2023-09-15 16:53 ` Andrey Konovalov
2023-09-15 16:53 ` Andrey Konovalov
2023-09-15 16:50 ` Andrey Konovalov [this message]
2023-09-15 16:50 ` Andrey Konovalov
2023-09-15 17:04 ` Jann Horn
2023-09-15 17:04 ` Jann Horn
2023-09-18 8:12 ` Haibo Li
2023-09-18 8:12 ` Haibo Li
2023-09-18 7:25 ` Haibo Li
2023-09-18 7:25 ` Haibo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+fCnZfuaovc4fk6Z+p1haLk7iemgtpF522sej3oWYARhBYYUQ@mail.gmail.com \
--to=andreyknvl@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=haibo.li@mediatek.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=ryabinin.a.a@gmail.com \
--cc=vincenzo.frascino@arm.com \
--cc=xiaoming.yu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.