From: Sedat Dilek <sedat.dilek@gmail.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH 4/4] kbuild: factor out the common objtool arguments
Date: Mon, 30 May 2022 11:36:37 +0200 [thread overview]
Message-ID: <CA+icZUX+KE6yrVJ5a2CHRvL7_kpK-zXbvJurtAjzgYmsDtSkCw@mail.gmail.com> (raw)
In-Reply-To: <CAK7LNATwgT-FQ99Ex6MOc+rYEe7tc8ffoF-5e12jfbeaEM1vhw@mail.gmail.com>
On Sun, May 29, 2022 at 7:36 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
...
> > > # 'OBJECT_FILES_NON_STANDARD := y': skip objtool checking for a directory
> > > # 'OBJECT_FILES_NON_STANDARD_foo.o := 'y': skip objtool checking for a file
> > > # 'OBJECT_FILES_NON_STANDARD_foo.o := 'n': override directory skip for a file
> > >
> >
> > ^^ What is with this block?
> > If this belongs together with objtool - shall this be moved, too?
>
> No.
> These are unneeded for vmlinux.o
>
OK.
> > > #link vmlinux.o
> >
> > ^^ While you are at it, change the comment to "# Link of vmlinux.o".
>
>
> In my plan, this code will be gone sooner or later.
>
> It would be a noise.
>
Hope you have fruitful plans :-).
-sed@-
next prev parent reply other threads:[~2022-05-30 9:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-28 15:47 [PATCH 1/4] kbuild: remove redundant cleanups in scripts/link-vmlinux.sh Masahiro Yamada
2022-05-28 15:47 ` [PATCH 2/4] kbuild: clean .tmp_* pattern by make clean Masahiro Yamada
2022-05-29 14:40 ` Sedat Dilek
2022-05-29 17:32 ` Masahiro Yamada
2022-05-30 9:34 ` Sedat Dilek
2022-06-01 19:49 ` Nicolas Schier
2022-06-03 13:22 ` Masahiro Yamada
2022-05-28 15:47 ` [PATCH 3/4] kbuild: move vmlinux.o link to scripts/Makefile.vmlinux_o Masahiro Yamada
2022-05-29 14:42 ` Sedat Dilek
2022-05-28 15:47 ` [PATCH 4/4] kbuild: factor out the common objtool arguments Masahiro Yamada
2022-05-29 14:46 ` Sedat Dilek
2022-05-29 17:34 ` Masahiro Yamada
2022-05-30 9:36 ` Sedat Dilek [this message]
2022-05-29 14:37 ` [PATCH 1/4] kbuild: remove redundant cleanups in scripts/link-vmlinux.sh Sedat Dilek
2022-05-29 17:30 ` Masahiro Yamada
2022-05-30 9:33 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+icZUX+KE6yrVJ5a2CHRvL7_kpK-zXbvJurtAjzgYmsDtSkCw@mail.gmail.com \
--to=sedat.dilek@gmail.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.