Re: [PATCH 2/4] kbuild: clean .tmp_* pattern by make clean

From: Masahiro Yamada <masahiroy@kernel.org>
To: Nicolas Schier <nicolas@fjasle.eu>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Michal Marek <michal.lkml@markovi.net>
Subject: Re: [PATCH 2/4] kbuild: clean .tmp_* pattern by make clean
Date: Fri, 3 Jun 2022 22:22:30 +0900	[thread overview]
Message-ID: <CAK7LNAQcJ903mM+XRGGWzdayDsk5vz6R1BVpe0vi_sqGDxygQg@mail.gmail.com> (raw)
In-Reply-To: <YpfC42gQGDJiMMNT@bergen.fjasle.eu>

On Thu, Jun 2, 2022 at 4:50 AM Nicolas Schier <nicolas@fjasle.eu> wrote:
>
> On Sun 29 May 2022 00:47:02 +0900, Masahiro Yamada wrote:
> > Change the "make clean" rule to remove all the .tmp_* files.
> >
> > .tmp_objdiff is the only exception, which should be removed by
> > "make mrproper".
> >
> > Rename the record directory of objdiff, .tmp_objdiff to .objdiff to
> > avoid the removal by "make clean".
> >
> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
> > ---
> >
> >  Makefile                | 4 ++--
> >  scripts/link-vmlinux.sh | 3 ---
> >  scripts/objdiff         | 2 +-
> >  3 files changed, 3 insertions(+), 6 deletions(-)
> >
> ...
> > diff --git a/scripts/objdiff b/scripts/objdiff
> > index 72b0b63c3fe1..68b8d74e5c6f 100755
> > --- a/scripts/objdiff
> > +++ b/scripts/objdiff
> > @@ -32,7 +32,7 @@ if [ -z "$SRCTREE" ]; then
> >       exit 1
> >  fi
> >
> > -TMPD=$SRCTREE/.tmp_objdiff
> > +TMPD=$SRCTREE/.objdiff
> >
> >  usage() {
> >       echo >&2 "Usage: $0 <command> <args>"
>
> scripts/objdiff still has two occurrences of .tmp_objdiff (in the
> comment block at the top).

Ah, thank you for catching it.
I sent a fixup.

-- 
Best Regards
Masahiro Yamada