From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Chancel Liu <chancel.liu@nxp.com>
Cc: alsa-devel@alsa-project.org, Xiubo.Lee@gmail.com,
linuxppc-dev@lists.ozlabs.org, tiwai@suse.com,
lgirdwood@gmail.com, nicoleotsuka@gmail.com, broonie@kernel.org,
festevam@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_micfil: Correct the number of steps on SX controls
Date: Thu, 5 Jan 2023 17:49:37 +0800 [thread overview]
Message-ID: <CAA+D8AO-_MFop-WS=XQa2L83aajibkY4DeJek-3khN5p_1rwig@mail.gmail.com> (raw)
In-Reply-To: <20230104025754.3019235-1-chancel.liu@nxp.com>
On Wed, Jan 4, 2023 at 10:58 AM Chancel Liu <chancel.liu@nxp.com> wrote:
> The parameter "max" of SOC_SINGLE_SX_TLV() means the number of steps
> rather than maximum value. This patch corrects the minimum value to -8
> and the number of steps to 15.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
Best regards
Wang Shengjiu
> ---
> sound/soc/fsl/fsl_micfil.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
> index d7e6fc996166..d4d3bc7ca87c 100644
> --- a/sound/soc/fsl/fsl_micfil.c
> +++ b/sound/soc/fsl/fsl_micfil.c
> @@ -325,21 +325,21 @@ static int hwvad_detected(struct snd_kcontrol
> *kcontrol,
>
> static const struct snd_kcontrol_new fsl_micfil_snd_controls[] = {
> SOC_SINGLE_SX_TLV("CH0 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(0), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(0), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH1 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(1), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(1), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH2 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(2), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(2), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH3 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(3), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(3), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH4 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(4), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(4), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH5 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(5), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(5), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH6 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(6), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(6), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH7 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(7), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(7), 0x8, 0xF, gain_tlv),
> SOC_ENUM_EXT("MICFIL Quality Select",
> fsl_micfil_quality_enum,
> micfil_quality_get, micfil_quality_set),
> --
> 2.25.1
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Chancel Liu <chancel.liu@nxp.com>
Cc: alsa-devel@alsa-project.org, Xiubo.Lee@gmail.com,
linuxppc-dev@lists.ozlabs.org, tiwai@suse.com,
lgirdwood@gmail.com, perex@perex.cz, nicoleotsuka@gmail.com,
broonie@kernel.org, festevam@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: fsl_micfil: Correct the number of steps on SX controls
Date: Thu, 5 Jan 2023 17:49:37 +0800 [thread overview]
Message-ID: <CAA+D8AO-_MFop-WS=XQa2L83aajibkY4DeJek-3khN5p_1rwig@mail.gmail.com> (raw)
In-Reply-To: <20230104025754.3019235-1-chancel.liu@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 2765 bytes --]
On Wed, Jan 4, 2023 at 10:58 AM Chancel Liu <chancel.liu@nxp.com> wrote:
> The parameter "max" of SOC_SINGLE_SX_TLV() means the number of steps
> rather than maximum value. This patch corrects the minimum value to -8
> and the number of steps to 15.
>
> Signed-off-by: Chancel Liu <chancel.liu@nxp.com>
>
Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>
Best regards
Wang Shengjiu
> ---
> sound/soc/fsl/fsl_micfil.c | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/sound/soc/fsl/fsl_micfil.c b/sound/soc/fsl/fsl_micfil.c
> index d7e6fc996166..d4d3bc7ca87c 100644
> --- a/sound/soc/fsl/fsl_micfil.c
> +++ b/sound/soc/fsl/fsl_micfil.c
> @@ -325,21 +325,21 @@ static int hwvad_detected(struct snd_kcontrol
> *kcontrol,
>
> static const struct snd_kcontrol_new fsl_micfil_snd_controls[] = {
> SOC_SINGLE_SX_TLV("CH0 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(0), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(0), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH1 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(1), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(1), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH2 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(2), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(2), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH3 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(3), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(3), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH4 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(4), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(4), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH5 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(5), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(5), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH6 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(6), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(6), 0x8, 0xF, gain_tlv),
> SOC_SINGLE_SX_TLV("CH7 Volume", REG_MICFIL_OUT_CTRL,
> - MICFIL_OUTGAIN_CHX_SHIFT(7), 0xF, 0x7, gain_tlv),
> + MICFIL_OUTGAIN_CHX_SHIFT(7), 0x8, 0xF, gain_tlv),
> SOC_ENUM_EXT("MICFIL Quality Select",
> fsl_micfil_quality_enum,
> micfil_quality_get, micfil_quality_set),
> --
> 2.25.1
>
>
[-- Attachment #2: Type: text/html, Size: 3884 bytes --]
next prev parent reply other threads:[~2023-01-05 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 2:57 [PATCH] ASoC: fsl_micfil: Correct the number of steps on SX controls Chancel Liu
2023-01-05 9:49 ` Shengjiu Wang [this message]
2023-01-05 9:49 ` Shengjiu Wang
2023-01-06 14:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA+D8AO-_MFop-WS=XQa2L83aajibkY4DeJek-3khN5p_1rwig@mail.gmail.com' \
--to=shengjiu.wang@gmail.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=chancel.liu@nxp.com \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.