From: Dong Aisheng <dongas86@gmail.com> To: Stephen Boyd <sboyd@kernel.org> Cc: Dong Aisheng <aisheng.dong@nxp.com>, linux-clk <linux-clk@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, Michael Turquette <mturquette@baylibre.com>, Shawn Guo <shawnguo@kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>, dl-linux-imx <linux-imx@nxp.com>, Sascha Hauer <kernel@pengutronix.de> Subject: Re: [PATCH V4 04/11] clk: imx: scu: bypass cpu power domains Date: Mon, 9 Sep 2019 18:24:25 +0800 [thread overview] Message-ID: <CAA+hA=QAFJoLVXzY8oSkAOf65psAyiv31EDwO0G1yFUzE9t1xQ@mail.gmail.com> (raw) In-Reply-To: <20190906170713.81A1A20578@mail.kernel.org> On Sat, Sep 7, 2019 at 5:28 PM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Dong Aisheng (2019-08-20 04:13:18) > > diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c > > index 48bfb08..5f935b1 100644 > > --- a/drivers/clk/imx/clk-scu.c > > +++ b/drivers/clk/imx/clk-scu.c > > @@ -479,6 +479,10 @@ static int imx_clk_scu_attach_pd(struct device *dev, u32 rsrc_id) > > .args[0] = rsrc_id, > > }; > > > > + if ((rsrc_id == IMX_SC_R_A35) || (rsrc_id == IMX_SC_R_A53) || > > + (rsrc_id == IMX_SC_R_A72)) > > Please drop the extra parenthesis. It makes it hard to read. > Will drop it, thx Regards Aisheng > > + return 0; > > + > > return of_genpd_add_device(&genpdspec, dev);
WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <dongas86@gmail.com> To: Stephen Boyd <sboyd@kernel.org> Cc: Dong Aisheng <aisheng.dong@nxp.com>, Michael Turquette <mturquette@baylibre.com>, dl-linux-imx <linux-imx@nxp.com>, Sascha Hauer <kernel@pengutronix.de>, Fabio Estevam <fabio.estevam@nxp.com>, Shawn Guo <shawnguo@kernel.org>, linux-clk <linux-clk@vger.kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH V4 04/11] clk: imx: scu: bypass cpu power domains Date: Mon, 9 Sep 2019 18:24:25 +0800 [thread overview] Message-ID: <CAA+hA=QAFJoLVXzY8oSkAOf65psAyiv31EDwO0G1yFUzE9t1xQ@mail.gmail.com> (raw) In-Reply-To: <20190906170713.81A1A20578@mail.kernel.org> On Sat, Sep 7, 2019 at 5:28 PM Stephen Boyd <sboyd@kernel.org> wrote: > > Quoting Dong Aisheng (2019-08-20 04:13:18) > > diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c > > index 48bfb08..5f935b1 100644 > > --- a/drivers/clk/imx/clk-scu.c > > +++ b/drivers/clk/imx/clk-scu.c > > @@ -479,6 +479,10 @@ static int imx_clk_scu_attach_pd(struct device *dev, u32 rsrc_id) > > .args[0] = rsrc_id, > > }; > > > > + if ((rsrc_id == IMX_SC_R_A35) || (rsrc_id == IMX_SC_R_A53) || > > + (rsrc_id == IMX_SC_R_A72)) > > Please drop the extra parenthesis. It makes it hard to read. > Will drop it, thx Regards Aisheng > > + return 0; > > + > > return of_genpd_add_device(&genpdspec, dev); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-09-09 10:34 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-20 11:13 [PATCH V4 00/11] clk: imx8: add new clock binding for better pm support Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-08-20 11:13 ` [PATCH V4 01/11] dt-bindings: firmware: imx-scu: new binding to parse clocks from device tree Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-08-24 19:19 ` Shawn Guo 2019-08-24 19:19 ` Shawn Guo 2019-08-24 19:19 ` Shawn Guo 2019-08-26 3:24 ` Aisheng Dong 2019-08-26 3:24 ` Aisheng Dong 2019-08-26 3:24 ` Aisheng Dong 2019-08-27 17:04 ` Rob Herring 2019-08-27 17:04 ` Rob Herring 2019-08-27 17:04 ` Rob Herring 2019-09-06 16:56 ` Stephen Boyd 2019-09-06 16:56 ` Stephen Boyd 2019-09-06 16:56 ` Stephen Boyd 2019-08-20 11:13 ` [PATCH V4 02/11] dt-bindings: clock: imx-lpcg: add support " Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-08-24 19:21 ` Shawn Guo 2019-08-24 19:21 ` Shawn Guo 2019-08-24 19:21 ` Shawn Guo 2019-08-26 3:14 ` Aisheng Dong 2019-08-26 3:14 ` Aisheng Dong 2019-08-26 3:14 ` Aisheng Dong 2019-08-26 3:21 ` Aisheng Dong 2019-08-26 3:21 ` Aisheng Dong 2019-08-26 3:21 ` Aisheng Dong 2019-08-27 17:05 ` Rob Herring 2019-08-27 17:05 ` Rob Herring 2019-08-27 17:05 ` Rob Herring 2019-09-06 17:00 ` Stephen Boyd 2019-09-06 17:00 ` Stephen Boyd 2019-09-06 17:00 ` Stephen Boyd 2019-08-20 11:13 ` [PATCH V4 03/11] clk: imx: scu: add two cells binding support Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-09-06 17:06 ` Stephen Boyd 2019-09-06 17:06 ` Stephen Boyd 2019-09-09 10:23 ` Dong Aisheng 2019-09-09 10:23 ` Dong Aisheng 2019-09-16 18:44 ` Stephen Boyd 2019-09-16 18:44 ` Stephen Boyd 2019-11-17 12:07 ` Dong Aisheng 2019-11-17 12:07 ` Dong Aisheng 2019-08-20 11:13 ` [PATCH V4 04/11] clk: imx: scu: bypass cpu power domains Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-09-06 17:07 ` Stephen Boyd 2019-09-06 17:07 ` Stephen Boyd 2019-09-09 10:24 ` Dong Aisheng [this message] 2019-09-09 10:24 ` Dong Aisheng 2019-08-20 11:13 ` [PATCH V4 05/11] clk: imx: scu: allow scu clk to take device pointer Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-08-20 11:13 ` [PATCH V4 06/11] clk: imx: scu: add runtime pm support Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-08-20 11:13 ` [PATCH V4 07/11] clk: imx: scu: add suspend/resume support Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-09-06 17:09 ` Stephen Boyd 2019-09-06 17:09 ` Stephen Boyd 2019-09-09 10:35 ` Dong Aisheng 2019-09-09 10:35 ` Dong Aisheng 2019-08-20 11:13 ` [PATCH V4 08/11] clk: imx: imx8qxp-lpcg: add parsing clocks from device tree Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-09-06 17:13 ` Stephen Boyd 2019-09-06 17:13 ` Stephen Boyd 2019-09-09 11:23 ` Dong Aisheng 2019-09-09 11:23 ` Dong Aisheng 2019-09-16 18:45 ` Stephen Boyd 2019-09-16 18:45 ` Stephen Boyd 2019-11-17 12:08 ` Dong Aisheng 2019-11-17 12:08 ` Dong Aisheng 2019-08-20 11:13 ` [PATCH V4 09/11] clk: imx: lpcg: allow lpcg clk to take device pointer Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-08-20 11:13 ` [PATCH V4 10/11] clk: imx: clk-imx8qxp-lpcg: add runtime pm support Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-08-20 11:13 ` [PATCH V4 11/11] clk: imx: lpcg: add suspend/resume support Dong Aisheng 2019-08-20 11:13 ` Dong Aisheng 2019-09-06 17:14 ` Stephen Boyd 2019-09-06 17:14 ` Stephen Boyd 2019-09-09 11:39 ` Dong Aisheng 2019-09-09 11:39 ` Dong Aisheng 2019-09-09 12:21 ` [PATCH V4 00/11] clk: imx8: add new clock binding for better pm support Oliver Graute 2019-09-09 12:21 ` Oliver Graute
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAA+hA=QAFJoLVXzY8oSkAOf65psAyiv31EDwO0G1yFUzE9t1xQ@mail.gmail.com' \ --to=dongas86@gmail.com \ --cc=aisheng.dong@nxp.com \ --cc=fabio.estevam@nxp.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=mturquette@baylibre.com \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.