From: Dong Aisheng <dongas86@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"tglx@linutronix.de" <tglx@linutronix.de>,
Marc Zyngier <marc.zyngier@arm.com>
Subject: Re: [PATCH V2 3/4] irq: imx-irqsteer: change to use reg_num instead of irq_group
Date: Thu, 31 Jan 2019 15:27:16 +0800 [thread overview]
Message-ID: <CAA+hA=RMjER6v3u4GzvCiOEJXJyBrpVed7KWUJPGQKhZvne0AQ@mail.gmail.com> (raw)
In-Reply-To: <1548854523.6869.25.camel@pengutronix.de>
On Wed, Jan 30, 2019 at 9:23 PM Lucas Stach <l.stach@pengutronix.de> wrote:
[...]
> > > + /* one register bit map represents 32 input interrupts */
> > > + data->reg_num /= 32;
> > +
> > > if (IS_ENABLED(CONFIG_PM_SLEEP)) {
> > > data->saved_reg = devm_kzalloc(&pdev->dev,
> > > - sizeof(u32) * data->irq_groups * 2,
> > > + sizeof(u32) * data->reg_num,
> > GFP_KERNEL);
>
> Does this last parameter now fit on the line above?
>
No, 81 now. :)
Regards
Dong Aisheng
WARNING: multiple messages have this Message-ID (diff)
From: Dong Aisheng <dongas86@gmail.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: Aisheng Dong <aisheng.dong@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Marc Zyngier <marc.zyngier@arm.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 3/4] irq: imx-irqsteer: change to use reg_num instead of irq_group
Date: Thu, 31 Jan 2019 15:27:16 +0800 [thread overview]
Message-ID: <CAA+hA=RMjER6v3u4GzvCiOEJXJyBrpVed7KWUJPGQKhZvne0AQ@mail.gmail.com> (raw)
In-Reply-To: <1548854523.6869.25.camel@pengutronix.de>
On Wed, Jan 30, 2019 at 9:23 PM Lucas Stach <l.stach@pengutronix.de> wrote:
[...]
> > > + /* one register bit map represents 32 input interrupts */
> > > + data->reg_num /= 32;
> > +
> > > if (IS_ENABLED(CONFIG_PM_SLEEP)) {
> > > data->saved_reg = devm_kzalloc(&pdev->dev,
> > > - sizeof(u32) * data->irq_groups * 2,
> > > + sizeof(u32) * data->reg_num,
> > GFP_KERNEL);
>
> Does this last parameter now fit on the line above?
>
No, 81 now. :)
Regards
Dong Aisheng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-31 7:27 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-30 13:05 [PATCH V2 0/4] irq: imx-irqsteer: add 32 interrupts chan and multi outputs support Aisheng Dong
2019-01-30 13:05 ` Aisheng Dong
2019-01-30 13:05 ` Aisheng Dong
2019-01-30 13:05 ` [PATCH V2 1/4] dt-binding: irq: imx-irqsteer: use irq number instead of group number Aisheng Dong
2019-01-30 13:05 ` Aisheng Dong
2019-01-30 13:05 ` Aisheng Dong
2019-01-30 13:17 ` Lucas Stach
2019-01-30 13:17 ` Lucas Stach
2019-01-30 13:17 ` Lucas Stach
2019-01-30 13:05 ` [PATCH V2 2/4] dt-bindings: irq: imx-irqsteer: add multi output interrupts support Aisheng Dong
2019-01-30 13:05 ` Aisheng Dong
2019-01-30 13:05 ` Aisheng Dong
2019-01-30 13:18 ` Lucas Stach
2019-01-30 13:18 ` Lucas Stach
2019-01-30 13:18 ` Lucas Stach
2019-01-30 13:33 ` Dong Aisheng
2019-01-30 13:33 ` Dong Aisheng
2019-01-30 13:33 ` Dong Aisheng
2019-01-30 13:06 ` [PATCH V2 3/4] irq: imx-irqsteer: change to use reg_num instead of irq_group Aisheng Dong
2019-01-30 13:06 ` Aisheng Dong
2019-01-30 13:06 ` Aisheng Dong
2019-01-30 13:22 ` Lucas Stach
2019-01-30 13:22 ` Lucas Stach
2019-01-30 13:22 ` Lucas Stach
2019-01-31 7:27 ` Dong Aisheng [this message]
2019-01-31 7:27 ` Dong Aisheng
2019-01-31 7:27 ` Dong Aisheng
2019-01-30 13:06 ` [PATCH V2 4/4] irq: imx: irqsteer: add multi output interrupts support Aisheng Dong
2019-01-30 13:06 ` Aisheng Dong
2019-01-30 13:06 ` Aisheng Dong
2019-01-30 13:32 ` Lucas Stach
2019-01-30 13:32 ` Lucas Stach
2019-01-30 13:32 ` Lucas Stach
2019-01-30 14:03 ` Dong Aisheng
2019-01-30 14:03 ` Dong Aisheng
2019-01-30 14:03 ` Dong Aisheng
2019-01-30 14:11 ` Lucas Stach
2019-01-30 14:11 ` Lucas Stach
2019-01-30 14:11 ` Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA+hA=RMjER6v3u4GzvCiOEJXJyBrpVed7KWUJPGQKhZvne0AQ@mail.gmail.com' \
--to=dongas86@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.