From: Wendy Liang <sunnyliangjy@gmail.com> To: Moritz Fischer <moritz.fischer@ettus.com> Cc: Wendy Liang <wendy.liang@xilinx.com>, Ohad Ben-Cohen <ohad@wizery.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Michal Simek <michal.simek@xilinx.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, rajan.vaja@xilinx.com, jollys@xilinx.com, linux-remoteproc@vger.kernel.org, linux-arm-kernel <linux-arm-kernel@lists.infradead.org>, Devicetree List <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Wendy Liang <jliang@xilinx.com> Subject: Re: [PATCH 7/7] Documentation: devicetree: Add Xilinx R5 rproc binding Date: Sun, 19 Aug 2018 22:55:53 -0700 [thread overview] Message-ID: <CAA07jV8Bf5kxJPiPMGdpqs_6KhMnjnAC4=5GomJBKgTbVSXV4Q@mail.gmail.com> (raw) In-Reply-To: <CAAtXAHd0jmV32bSyxCyMSh9fcP63sM+6-SkTMS=gA1fJKGKtig@mail.gmail.com> On Fri, Aug 17, 2018 at 9:31 AM, Moritz Fischer <moritz.fischer@ettus.com> wrote: > Hi Wendy, > > couple of minor stuff inline. > > On Thu, Aug 16, 2018 at 12:06 AM, Wendy Liang <wendy.liang@xilinx.com> wrote: >> Add device tree binding for Xilinx Cortex-r5 remoteproc. >> >> Signed-off-by: Wendy Liang <jliang@xilinx.com> >> --- >> .../remoteproc/xlnx,zynqmp-r5-remoteproc.txt | 81 ++++++++++++++++++++++ >> 1 file changed, 81 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt >> new file mode 100644 >> index 0000000..3940019 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt >> @@ -0,0 +1,81 @@ >> +Xilinx ARM Cortex A53-R5 remoteproc driver >> +========================================== >> + >> +ZynqMP family of devices use two Cortex R5 processors to help with various >> +low power / real time tasks. > > The ZynqMP family [..] uses [..] Will update in next version >> + >> +This driver requires specific ZynqMP hardware design. > > *a* specific ZynqMP hardware design. What does that mean? >> + >> +ZynqMP R5 RemoteProc Device Node: >> +================================= >> +A zynqmp_r5_remoteproc device node is used to represent a R5 IP instance >> +within ZynqMP SoC. >> + >> +Required properties: >> +-------------------- >> + - compatible : Should be "xlnx,zynqmp-r5-remoteproc-1.0" >> + - reg : Address and length of the register set for the device. It >> + contains in the same order as described reg-names > > ? >> + - reg-names: Contain the register set names. > > Contains Will update in next version > >> + "tcm_a" and "tcm_b" for TCM memories. >> + If the user uses the remoteproc driver with the RPMsg kernel >> + driver,"ipi" for the IPI register used to communicate with RPU >> + is also required. >> + Otherwise, if user only uses the remoteproc driver to boot RPU >> + firmware, "ipi" is not required. >> + - tcm-pnode-id: TCM resources power nodes IDs which are used to request TCM >> + resources for the remoteproc driver to access. >> + - rpu-pnode-id : RPU power node id which is used by the remoteproc driver >> + to start RPU or shut it down. >> + >> +Optional properties: >> +-------------------- >> + - core_conf : R5 core configuration (valid string - split0 or split1 or >> + lock-step), default is lock-step. >> + - memory-region: memories regions for RPU executable and DMA memory. >> + - interrupts : Interrupt mapping for remoteproc IPI. It is required if the >> + user uses the remoteproc driver with the RPMsg kernel driver. >> + - interrupt-parent : Phandle for the interrupt controller. It is required if >> + the user uses the remoteproc driver with the RPMsg kernel >> + kernel driver. >> + >> +Example: >> +-------- >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + rproc_0_fw_reserved: rproc@3ed000000 { >> + compatible = "rproc-prog-memory"; >> + no-map; >> + reg = <0x0 0x3ed00000 0x0 0x40000>; >> + }; >> + rproc_0_dma_reserved: rproc@3ed400000 { >> + compatible = "shared-dma-pool"; >> + no-map; >> + reg = <0x0 0x3ed40000 0x0 0x80000>; >> + }; >> + }; >> + >> + firmware { >> + zynqmp_firmware: zynqmp-firmware { >> + compatible = "xlnx,zynqmp-firmware"; >> + method = "smc"; >> + }; >> + }; >> + >> + zynqmp-r5-remoteproc@0 { >> + compatible = "xlnx,zynqmp-r5-remoteproc-1.0"; >> + reg = <0x0 0xFFE00000 0x0 0x10000>, >> + <0x0 0xFFE20000 0x0 0x10000>, >> + <0x0 0xff340000 0x0 0x100>; >> + reg-names = "tcm_a", "tcm_b", "ipi"; >> + dma-ranges; >> + core_conf = "split0"; >> + memory-region = <&rproc_0_fw_reserved>, >> + <&rproc_0_dma_reserved>; >> + tcm-pnode-id = <0xf>, <0x10>; >> + rpu-pnode-id = <0x7>; >> + interrupt-parent = <&gic>; >> + interrupts = <0 29 4>; >> + } ; >> -- >> 2.7.4 >> > > Cheers, > Moritz
WARNING: multiple messages have this Message-ID (diff)
From: sunnyliangjy@gmail.com (Wendy Liang) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 7/7] Documentation: devicetree: Add Xilinx R5 rproc binding Date: Sun, 19 Aug 2018 22:55:53 -0700 [thread overview] Message-ID: <CAA07jV8Bf5kxJPiPMGdpqs_6KhMnjnAC4=5GomJBKgTbVSXV4Q@mail.gmail.com> (raw) In-Reply-To: <CAAtXAHd0jmV32bSyxCyMSh9fcP63sM+6-SkTMS=gA1fJKGKtig@mail.gmail.com> On Fri, Aug 17, 2018 at 9:31 AM, Moritz Fischer <moritz.fischer@ettus.com> wrote: > Hi Wendy, > > couple of minor stuff inline. > > On Thu, Aug 16, 2018 at 12:06 AM, Wendy Liang <wendy.liang@xilinx.com> wrote: >> Add device tree binding for Xilinx Cortex-r5 remoteproc. >> >> Signed-off-by: Wendy Liang <jliang@xilinx.com> >> --- >> .../remoteproc/xlnx,zynqmp-r5-remoteproc.txt | 81 ++++++++++++++++++++++ >> 1 file changed, 81 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt >> new file mode 100644 >> index 0000000..3940019 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5-remoteproc.txt >> @@ -0,0 +1,81 @@ >> +Xilinx ARM Cortex A53-R5 remoteproc driver >> +========================================== >> + >> +ZynqMP family of devices use two Cortex R5 processors to help with various >> +low power / real time tasks. > > The ZynqMP family [..] uses [..] Will update in next version >> + >> +This driver requires specific ZynqMP hardware design. > > *a* specific ZynqMP hardware design. What does that mean? >> + >> +ZynqMP R5 RemoteProc Device Node: >> +================================= >> +A zynqmp_r5_remoteproc device node is used to represent a R5 IP instance >> +within ZynqMP SoC. >> + >> +Required properties: >> +-------------------- >> + - compatible : Should be "xlnx,zynqmp-r5-remoteproc-1.0" >> + - reg : Address and length of the register set for the device. It >> + contains in the same order as described reg-names > > ? >> + - reg-names: Contain the register set names. > > Contains Will update in next version > >> + "tcm_a" and "tcm_b" for TCM memories. >> + If the user uses the remoteproc driver with the RPMsg kernel >> + driver,"ipi" for the IPI register used to communicate with RPU >> + is also required. >> + Otherwise, if user only uses the remoteproc driver to boot RPU >> + firmware, "ipi" is not required. >> + - tcm-pnode-id: TCM resources power nodes IDs which are used to request TCM >> + resources for the remoteproc driver to access. >> + - rpu-pnode-id : RPU power node id which is used by the remoteproc driver >> + to start RPU or shut it down. >> + >> +Optional properties: >> +-------------------- >> + - core_conf : R5 core configuration (valid string - split0 or split1 or >> + lock-step), default is lock-step. >> + - memory-region: memories regions for RPU executable and DMA memory. >> + - interrupts : Interrupt mapping for remoteproc IPI. It is required if the >> + user uses the remoteproc driver with the RPMsg kernel driver. >> + - interrupt-parent : Phandle for the interrupt controller. It is required if >> + the user uses the remoteproc driver with the RPMsg kernel >> + kernel driver. >> + >> +Example: >> +-------- >> + reserved-memory { >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + rproc_0_fw_reserved: rproc at 3ed000000 { >> + compatible = "rproc-prog-memory"; >> + no-map; >> + reg = <0x0 0x3ed00000 0x0 0x40000>; >> + }; >> + rproc_0_dma_reserved: rproc at 3ed400000 { >> + compatible = "shared-dma-pool"; >> + no-map; >> + reg = <0x0 0x3ed40000 0x0 0x80000>; >> + }; >> + }; >> + >> + firmware { >> + zynqmp_firmware: zynqmp-firmware { >> + compatible = "xlnx,zynqmp-firmware"; >> + method = "smc"; >> + }; >> + }; >> + >> + zynqmp-r5-remoteproc at 0 { >> + compatible = "xlnx,zynqmp-r5-remoteproc-1.0"; >> + reg = <0x0 0xFFE00000 0x0 0x10000>, >> + <0x0 0xFFE20000 0x0 0x10000>, >> + <0x0 0xff340000 0x0 0x100>; >> + reg-names = "tcm_a", "tcm_b", "ipi"; >> + dma-ranges; >> + core_conf = "split0"; >> + memory-region = <&rproc_0_fw_reserved>, >> + <&rproc_0_dma_reserved>; >> + tcm-pnode-id = <0xf>, <0x10>; >> + rpu-pnode-id = <0x7>; >> + interrupt-parent = <&gic>; >> + interrupts = <0 29 4>; >> + } ; >> -- >> 2.7.4 >> > > Cheers, > Moritz
next prev parent reply other threads:[~2018-08-20 5:55 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-16 7:06 [PATCH 0/7] Add Xilinx ZynqMP R5 remoteproc driver Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` [PATCH 1/7] firmware: xlnx-zynqmp: Add RPU ioctl enums Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` [PATCH 2/7] firmware: xlnx-zynqmp: Add request ack enums Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` [PATCH 3/7] firmware: xilinx-zynqmp: Add request access capability macro Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` [PATCH 4/7] firmware: xlnx-zynqmp: Add request/release node Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` [PATCH 5/7] firmware: xlnx-zynqmp: Add shutdown/wakeup request Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` [PATCH 6/7] remoteproc: Add Xilinx ZynqMP R5 remoteproc Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-24 16:26 ` Wendy Liang 2018-08-24 16:26 ` Wendy Liang 2018-09-10 17:16 ` Wendy Liang 2018-09-10 17:16 ` Wendy Liang 2018-09-10 20:24 ` Loic PALLARDY 2018-09-10 20:24 ` Loic PALLARDY 2018-09-10 20:24 ` Loic PALLARDY 2018-09-10 22:09 ` Jiaying Liang 2018-09-10 22:09 ` Jiaying Liang 2018-09-10 22:09 ` Jiaying Liang 2018-09-10 22:09 ` Jiaying Liang 2018-09-11 7:30 ` Loic PALLARDY 2018-09-11 7:30 ` Loic PALLARDY 2018-09-11 7:30 ` Loic PALLARDY 2018-10-06 5:44 ` Bjorn Andersson 2018-10-06 5:44 ` Bjorn Andersson 2018-08-16 7:06 ` [PATCH 7/7] Documentation: devicetree: Add Xilinx R5 rproc binding Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-16 7:06 ` Wendy Liang 2018-08-17 15:09 ` Rob Herring 2018-08-17 15:09 ` Rob Herring 2018-08-20 5:54 ` Wendy Liang 2018-08-20 5:54 ` Wendy Liang 2018-08-17 16:31 ` Moritz Fischer 2018-08-17 16:31 ` Moritz Fischer 2018-08-20 5:55 ` Wendy Liang [this message] 2018-08-20 5:55 ` Wendy Liang 2018-10-06 5:50 ` Bjorn Andersson 2018-10-06 5:50 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAA07jV8Bf5kxJPiPMGdpqs_6KhMnjnAC4=5GomJBKgTbVSXV4Q@mail.gmail.com' \ --to=sunnyliangjy@gmail.com \ --cc=bjorn.andersson@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=jliang@xilinx.com \ --cc=jollys@xilinx.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-remoteproc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=michal.simek@xilinx.com \ --cc=moritz.fischer@ettus.com \ --cc=ohad@wizery.com \ --cc=rajan.vaja@xilinx.com \ --cc=robh+dt@kernel.org \ --cc=wendy.liang@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.