All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Arnd Bergmann <arnd@kernel.org>, arm-soc <arm@kernel.org>,
	SoC Team <soc@kernel.org>, Olof Johansson <olof@lixom.net>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
	Jack Pham <jackp@codeaurora.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	Kevin Hilman <khilman@baylibre.com>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	Sandeep Maheswaram <sanm@codeaurora.org>,
	Robert Foss <robert.foss@linaro.org>,
	Vinod Koul <vkoul@kernel.org>, Stephen Boyd <swboyd@chromium.org>,
	Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>,
	Andy Gross <agross@kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	satya priya <skakit@codeaurora.org>,
	Abhishek Kumar <kuabhs@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Shawn Guo <shawn.guo@linaro.org>,
	Alexandru M Stan <amstan@chromium.org>,
	Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [GIT PULL] Qualcomm ARM64 DT updates for 5.13
Date: Fri, 9 Apr 2021 02:41:38 +0300	[thread overview]
Message-ID: <CAA8EJprO7jwqaKXXk70hzDJnTU6iX6i2Vk1OxkrwDKFFQQSyEw@mail.gmail.com> (raw)
In-Reply-To: <20210408230522.GS904837@yoga>

On Fri, 9 Apr 2021 at 02:05, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> On Thu 08 Apr 16:53 CDT 2021, Dmitry Baryshkov wrote:
>
> > On Thu, 8 Apr 2021 at 23:05, Arnd Bergmann <arnd@kernel.org> wrote:
> > >
> > > On Thu, Apr 8, 2021 at 6:06 PM Bjorn Andersson
> > > <bjorn.andersson@linaro.org> wrote:
> > > > On Thu 08 Apr 10:24 CDT 2021, Arnd Bergmann wrote:
> > > > > Maybe see if you can address these in a follow-up, to avoid regressions.
> > > > >
> > > >
> > > > I'm about to send you a another set of pull requests with some more
> > > > goodies that was lingering on the list. I will take a look to see if I
> > > > can follow up on that with some fixes for above warnings - and take
> > > > another look at incorporating dtbs_check in my workflow.
> > >
> > > Ok, sounds good. As I mentioned, I'm also just learning how to use
> > > dtbs_check properly. Unfortunately, it takes ages to run on a
> > > non-parallel build,
> > > and using 'make -j32' as I normally do means the output gets reordered
> > > with every run.
> > >
> > > It's probably ok if you figure out how to only run it for the files you
> > > actually change in the Qualcomm tree.
> >
> > Disabling all non-Qualcomm arches makes `make dtbs_check` a little bit
> > less painful.
> >
>
> Yes, this is a trick I'm applying as well.
>
> It would however be nice if one didn't have to disable CONFIG_ARCH_* to
> achieve this, or even better if one could run dtbs_check on a single
> .dtb. In particular since many of the warnings are resolved by fixing
> the bindings, which causes dtbs_check to recheck all files.

As a quick hack: add the following rule to the top-level Makefile:

%.dt.yaml: include/config/kernel.release scripts_dtc
        $(Q)$(MAKE) $(build)=Documentation/devicetree/bindings
Documentation/devicetree/bindings/processed-schema.json
        $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ CHECK_DTBS=y

Now you can run checks for a single device tree by running 'make
ARCH=arm64 ...... sdm845-db845.dy.yaml'

I don't know if it's worth including this into the upstream source tree.

-- 
With best wishes
Dmitry

WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Arnd Bergmann <arnd@kernel.org>, arm-soc <arm@kernel.org>,
	SoC Team <soc@kernel.org>, Olof Johansson <olof@lixom.net>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	 Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
	Jack Pham <jackp@codeaurora.org>,
	 Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Douglas Anderson <dianders@chromium.org>,
	 Kevin Hilman <khilman@baylibre.com>,
	Rajendra Nayak <rnayak@codeaurora.org>,
	 Sandeep Maheswaram <sanm@codeaurora.org>,
	Robert Foss <robert.foss@linaro.org>,
	Vinod Koul <vkoul@kernel.org>, Stephen Boyd <swboyd@chromium.org>,
	 Venkata Lakshmi Narayana Gubba <gubbaven@codeaurora.org>,
	Andy Gross <agross@kernel.org>,
	 linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	satya priya <skakit@codeaurora.org>,
	 Abhishek Kumar <kuabhs@chromium.org>,
	Matthias Kaehlcke <mka@chromium.org>,
	Shawn Guo <shawn.guo@linaro.org>,
	 Alexandru M Stan <amstan@chromium.org>,
	Maulik Shah <mkshah@codeaurora.org>
Subject: Re: [GIT PULL] Qualcomm ARM64 DT updates for 5.13
Date: Fri, 9 Apr 2021 02:41:38 +0300	[thread overview]
Message-ID: <CAA8EJprO7jwqaKXXk70hzDJnTU6iX6i2Vk1OxkrwDKFFQQSyEw@mail.gmail.com> (raw)
Message-ID: <20210408234138.kzpC3MGn8QbF9DdVwf20N3dZskMA3PWnmxh78nnqkgQ@z> (raw)
In-Reply-To: <20210408230522.GS904837@yoga>

On Fri, 9 Apr 2021 at 02:05, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> On Thu 08 Apr 16:53 CDT 2021, Dmitry Baryshkov wrote:
>
> > On Thu, 8 Apr 2021 at 23:05, Arnd Bergmann <arnd@kernel.org> wrote:
> > >
> > > On Thu, Apr 8, 2021 at 6:06 PM Bjorn Andersson
> > > <bjorn.andersson@linaro.org> wrote:
> > > > On Thu 08 Apr 10:24 CDT 2021, Arnd Bergmann wrote:
> > > > > Maybe see if you can address these in a follow-up, to avoid regressions.
> > > > >
> > > >
> > > > I'm about to send you a another set of pull requests with some more
> > > > goodies that was lingering on the list. I will take a look to see if I
> > > > can follow up on that with some fixes for above warnings - and take
> > > > another look at incorporating dtbs_check in my workflow.
> > >
> > > Ok, sounds good. As I mentioned, I'm also just learning how to use
> > > dtbs_check properly. Unfortunately, it takes ages to run on a
> > > non-parallel build,
> > > and using 'make -j32' as I normally do means the output gets reordered
> > > with every run.
> > >
> > > It's probably ok if you figure out how to only run it for the files you
> > > actually change in the Qualcomm tree.
> >
> > Disabling all non-Qualcomm arches makes `make dtbs_check` a little bit
> > less painful.
> >
>
> Yes, this is a trick I'm applying as well.
>
> It would however be nice if one didn't have to disable CONFIG_ARCH_* to
> achieve this, or even better if one could run dtbs_check on a single
> .dtb. In particular since many of the warnings are resolved by fixing
> the bindings, which causes dtbs_check to recheck all files.

As a quick hack: add the following rule to the top-level Makefile:

%.dt.yaml: include/config/kernel.release scripts_dtc
        $(Q)$(MAKE) $(build)=Documentation/devicetree/bindings
Documentation/devicetree/bindings/processed-schema.json
        $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ CHECK_DTBS=y

Now you can run checks for a single device tree by running 'make
ARCH=arm64 ...... sdm845-db845.dy.yaml'

I don't know if it's worth including this into the upstream source tree.

-- 
With best wishes
Dmitry

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-04-08 23:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-04 16:49 [GIT PULL] Qualcomm ARM64 DT updates for 5.13 Bjorn Andersson
2021-04-04 16:49 ` Bjorn Andersson
2021-04-08 15:24 ` Arnd Bergmann
2021-04-08 15:24   ` Arnd Bergmann
2021-04-08 16:06   ` Bjorn Andersson
2021-04-08 16:06     ` Bjorn Andersson
2021-04-08 20:04     ` Arnd Bergmann
2021-04-08 20:04       ` Arnd Bergmann
2021-04-08 21:53       ` Dmitry Baryshkov
2021-04-08 21:53         ` Dmitry Baryshkov
2021-04-08 21:53         ` Dmitry Baryshkov
2021-04-08 23:05         ` Bjorn Andersson
2021-04-08 23:05           ` Bjorn Andersson
2021-04-08 23:41           ` Dmitry Baryshkov [this message]
2021-04-08 23:41             ` Dmitry Baryshkov
2021-04-08 23:41             ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA8EJprO7jwqaKXXk70hzDJnTU6iX6i2Vk1OxkrwDKFFQQSyEw@mail.gmail.com \
    --to=dmitry.baryshkov@linaro.org \
    --cc=agross@kernel.org \
    --cc=amstan@chromium.org \
    --cc=arm@kernel.org \
    --cc=arnd@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=gubbaven@codeaurora.org \
    --cc=jackp@codeaurora.org \
    --cc=khilman@baylibre.com \
    --cc=kuabhs@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=mkshah@codeaurora.org \
    --cc=olof@lixom.net \
    --cc=rnayak@codeaurora.org \
    --cc=robert.foss@linaro.org \
    --cc=saiprakash.ranjan@codeaurora.org \
    --cc=sanm@codeaurora.org \
    --cc=shawn.guo@linaro.org \
    --cc=skakit@codeaurora.org \
    --cc=soc@kernel.org \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=swboyd@chromium.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.