From: Dave Taht <dave.taht@gmail.com> To: Roman Yeryomin <leroi.lists@gmail.com> Cc: "Valo, Kalle" <kvalo@qca.qualcomm.com>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "michal.kazior@tieto.com" <michal.kazior@tieto.com>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: [PATCH] ath10k: disable wake_tx_queue for older devices Date: Mon, 1 Aug 2016 11:04:56 +0200 [thread overview] Message-ID: <CAA93jw6j0pBKnm3Fs=D7V1CUsBnhZKKymbk4=UQuFWKuEAs-+Q@mail.gmail.com> (raw) In-Reply-To: <CACiydb+yNc-UKVRFR-UxTq-YFBDpEDsa1qWNBGCHpe=_zv8o7g@mail.gmail.com> On Mon, Aug 1, 2016 at 1:35 AM, Roman Yeryomin <leroi.lists@gmail.com> wrote: > On 7 July 2016 at 19:30, Valo, Kalle <kvalo@qca.qualcomm.com> wrote: >> Michal Kazior <michal.kazior@tieto.com> writes: >> >>> Ideally wake_tx_queue should be used regardless as >>> it is a requirement for reducing bufferbloat and >>> implementing airtime fairness in the future. >>> >>> However some setups (typically low-end platforms >>> hosting QCA988X) suffer performance regressions >>> with the current wake_tx_queue implementation. >>> Therefore disable it unless it is really >>> beneficial with current codebase (which is when >>> firmware supports smart pull-push tx scheduling). >>> >>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com> >> >> I think it's too late to send this to 4.7 anymore (and this due to my >> vacation). So I'm planning to queue this to 4.8, but if the feedback is >> positive we can always send this to a 4.7 stable release. >> > > Sorry guys, drowned. > So, yes, applying this patch does the job. That is gets me to the > results similar to > https://lists.openwrt.org/pipermail/openwrt-devel/2016-May/041448.html > > Going to try latest code on same system... Can you try increasing the quantum to 1514, and reducing the codel target to 5ms? (without this patch?) > > Regards, > Roman > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k -- Dave Täht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org
WARNING: multiple messages have this Message-ID (diff)
From: Dave Taht <dave.taht@gmail.com> To: Roman Yeryomin <leroi.lists@gmail.com> Cc: "Valo, Kalle" <kvalo@qca.qualcomm.com>, "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>, "michal.kazior@tieto.com" <michal.kazior@tieto.com>, "ath10k@lists.infradead.org" <ath10k@lists.infradead.org> Subject: Re: [PATCH] ath10k: disable wake_tx_queue for older devices Date: Mon, 1 Aug 2016 11:04:56 +0200 [thread overview] Message-ID: <CAA93jw6j0pBKnm3Fs=D7V1CUsBnhZKKymbk4=UQuFWKuEAs-+Q@mail.gmail.com> (raw) In-Reply-To: <CACiydb+yNc-UKVRFR-UxTq-YFBDpEDsa1qWNBGCHpe=_zv8o7g@mail.gmail.com> On Mon, Aug 1, 2016 at 1:35 AM, Roman Yeryomin <leroi.lists@gmail.com> wrote: > On 7 July 2016 at 19:30, Valo, Kalle <kvalo@qca.qualcomm.com> wrote: >> Michal Kazior <michal.kazior@tieto.com> writes: >> >>> Ideally wake_tx_queue should be used regardless as >>> it is a requirement for reducing bufferbloat and >>> implementing airtime fairness in the future. >>> >>> However some setups (typically low-end platforms >>> hosting QCA988X) suffer performance regressions >>> with the current wake_tx_queue implementation. >>> Therefore disable it unless it is really >>> beneficial with current codebase (which is when >>> firmware supports smart pull-push tx scheduling). >>> >>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com> >> >> I think it's too late to send this to 4.7 anymore (and this due to my >> vacation). So I'm planning to queue this to 4.8, but if the feedback is >> positive we can always send this to a 4.7 stable release. >> > > Sorry guys, drowned. > So, yes, applying this patch does the job. That is gets me to the > results similar to > https://lists.openwrt.org/pipermail/openwrt-devel/2016-May/041448.html > > Going to try latest code on same system... Can you try increasing the quantum to 1514, and reducing the codel target to 5ms? (without this patch?) > > Regards, > Roman > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k -- Dave Täht Let's go make home routers and wifi faster! With better software! http://blog.cerowrt.org _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2016-08-01 9:59 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-05-17 12:47 [RFC/RFT] ath10k: disable wake_tx_queue for older devices Michal Kazior 2016-05-17 12:47 ` Michal Kazior 2016-06-02 13:14 ` Valo, Kalle 2016-06-02 13:14 ` Valo, Kalle 2016-06-08 11:39 ` Roman Yeryomin 2016-06-08 11:39 ` Roman Yeryomin 2016-06-29 8:58 ` Valo, Kalle 2016-06-29 8:58 ` Valo, Kalle 2016-06-29 11:52 ` [PATCH] " Michal Kazior 2016-06-29 11:52 ` Michal Kazior 2016-07-07 16:30 ` Valo, Kalle 2016-07-07 16:30 ` Valo, Kalle 2016-07-31 23:35 ` Roman Yeryomin 2016-07-31 23:35 ` Roman Yeryomin 2016-08-01 9:04 ` Dave Taht [this message] 2016-08-01 9:04 ` Dave Taht 2016-08-04 10:07 ` Roman Yeryomin 2016-08-04 10:07 ` Roman Yeryomin 2016-08-04 12:02 ` Dave Taht 2016-08-04 12:02 ` Dave Taht 2016-07-19 13:19 ` Kalle Valo 2016-07-19 13:19 ` Kalle Valo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAA93jw6j0pBKnm3Fs=D7V1CUsBnhZKKymbk4=UQuFWKuEAs-+Q@mail.gmail.com' \ --to=dave.taht@gmail.com \ --cc=ath10k@lists.infradead.org \ --cc=kvalo@qca.qualcomm.com \ --cc=leroi.lists@gmail.com \ --cc=linux-wireless@vger.kernel.org \ --cc=michal.kazior@tieto.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.