All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-phy@lists.infradead.org,
	Mikhail Rudenko <mike.rudenko@gmail.com>,
	linux-media <linux-media@vger.kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/5] phy: phy-rockchip-dphy-rx0: refactor for tx1rx1 addition
Date: Mon, 30 Aug 2021 21:41:36 -0300	[thread overview]
Message-ID: <CAAEAJfB6FBbeEPuzirP2nuU_J9nLFSrczgXYVfNQUZbEJrbc7Q@mail.gmail.com> (raw)
In-Reply-To: <6474995.6kXVAnRFRJ@diego>

Hi Heiko,

On Mon, 30 Aug 2021 at 17:46, Heiko Stübner <heiko@sntech.de> wrote:
>
> Hi Mikhail,
>
> Am Montag, 30. August 2021, 20:07:50 CEST schrieb Mikhail Rudenko:
> > In order to accommodate for rk3399 tx1rx1 addition, make
> > enable/disable function calls indirect via function pointers in
> > rk_dphy_drv_data. Also rename rk_dphy_write and rk_dphy_enable to
> > avoid naming clashes.
>
> You're a bit too late to the party :-( .
>
> The tx1rx1 dphy is living _inside_ the 2nd DSI controller and is
> configured through it.
>

Would you be so kind to push a patch adding some comments to
drivers/phy/rockchip/phy-rockchip-dphy-rx0.c with this information?

Thanks,
Ezequiel

WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-phy@lists.infradead.org,
	Mikhail Rudenko <mike.rudenko@gmail.com>,
	 linux-media <linux-media@vger.kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/5] phy: phy-rockchip-dphy-rx0: refactor for tx1rx1 addition
Date: Mon, 30 Aug 2021 21:41:36 -0300	[thread overview]
Message-ID: <CAAEAJfB6FBbeEPuzirP2nuU_J9nLFSrczgXYVfNQUZbEJrbc7Q@mail.gmail.com> (raw)
In-Reply-To: <6474995.6kXVAnRFRJ@diego>

Hi Heiko,

On Mon, 30 Aug 2021 at 17:46, Heiko Stübner <heiko@sntech.de> wrote:
>
> Hi Mikhail,
>
> Am Montag, 30. August 2021, 20:07:50 CEST schrieb Mikhail Rudenko:
> > In order to accommodate for rk3399 tx1rx1 addition, make
> > enable/disable function calls indirect via function pointers in
> > rk_dphy_drv_data. Also rename rk_dphy_write and rk_dphy_enable to
> > avoid naming clashes.
>
> You're a bit too late to the party :-( .
>
> The tx1rx1 dphy is living _inside_ the 2nd DSI controller and is
> configured through it.
>

Would you be so kind to push a patch adding some comments to
drivers/phy/rockchip/phy-rockchip-dphy-rx0.c with this information?

Thanks,
Ezequiel

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-phy@lists.infradead.org,
	Mikhail Rudenko <mike.rudenko@gmail.com>,
	 linux-media <linux-media@vger.kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/5] phy: phy-rockchip-dphy-rx0: refactor for tx1rx1 addition
Date: Mon, 30 Aug 2021 21:41:36 -0300	[thread overview]
Message-ID: <CAAEAJfB6FBbeEPuzirP2nuU_J9nLFSrczgXYVfNQUZbEJrbc7Q@mail.gmail.com> (raw)
In-Reply-To: <6474995.6kXVAnRFRJ@diego>

Hi Heiko,

On Mon, 30 Aug 2021 at 17:46, Heiko Stübner <heiko@sntech.de> wrote:
>
> Hi Mikhail,
>
> Am Montag, 30. August 2021, 20:07:50 CEST schrieb Mikhail Rudenko:
> > In order to accommodate for rk3399 tx1rx1 addition, make
> > enable/disable function calls indirect via function pointers in
> > rk_dphy_drv_data. Also rename rk_dphy_write and rk_dphy_enable to
> > avoid naming clashes.
>
> You're a bit too late to the party :-( .
>
> The tx1rx1 dphy is living _inside_ the 2nd DSI controller and is
> configured through it.
>

Would you be so kind to push a patch adding some comments to
drivers/phy/rockchip/phy-rockchip-dphy-rx0.c with this information?

Thanks,
Ezequiel

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: linux-phy@lists.infradead.org,
	Mikhail Rudenko <mike.rudenko@gmail.com>,
	 linux-media <linux-media@vger.kernel.org>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	Vinod Koul <vkoul@kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 "open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	 Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/5] phy: phy-rockchip-dphy-rx0: refactor for tx1rx1 addition
Date: Mon, 30 Aug 2021 21:41:36 -0300	[thread overview]
Message-ID: <CAAEAJfB6FBbeEPuzirP2nuU_J9nLFSrczgXYVfNQUZbEJrbc7Q@mail.gmail.com> (raw)
In-Reply-To: <6474995.6kXVAnRFRJ@diego>

Hi Heiko,

On Mon, 30 Aug 2021 at 17:46, Heiko Stübner <heiko@sntech.de> wrote:
>
> Hi Mikhail,
>
> Am Montag, 30. August 2021, 20:07:50 CEST schrieb Mikhail Rudenko:
> > In order to accommodate for rk3399 tx1rx1 addition, make
> > enable/disable function calls indirect via function pointers in
> > rk_dphy_drv_data. Also rename rk_dphy_write and rk_dphy_enable to
> > avoid naming clashes.
>
> You're a bit too late to the party :-( .
>
> The tx1rx1 dphy is living _inside_ the 2nd DSI controller and is
> configured through it.
>

Would you be so kind to push a patch adding some comments to
drivers/phy/rockchip/phy-rockchip-dphy-rx0.c with this information?

Thanks,
Ezequiel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-31  0:41 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 18:07 [PATCH v1 0/5] phy: phy-rockchip-dphy-rx0: add support for tx1rx1 rx mode Mikhail Rudenko
2021-08-30 18:07 ` Mikhail Rudenko
2021-08-30 18:07 ` Mikhail Rudenko
2021-08-30 18:07 ` Mikhail Rudenko
2021-08-30 18:07 ` [PATCH v1 1/5] phy: phy-rockchip-dphy-rx0: refactor for tx1rx1 addition Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 20:45   ` Heiko Stübner
2021-08-30 20:45     ` Heiko Stübner
2021-08-30 20:45     ` Heiko Stübner
2021-08-30 20:45     ` Heiko Stübner
2021-08-31  0:41     ` Ezequiel Garcia [this message]
2021-08-31  0:41       ` Ezequiel Garcia
2021-08-31  0:41       ` Ezequiel Garcia
2021-08-31  0:41       ` Ezequiel Garcia
2021-08-30 18:07 ` [PATCH v1 2/5] phy: phy-rockchip-dphy-rx0: add support for tx1rx1 in receive mode Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07 ` [PATCH v1 3/5] phy: rename phy-rockchip-dphy-rx0 to phy-rockchip-dphy-rx Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07 ` [PATCH v1 4/5] dt-bindings: phy: phy-rockchip-dphy-rx0: add support for tx1rx1 phy Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 21:00   ` Johan Jonker
2021-08-30 21:00     ` Johan Jonker
2021-08-30 21:00     ` Johan Jonker
2021-08-30 21:00     ` Johan Jonker
2021-08-30 22:06     ` Johan Jonker
2021-08-30 22:06       ` Johan Jonker
2021-08-30 22:06       ` Johan Jonker
2021-08-30 22:06       ` Johan Jonker
2021-08-31  0:03   ` Rob Herring
2021-08-31  0:03     ` Rob Herring
2021-08-31  0:03     ` Rob Herring
2021-08-31  0:03     ` Rob Herring
2021-08-30 18:07 ` [PATCH v1 5/5] arm64: dts: rockchip: add mipi-dphy-tx1rx1 for rk3399 Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 18:07   ` Mikhail Rudenko
2021-08-30 21:12   ` Johan Jonker
2021-08-30 21:12     ` Johan Jonker
2021-08-30 21:12     ` Johan Jonker
2021-08-30 21:12     ` Johan Jonker
2021-08-30 21:50     ` Johan Jonker
2021-08-30 21:50       ` Johan Jonker
2021-08-30 21:50       ` Johan Jonker
2021-08-30 21:50       ` Johan Jonker
2021-08-31 12:58 ` [PATCH v1 0/5] phy: phy-rockchip-dphy-rx0: add support for tx1rx1 rx mode Mikhail Rudenko
2021-08-31 12:58   ` Mikhail Rudenko
2021-08-31 12:58   ` Mikhail Rudenko
2021-08-31 12:58   ` Mikhail Rudenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAEAJfB6FBbeEPuzirP2nuU_J9nLFSrczgXYVfNQUZbEJrbc7Q@mail.gmail.com \
    --to=ezequiel@vanguardiasur.com.ar \
    --cc=heiko@sntech.de \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mike.rudenko@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.