From: Tomasz Figa <tfiga@chromium.org>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: mchehab@kernel.org, m.szyprowski@samsung.com, ming.qian@nxp.com,
ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl,
nicolas.dufresne@collabora.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev, kernel@collabora.com
Subject: Re: [PATCH v14 05/56] media: videobuf2: Access vb2_queue bufs array through helper functions
Date: Thu, 9 Nov 2023 13:27:22 +0900 [thread overview]
Message-ID: <CAAFQd5Dd_w50ppjy1_wQ2yX+Qj0mOMWbhJKsJ7Cq6zYsQ+GwyQ@mail.gmail.com> (raw)
In-Reply-To: <795ef94f-23d3-433e-b5a3-0a2e0ab7a18c@collabora.com>
On Wed, Nov 8, 2023 at 7:24 PM Benjamin Gaignard
<benjamin.gaignard@collabora.com> wrote:
>
>
> Le 08/11/2023 à 09:50, Tomasz Figa a écrit :
> > On Tue, Oct 31, 2023 at 05:30:13PM +0100, Benjamin Gaignard wrote:
> >> This patch adds 2 helpers functions to add and remove vb2 buffers
> >> from a queue. With these 2 and vb2_get_buffer(), bufs field of
> >> struct vb2_queue becomes like a private member of the structure.
> >>
> >> After each call to vb2_get_buffer() we need to be sure that we get
> >> a valid pointer in preparation for when buffers can be deleted.
> >>
> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> >> ---
> >> .../media/common/videobuf2/videobuf2-core.c | 151 +++++++++++++-----
> >> .../media/common/videobuf2/videobuf2-v4l2.c | 50 ++++--
> >> 2 files changed, 149 insertions(+), 52 deletions(-)
> >>
> >> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> >> index 968b7c0e7934..b406a30a9b35 100644
> >> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> >> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> >> @@ -408,6 +408,31 @@ static void init_buffer_cache_hints(struct vb2_queue *q, struct vb2_buffer *vb)
> >> vb->skip_cache_sync_on_finish = 1;
> >> }
> >>
> >> +/**
> >> + * vb2_queue_add_buffer() - add a buffer to a queue
> >> + * @q: pointer to &struct vb2_queue with videobuf2 queue.
> >> + * @vb: pointer to &struct vb2_buffer to be added to the queue.
> >> + * @index: index where add vb2_buffer in the queue
> >> + */
> >> +static void vb2_queue_add_buffer(struct vb2_queue *q, struct vb2_buffer *vb, unsigned int index)
> >> +{
> >> + WARN_ON(index >= VB2_MAX_FRAME || q->bufs[index]);
> > nit: Would it make sense to also ensure that vb->vb2_queue is NULL?
>
> Since vb->vb2_queue and q->bufs[index] are always set and clear in the same
> functions I don't think it is useful to test the both here.
>
Well, they are if the caller is not buggy. But I suppose the check is
to detect buggy callers?
For example, an m2m driver could accidentally call this on a buffer
that was already added to another queue.
Best regards,
Tomasz
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tfiga@chromium.org>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: mchehab@kernel.org, m.szyprowski@samsung.com, ming.qian@nxp.com,
ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl,
nicolas.dufresne@collabora.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev, kernel@collabora.com
Subject: Re: [PATCH v14 05/56] media: videobuf2: Access vb2_queue bufs array through helper functions
Date: Thu, 9 Nov 2023 13:27:22 +0900 [thread overview]
Message-ID: <CAAFQd5Dd_w50ppjy1_wQ2yX+Qj0mOMWbhJKsJ7Cq6zYsQ+GwyQ@mail.gmail.com> (raw)
In-Reply-To: <795ef94f-23d3-433e-b5a3-0a2e0ab7a18c@collabora.com>
On Wed, Nov 8, 2023 at 7:24 PM Benjamin Gaignard
<benjamin.gaignard@collabora.com> wrote:
>
>
> Le 08/11/2023 à 09:50, Tomasz Figa a écrit :
> > On Tue, Oct 31, 2023 at 05:30:13PM +0100, Benjamin Gaignard wrote:
> >> This patch adds 2 helpers functions to add and remove vb2 buffers
> >> from a queue. With these 2 and vb2_get_buffer(), bufs field of
> >> struct vb2_queue becomes like a private member of the structure.
> >>
> >> After each call to vb2_get_buffer() we need to be sure that we get
> >> a valid pointer in preparation for when buffers can be deleted.
> >>
> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> >> ---
> >> .../media/common/videobuf2/videobuf2-core.c | 151 +++++++++++++-----
> >> .../media/common/videobuf2/videobuf2-v4l2.c | 50 ++++--
> >> 2 files changed, 149 insertions(+), 52 deletions(-)
> >>
> >> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> >> index 968b7c0e7934..b406a30a9b35 100644
> >> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> >> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> >> @@ -408,6 +408,31 @@ static void init_buffer_cache_hints(struct vb2_queue *q, struct vb2_buffer *vb)
> >> vb->skip_cache_sync_on_finish = 1;
> >> }
> >>
> >> +/**
> >> + * vb2_queue_add_buffer() - add a buffer to a queue
> >> + * @q: pointer to &struct vb2_queue with videobuf2 queue.
> >> + * @vb: pointer to &struct vb2_buffer to be added to the queue.
> >> + * @index: index where add vb2_buffer in the queue
> >> + */
> >> +static void vb2_queue_add_buffer(struct vb2_queue *q, struct vb2_buffer *vb, unsigned int index)
> >> +{
> >> + WARN_ON(index >= VB2_MAX_FRAME || q->bufs[index]);
> > nit: Would it make sense to also ensure that vb->vb2_queue is NULL?
>
> Since vb->vb2_queue and q->bufs[index] are always set and clear in the same
> functions I don't think it is useful to test the both here.
>
Well, they are if the caller is not buggy. But I suppose the check is
to detect buggy callers?
For example, an m2m driver could accidentally call this on a buffer
that was already added to another queue.
Best regards,
Tomasz
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tfiga@chromium.org>
To: Benjamin Gaignard <benjamin.gaignard@collabora.com>
Cc: mchehab@kernel.org, m.szyprowski@samsung.com, ming.qian@nxp.com,
ezequiel@vanguardiasur.com.ar, p.zabel@pengutronix.de,
gregkh@linuxfoundation.org, hverkuil-cisco@xs4all.nl,
nicolas.dufresne@collabora.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
linux-rockchip@lists.infradead.org,
linux-staging@lists.linux.dev, kernel@collabora.com
Subject: Re: [PATCH v14 05/56] media: videobuf2: Access vb2_queue bufs array through helper functions
Date: Thu, 9 Nov 2023 13:27:22 +0900 [thread overview]
Message-ID: <CAAFQd5Dd_w50ppjy1_wQ2yX+Qj0mOMWbhJKsJ7Cq6zYsQ+GwyQ@mail.gmail.com> (raw)
In-Reply-To: <795ef94f-23d3-433e-b5a3-0a2e0ab7a18c@collabora.com>
On Wed, Nov 8, 2023 at 7:24 PM Benjamin Gaignard
<benjamin.gaignard@collabora.com> wrote:
>
>
> Le 08/11/2023 à 09:50, Tomasz Figa a écrit :
> > On Tue, Oct 31, 2023 at 05:30:13PM +0100, Benjamin Gaignard wrote:
> >> This patch adds 2 helpers functions to add and remove vb2 buffers
> >> from a queue. With these 2 and vb2_get_buffer(), bufs field of
> >> struct vb2_queue becomes like a private member of the structure.
> >>
> >> After each call to vb2_get_buffer() we need to be sure that we get
> >> a valid pointer in preparation for when buffers can be deleted.
> >>
> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> >> ---
> >> .../media/common/videobuf2/videobuf2-core.c | 151 +++++++++++++-----
> >> .../media/common/videobuf2/videobuf2-v4l2.c | 50 ++++--
> >> 2 files changed, 149 insertions(+), 52 deletions(-)
> >>
> >> diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c
> >> index 968b7c0e7934..b406a30a9b35 100644
> >> --- a/drivers/media/common/videobuf2/videobuf2-core.c
> >> +++ b/drivers/media/common/videobuf2/videobuf2-core.c
> >> @@ -408,6 +408,31 @@ static void init_buffer_cache_hints(struct vb2_queue *q, struct vb2_buffer *vb)
> >> vb->skip_cache_sync_on_finish = 1;
> >> }
> >>
> >> +/**
> >> + * vb2_queue_add_buffer() - add a buffer to a queue
> >> + * @q: pointer to &struct vb2_queue with videobuf2 queue.
> >> + * @vb: pointer to &struct vb2_buffer to be added to the queue.
> >> + * @index: index where add vb2_buffer in the queue
> >> + */
> >> +static void vb2_queue_add_buffer(struct vb2_queue *q, struct vb2_buffer *vb, unsigned int index)
> >> +{
> >> + WARN_ON(index >= VB2_MAX_FRAME || q->bufs[index]);
> > nit: Would it make sense to also ensure that vb->vb2_queue is NULL?
>
> Since vb->vb2_queue and q->bufs[index] are always set and clear in the same
> functions I don't think it is useful to test the both here.
>
Well, they are if the caller is not buggy. But I suppose the check is
to detect buggy callers?
For example, an m2m driver could accidentally call this on a buffer
that was already added to another queue.
Best regards,
Tomasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-11-09 4:27 UTC|newest]
Thread overview: 399+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 16:30 [PATCH v14 00/56] Add DELETE_BUF ioctl Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` [PATCH v14 01/56] media: videobuf2: Rename offset parameter Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 15:11 ` Andrzej Pietrasiewicz
2023-11-08 15:11 ` Andrzej Pietrasiewicz
2023-11-08 15:11 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 02/56] media: videobuf2: Rework offset 'cookie' encoding pattern Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 6:23 ` Tomasz Figa
2023-11-08 6:23 ` Tomasz Figa
2023-11-08 6:23 ` Tomasz Figa
2023-11-08 10:14 ` Benjamin Gaignard
2023-11-08 10:14 ` Benjamin Gaignard
2023-11-08 10:14 ` Benjamin Gaignard
2023-11-08 10:31 ` Hans Verkuil
2023-11-08 10:31 ` Hans Verkuil
2023-11-08 10:31 ` Hans Verkuil
2023-10-31 16:30 ` [PATCH v14 03/56] media: videobuf2: Stop spamming kernel log with all queue counter Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 15:26 ` Andrzej Pietrasiewicz
2023-11-08 15:26 ` Andrzej Pietrasiewicz
2023-11-08 15:26 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 04/56] media: videobuf2: Use vb2_buffer instead of index Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 8:08 ` Tomasz Figa
2023-11-08 8:08 ` Tomasz Figa
2023-11-08 8:08 ` Tomasz Figa
2023-11-08 15:52 ` Andrzej Pietrasiewicz
2023-11-08 15:52 ` Andrzej Pietrasiewicz
2023-11-08 15:52 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 05/56] media: videobuf2: Access vb2_queue bufs array through helper functions Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 8:50 ` Tomasz Figa
2023-11-08 8:50 ` Tomasz Figa
2023-11-08 8:50 ` Tomasz Figa
2023-11-08 10:24 ` Benjamin Gaignard
2023-11-08 10:24 ` Benjamin Gaignard
2023-11-08 10:24 ` Benjamin Gaignard
2023-11-09 4:27 ` Tomasz Figa [this message]
2023-11-09 4:27 ` Tomasz Figa
2023-11-09 4:27 ` Tomasz Figa
2023-10-31 16:30 ` [PATCH v14 06/56] media: videobuf2: Remove duplicated index vs q->num_buffers check Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 16:46 ` Andrzej Pietrasiewicz
2023-11-08 16:46 ` Andrzej Pietrasiewicz
2023-11-08 16:46 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 07/56] media: videobuf2: Add helper to get queue number of buffers Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 16:50 ` Andrzej Pietrasiewicz
2023-11-08 16:50 ` Andrzej Pietrasiewicz
2023-11-08 16:50 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 08/56] media: videobuf2: Use vb2_get_num_buffers() helper Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 9:42 ` Tomasz Figa
2023-11-08 9:42 ` Tomasz Figa
2023-11-08 9:42 ` Tomasz Figa
2023-11-08 13:22 ` Benjamin Gaignard
2023-11-08 13:22 ` Benjamin Gaignard
2023-11-08 13:22 ` Benjamin Gaignard
2023-11-09 4:36 ` Tomasz Figa
2023-11-09 4:36 ` Tomasz Figa
2023-11-09 4:36 ` Tomasz Figa
2023-10-31 16:30 ` [PATCH v14 09/56] media: amphion: Use vb2_get_buffer() instead of directly access to buffers array Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 16:55 ` Andrzej Pietrasiewicz
2023-11-08 16:55 ` Andrzej Pietrasiewicz
2023-11-08 16:55 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 10/56] media: amphion: Stop direct calls to queue num_buffers field Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 16:56 ` Andrzej Pietrasiewicz
2023-11-08 16:56 ` Andrzej Pietrasiewicz
2023-11-08 16:56 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 11/56] media: mediatek: jpeg: Use vb2_get_buffer() instead of directly access to buffers array Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-08 17:00 ` Andrzej Pietrasiewicz
2023-11-08 17:00 ` Andrzej Pietrasiewicz
2023-11-08 17:00 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 12/56] media: mediatek: vdec: Remove useless loop Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 9:15 ` Andrzej Pietrasiewicz
2023-11-09 9:15 ` Andrzej Pietrasiewicz
2023-11-09 9:15 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 13/56] media: mediatek: vcodec: Stop direct calls to queue num_buffers field Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 9:21 ` Andrzej Pietrasiewicz
2023-11-09 9:21 ` Andrzej Pietrasiewicz
2023-11-09 9:21 ` Andrzej Pietrasiewicz
2023-11-09 9:23 ` Andrzej Pietrasiewicz
2023-11-09 9:23 ` Andrzej Pietrasiewicz
2023-11-09 9:23 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 14/56] media: sti: hva: Use vb2_get_buffer() instead of directly access to buffers array Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 9:29 ` Andrzej Pietrasiewicz
2023-11-09 9:29 ` Andrzej Pietrasiewicz
2023-11-09 9:29 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 15/56] media: visl: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 9:38 ` Andrzej Pietrasiewicz
2023-11-09 9:38 ` Andrzej Pietrasiewicz
2023-11-09 9:38 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 16/56] media: atomisp: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` [PATCH v14 17/56] media: atomisp: Stop direct calls to queue num_buffers field Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` [PATCH v14 18/56] media: dvb-core: Use vb2_get_buffer() instead of directly access to buffers array Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 9:46 ` Andrzej Pietrasiewicz
2023-11-09 9:46 ` Andrzej Pietrasiewicz
2023-11-09 9:46 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 19/56] media: dvb-core: Do not initialize twice queue num_buffer field Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 9:50 ` Andrzej Pietrasiewicz
2023-11-09 9:50 ` Andrzej Pietrasiewicz
2023-11-09 9:50 ` Andrzej Pietrasiewicz
2023-11-09 10:14 ` Benjamin Gaignard
2023-11-09 10:14 ` Benjamin Gaignard
2023-11-09 10:14 ` Benjamin Gaignard
2023-10-31 16:30 ` [PATCH v14 20/56] media: dvb-frontends: rtl2832: Stop direct calls to queue num_buffers field Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 9:56 ` Andrzej Pietrasiewicz
2023-11-09 9:56 ` Andrzej Pietrasiewicz
2023-11-09 9:56 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 21/56] media: pci: dt3155: Remove useless check Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 10:03 ` Andrzej Pietrasiewicz
2023-11-09 10:03 ` Andrzej Pietrasiewicz
2023-11-09 10:03 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 22/56] media: pci: tw686x: Stop direct calls to queue num_buffers field Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 10:05 ` Andrzej Pietrasiewicz
2023-11-09 10:05 ` Andrzej Pietrasiewicz
2023-11-09 10:05 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 23/56] media: pci: cx18: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 10:07 ` Andrzej Pietrasiewicz
2023-11-09 10:07 ` Andrzej Pietrasiewicz
2023-11-09 10:07 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 24/56] media: pci: netup_unidvb: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 10:09 ` Andrzej Pietrasiewicz
2023-11-09 10:09 ` Andrzej Pietrasiewicz
2023-11-09 10:09 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 25/56] media: pci: tw68: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 10:13 ` Andrzej Pietrasiewicz
2023-11-09 10:13 ` Andrzej Pietrasiewicz
2023-11-09 10:13 ` Andrzej Pietrasiewicz
2023-11-09 10:23 ` Benjamin Gaignard
2023-11-09 10:23 ` Benjamin Gaignard
2023-11-09 10:23 ` Benjamin Gaignard
2023-10-31 16:30 ` [PATCH v14 26/56] media: i2c: video-i2c: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 10:18 ` Andrzej Pietrasiewicz
2023-11-09 10:18 ` Andrzej Pietrasiewicz
2023-11-09 10:18 ` Andrzej Pietrasiewicz
2023-11-09 10:26 ` Benjamin Gaignard
2023-11-09 10:26 ` Benjamin Gaignard
2023-11-09 10:26 ` Benjamin Gaignard
2023-10-31 16:30 ` [PATCH v14 27/56] media: coda: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 10:22 ` Andrzej Pietrasiewicz
2023-11-09 10:22 ` Andrzej Pietrasiewicz
2023-11-09 10:22 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 28/56] media: nxp: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 10:26 ` Andrzej Pietrasiewicz
2023-11-09 10:26 ` Andrzej Pietrasiewicz
2023-11-09 10:26 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 29/56] media: verisilicon: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 10:28 ` Andrzej Pietrasiewicz
2023-11-09 10:28 ` Andrzej Pietrasiewicz
2023-11-09 10:28 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 30/56] media: test-drivers: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:10 ` Andrzej Pietrasiewicz
2023-11-09 11:10 ` Andrzej Pietrasiewicz
2023-11-09 11:10 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 31/56] media: imx: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:12 ` Andrzej Pietrasiewicz
2023-11-09 11:12 ` Andrzej Pietrasiewicz
2023-11-09 11:12 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 32/56] media: meson: vdec: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:17 ` Andrzej Pietrasiewicz
2023-11-09 11:17 ` Andrzej Pietrasiewicz
2023-11-09 11:17 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 33/56] touchscreen: sur40: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:19 ` Andrzej Pietrasiewicz
2023-11-09 11:19 ` Andrzej Pietrasiewicz
2023-11-09 11:19 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 34/56] sample: v4l: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:19 ` Andrzej Pietrasiewicz
2023-11-09 11:19 ` Andrzej Pietrasiewicz
2023-11-09 11:19 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 35/56] media: cedrus: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:27 ` Andrzej Pietrasiewicz
2023-11-09 11:27 ` Andrzej Pietrasiewicz
2023-11-09 11:27 ` Andrzej Pietrasiewicz
2023-11-09 14:14 ` Paul Kocialkowski
2023-11-09 14:14 ` Paul Kocialkowski
2023-11-09 14:14 ` Paul Kocialkowski
2023-11-09 15:48 ` Andrzej Pietrasiewicz
2023-11-09 15:48 ` Andrzej Pietrasiewicz
2023-11-09 15:48 ` Andrzej Pietrasiewicz
2023-11-09 15:54 ` Benjamin Gaignard
2023-11-09 15:54 ` Benjamin Gaignard
2023-11-09 15:54 ` Benjamin Gaignard
2023-11-09 16:29 ` Paul Kocialkowski
2023-11-09 16:29 ` Paul Kocialkowski
2023-11-09 16:29 ` Paul Kocialkowski
2023-10-31 16:30 ` [PATCH v14 36/56] media: nuvoton: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:29 ` Andrzej Pietrasiewicz
2023-11-09 11:29 ` Andrzej Pietrasiewicz
2023-11-09 11:29 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 37/56] media: renesas: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:30 ` Andrzej Pietrasiewicz
2023-11-09 11:30 ` Andrzej Pietrasiewicz
2023-11-09 11:30 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 38/56] media: ti: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:32 ` Andrzej Pietrasiewicz
2023-11-09 11:32 ` Andrzej Pietrasiewicz
2023-11-09 11:32 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 39/56] media: usb: airspy: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:33 ` Andrzej Pietrasiewicz
2023-11-09 11:33 ` Andrzej Pietrasiewicz
2023-11-09 11:33 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 40/56] media: usb: cx231xx: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:35 ` Andrzej Pietrasiewicz
2023-11-09 11:35 ` Andrzej Pietrasiewicz
2023-11-09 11:35 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 41/56] media: usb: hackrf: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:36 ` Andrzej Pietrasiewicz
2023-11-09 11:36 ` Andrzej Pietrasiewicz
2023-11-09 11:36 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 42/56] media: usb: usbtv: " Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 11:37 ` Andrzej Pietrasiewicz
2023-11-09 11:37 ` Andrzej Pietrasiewicz
2023-11-09 11:37 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 43/56] media: videobuf2: Be more flexible on the number of queue stored buffers Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-02 8:17 ` Hans Verkuil
2023-11-02 8:17 ` Hans Verkuil
2023-11-02 8:17 ` Hans Verkuil
2023-11-06 14:29 ` Benjamin Gaignard
2023-11-06 14:29 ` Benjamin Gaignard
2023-11-06 14:29 ` Benjamin Gaignard
2023-10-31 16:30 ` [PATCH v14 44/56] media: core: Report the maximum possible number of buffers for the queue Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 12:28 ` Andrzej Pietrasiewicz
2023-11-09 12:28 ` Andrzej Pietrasiewicz
2023-11-09 12:28 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 45/56] media: test-drivers: vivid: Increase max supported buffers for capture queues Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 12:31 ` Andrzej Pietrasiewicz
2023-11-09 12:31 ` Andrzej Pietrasiewicz
2023-11-09 12:31 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 46/56] media: test-drivers: vicodec: Increase max supported capture queue buffers Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 12:32 ` Andrzej Pietrasiewicz
2023-11-09 12:32 ` Andrzej Pietrasiewicz
2023-11-09 12:32 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 47/56] media: verisilicon: Refactor postprocessor to store more buffers Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 13:58 ` Andrzej Pietrasiewicz
2023-11-09 13:58 ` Andrzej Pietrasiewicz
2023-11-09 13:58 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 48/56] media: verisilicon: Store chroma and motion vectors offset Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 14:12 ` Andrzej Pietrasiewicz
2023-11-09 14:12 ` Andrzej Pietrasiewicz
2023-11-09 14:12 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 49/56] media: verisilicon: g2: Use common helpers to compute chroma and mv offsets Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 14:25 ` Andrzej Pietrasiewicz
2023-11-09 14:25 ` Andrzej Pietrasiewicz
2023-11-09 14:25 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 50/56] media: verisilicon: vp9: Allow to change resolution while streaming Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-11-09 14:59 ` Andrzej Pietrasiewicz
2023-11-09 14:59 ` Andrzej Pietrasiewicz
2023-11-09 14:59 ` Andrzej Pietrasiewicz
2023-10-31 16:30 ` [PATCH v14 51/56] media: core: Rework how create_buf index returned value is computed Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:30 ` Benjamin Gaignard
2023-10-31 16:31 ` [PATCH v14 52/56] media: core: Add bitmap manage bufs array entries Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-11-08 10:44 ` Tomasz Figa
2023-11-08 10:44 ` Tomasz Figa
2023-11-08 10:44 ` Tomasz Figa
2023-11-08 15:30 ` Benjamin Gaignard
2023-11-08 15:30 ` Benjamin Gaignard
2023-11-08 15:30 ` Benjamin Gaignard
2023-11-09 7:28 ` Tomasz Figa
2023-11-09 7:28 ` Tomasz Figa
2023-11-09 7:28 ` Tomasz Figa
2023-10-31 16:31 ` [PATCH v14 53/56] media: core: Free range of buffers Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-11-09 9:10 ` Tomasz Figa
2023-11-09 9:10 ` Tomasz Figa
2023-11-09 9:10 ` Tomasz Figa
2023-10-31 16:31 ` [PATCH v14 54/56] media: v4l2: Add DELETE_BUFS ioctl Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-11-09 9:30 ` Tomasz Figa
2023-11-09 9:30 ` Tomasz Figa
2023-11-09 9:30 ` Tomasz Figa
2023-11-09 10:10 ` Benjamin Gaignard
2023-11-09 10:10 ` Benjamin Gaignard
2023-11-09 10:10 ` Benjamin Gaignard
2023-11-10 8:58 ` Tomasz Figa
2023-11-10 8:58 ` Tomasz Figa
2023-11-10 8:58 ` Tomasz Figa
2023-11-10 9:14 ` Hans Verkuil
2023-11-10 9:14 ` Hans Verkuil
2023-11-10 9:14 ` Hans Verkuil
2023-11-10 9:19 ` Tomasz Figa
2023-11-10 9:19 ` Tomasz Figa
2023-11-10 9:19 ` Tomasz Figa
2023-10-31 16:31 ` [PATCH v14 55/56] media: v4l2: Add mem2mem helpers for " Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-10-31 16:31 ` [PATCH v14 56/56] media: test-drivers: Use helper " Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-10-31 16:31 ` Benjamin Gaignard
2023-11-09 9:43 ` Tomasz Figa
2023-11-09 9:43 ` Tomasz Figa
2023-11-09 9:43 ` Tomasz Figa
2023-11-09 9:46 ` Benjamin Gaignard
2023-11-09 9:46 ` Benjamin Gaignard
2023-11-09 9:46 ` Benjamin Gaignard
2023-11-09 9:48 ` Tomasz Figa
2023-11-09 9:48 ` Tomasz Figa
2023-11-09 9:48 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAFQd5Dd_w50ppjy1_wQ2yX+Qj0mOMWbhJKsJ7Cq6zYsQ+GwyQ@mail.gmail.com \
--to=tfiga@chromium.org \
--cc=benjamin.gaignard@collabora.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=ming.qian@nxp.com \
--cc=nicolas.dufresne@collabora.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.