Re: [PATCH v3 2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc

From: Ikjoon Jang <ikjn@chromium.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-usb@vger.kernel.org,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>,
	Eddie Hung <eddie.hung@mediatek.com>,
	Sergei Shtylyov <sergei.shtylyov@gmail.com>
Subject: Re: [PATCH v3 2/4] usb: xhci-mtk: remove unnecessary setting of has_ippc
Date: Thu, 10 Jun 2021 11:32:17 +0800	[thread overview]
Message-ID: <CAATdQgAr=wwbuJ=0nKKmO6Rb7qcW2BobFAb30DUsMA2s6EOxhA@mail.gmail.com> (raw)
In-Reply-To: <20210507021127.54717-2-chunfeng.yun@mediatek.com>

On Fri, May 7, 2021 at 10:11 AM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> Due to @has_ippc's default value is 0, no need set it again if fail
> to get ippc base address
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>

Reviewed-and-Tested-by: Ikjoon Jang <ikjn@chromium.org>

> ---
> v3: new patch suggested by Greg
>     fix typo suggested by Sergei
> ---
>  drivers/usb/host/xhci-mtk.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index b2058b3bc834..2548976bcf05 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -495,8 +495,6 @@ static int xhci_mtk_probe(struct platform_device *pdev)
>                         goto put_usb2_hcd;
>                 }
>                 mtk->has_ippc = true;
> -       } else {
> -               mtk->has_ippc = false;
>         }
>
>         device_init_wakeup(dev, true);
> --
> 2.18.0
>