From: Ikjoon Jang <ikjn@chromium.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-usb@vger.kernel.org,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Eddie Hung <eddie.hung@mediatek.com>
Subject: Re: [PATCH 04/11] usb: xhci-mtk: fix use-after-free of mtk->hcd
Date: Fri, 13 Aug 2021 13:26:30 +0800 [thread overview]
Message-ID: <CAATdQgBeFHJV+=phaEBaXpKwMJygtGVzxJ0yC5hfvijpgwVMAg@mail.gmail.com> (raw)
In-Reply-To: <1627635002-24521-4-git-send-email-chunfeng.yun@mediatek.com>
On Fri, Jul 30, 2021 at 4:50 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> BUG: KASAN: use-after-free in usb_hcd_is_primary_hcd+0x38/0x60
> Call trace:
> dump_backtrace+0x0/0x3dc
> show_stack+0x20/0x2c
> dump_stack+0x15c/0x1d4
> print_address_description+0x7c/0x510
> kasan_report+0x164/0x1ac
> __asan_report_load8_noabort+0x44/0x50
> usb_hcd_is_primary_hcd+0x38/0x60
> xhci_mtk_runtime_suspend+0x68/0x148
> pm_generic_runtime_suspend+0x90/0xac
> __rpm_callback+0xb8/0x1f4
> rpm_callback+0x54/0x1d0
> rpm_suspend+0x4e0/0xc84
> __pm_runtime_suspend+0xc4/0x114
> xhci_mtk_probe+0xa58/0xd00
>
> This may happen when probe fails, needn't suspend it synchronously,
> fix it by using pm_runtime_put_noidle().
>
> Reported-by: Pi Hsun <pihsun@google.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-and-Tested-by: Ikjoon Jang <ikjn@chromium.org>
> ---
> drivers/usb/host/xhci-mtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 2548976bcf05..cb27569186a0 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -569,7 +569,7 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> xhci_mtk_ldos_disable(mtk);
>
> disable_pm:
> - pm_runtime_put_sync_autosuspend(dev);
> + pm_runtime_put_noidle(dev);
> pm_runtime_disable(dev);
> return ret;
> }
> --
> 2.18.0
>
WARNING: multiple messages have this Message-ID (diff)
From: Ikjoon Jang <ikjn@chromium.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-usb@vger.kernel.org,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Eddie Hung <eddie.hung@mediatek.com>
Subject: Re: [PATCH 04/11] usb: xhci-mtk: fix use-after-free of mtk->hcd
Date: Fri, 13 Aug 2021 13:26:30 +0800 [thread overview]
Message-ID: <CAATdQgBeFHJV+=phaEBaXpKwMJygtGVzxJ0yC5hfvijpgwVMAg@mail.gmail.com> (raw)
In-Reply-To: <1627635002-24521-4-git-send-email-chunfeng.yun@mediatek.com>
On Fri, Jul 30, 2021 at 4:50 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> BUG: KASAN: use-after-free in usb_hcd_is_primary_hcd+0x38/0x60
> Call trace:
> dump_backtrace+0x0/0x3dc
> show_stack+0x20/0x2c
> dump_stack+0x15c/0x1d4
> print_address_description+0x7c/0x510
> kasan_report+0x164/0x1ac
> __asan_report_load8_noabort+0x44/0x50
> usb_hcd_is_primary_hcd+0x38/0x60
> xhci_mtk_runtime_suspend+0x68/0x148
> pm_generic_runtime_suspend+0x90/0xac
> __rpm_callback+0xb8/0x1f4
> rpm_callback+0x54/0x1d0
> rpm_suspend+0x4e0/0xc84
> __pm_runtime_suspend+0xc4/0x114
> xhci_mtk_probe+0xa58/0xd00
>
> This may happen when probe fails, needn't suspend it synchronously,
> fix it by using pm_runtime_put_noidle().
>
> Reported-by: Pi Hsun <pihsun@google.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-and-Tested-by: Ikjoon Jang <ikjn@chromium.org>
> ---
> drivers/usb/host/xhci-mtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 2548976bcf05..cb27569186a0 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -569,7 +569,7 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> xhci_mtk_ldos_disable(mtk);
>
> disable_pm:
> - pm_runtime_put_sync_autosuspend(dev);
> + pm_runtime_put_noidle(dev);
> pm_runtime_disable(dev);
> return ret;
> }
> --
> 2.18.0
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Ikjoon Jang <ikjn@chromium.org>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-usb@vger.kernel.org,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Eddie Hung <eddie.hung@mediatek.com>
Subject: Re: [PATCH 04/11] usb: xhci-mtk: fix use-after-free of mtk->hcd
Date: Fri, 13 Aug 2021 13:26:30 +0800 [thread overview]
Message-ID: <CAATdQgBeFHJV+=phaEBaXpKwMJygtGVzxJ0yC5hfvijpgwVMAg@mail.gmail.com> (raw)
In-Reply-To: <1627635002-24521-4-git-send-email-chunfeng.yun@mediatek.com>
On Fri, Jul 30, 2021 at 4:50 PM Chunfeng Yun <chunfeng.yun@mediatek.com> wrote:
>
> BUG: KASAN: use-after-free in usb_hcd_is_primary_hcd+0x38/0x60
> Call trace:
> dump_backtrace+0x0/0x3dc
> show_stack+0x20/0x2c
> dump_stack+0x15c/0x1d4
> print_address_description+0x7c/0x510
> kasan_report+0x164/0x1ac
> __asan_report_load8_noabort+0x44/0x50
> usb_hcd_is_primary_hcd+0x38/0x60
> xhci_mtk_runtime_suspend+0x68/0x148
> pm_generic_runtime_suspend+0x90/0xac
> __rpm_callback+0xb8/0x1f4
> rpm_callback+0x54/0x1d0
> rpm_suspend+0x4e0/0xc84
> __pm_runtime_suspend+0xc4/0x114
> xhci_mtk_probe+0xa58/0xd00
>
> This may happen when probe fails, needn't suspend it synchronously,
> fix it by using pm_runtime_put_noidle().
>
> Reported-by: Pi Hsun <pihsun@google.com>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Reviewed-and-Tested-by: Ikjoon Jang <ikjn@chromium.org>
> ---
> drivers/usb/host/xhci-mtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 2548976bcf05..cb27569186a0 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -569,7 +569,7 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> xhci_mtk_ldos_disable(mtk);
>
> disable_pm:
> - pm_runtime_put_sync_autosuspend(dev);
> + pm_runtime_put_noidle(dev);
> pm_runtime_disable(dev);
> return ret;
> }
> --
> 2.18.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-13 5:26 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 8:49 [PATCH 01/11] dt-bindings: usb: mtk-xhci: add support property 'tpl-support' Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` [PATCH 02/11] dt-bindings: usb: mtk-xhci: add optional property to disable usb2 ports Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-08-06 20:41 ` Rob Herring
2021-08-06 20:41 ` Rob Herring
2021-08-06 20:41 ` Rob Herring
2021-08-11 8:12 ` Chunfeng Yun (云春峰)
2021-07-30 8:49 ` [PATCH 03/11] dt-bindings: usb: mtk-xhci: add compatible for mt8195 Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-08-06 20:43 ` Rob Herring
2021-08-06 20:43 ` Rob Herring
2021-08-06 20:43 ` Rob Herring
2021-08-11 8:02 ` Chunfeng Yun (云春峰)
2021-08-18 14:20 ` Rob Herring
2021-08-18 14:20 ` Rob Herring
2021-08-18 14:20 ` Rob Herring
2021-08-19 11:36 ` Chunfeng Yun (云春峰)
2021-07-30 8:49 ` [PATCH 04/11] usb: xhci-mtk: fix use-after-free of mtk->hcd Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-08-13 5:26 ` Ikjoon Jang [this message]
2021-08-13 5:26 ` Ikjoon Jang
2021-08-13 5:26 ` Ikjoon Jang
2021-07-30 8:49 ` [PATCH 05/11] usb: xhci-mtk: add support 'tpl-support' Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` [PATCH 06/11] usb: xhci-mtk: support option to disable usb2 ports Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` [PATCH 07/11] usb: xhci-mtk: fix issue of out-of-bounds array access Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` [PATCH 08/11] usb: xhci-mtk: update fs bus bandwidth by bw_budget_table Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-07-30 8:49 ` Chunfeng Yun
2021-08-03 6:05 ` Ikjoon Jang
2021-08-03 6:05 ` Ikjoon Jang
2021-08-03 6:05 ` Ikjoon Jang
2021-08-04 5:19 ` Chunfeng Yun
2021-08-04 5:19 ` Chunfeng Yun
2021-08-04 5:19 ` Chunfeng Yun
2021-08-04 14:06 ` Ikjoon Jang
2021-08-04 14:06 ` Ikjoon Jang
2021-08-04 14:06 ` Ikjoon Jang
2021-08-10 1:45 ` Chunfeng Yun (云春峰)
2021-07-30 8:50 ` [PATCH 09/11] usb: xhci-mtk: check boundary before check tt Chunfeng Yun
2021-07-30 8:50 ` Chunfeng Yun
2021-07-30 8:50 ` Chunfeng Yun
2021-08-09 7:32 ` Ikjoon Jang
2021-08-09 7:32 ` Ikjoon Jang
2021-08-09 7:32 ` Ikjoon Jang
2021-08-11 8:18 ` Chunfeng Yun (云春峰)
2021-07-30 8:50 ` [PATCH 10/11] usb: xhci-mtk: add a member of num_esit Chunfeng Yun
2021-07-30 8:50 ` Chunfeng Yun
2021-07-30 8:50 ` Chunfeng Yun
2021-07-30 8:50 ` [PATCH 11/11] usb: xhci-mtk: modify the SOF/ITP interval for mt8195 Chunfeng Yun
2021-07-30 8:50 ` Chunfeng Yun
2021-07-30 8:50 ` Chunfeng Yun
2021-08-06 20:37 ` [PATCH 01/11] dt-bindings: usb: mtk-xhci: add support property 'tpl-support' Rob Herring
2021-08-06 20:37 ` Rob Herring
2021-08-06 20:37 ` Rob Herring
2021-08-11 7:54 ` Chunfeng Yun (云春峰)
2021-08-12 2:28 ` Chunfeng Yun (云春峰)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAATdQgBeFHJV+=phaEBaXpKwMJygtGVzxJ0yC5hfvijpgwVMAg@mail.gmail.com' \
--to=ikjn@chromium.org \
--cc=chunfeng.yun@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=eddie.hung@mediatek.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.