From: Andrey Konovalov <andreyknvl@google.com> To: Vincenzo Frascino <vincenzo.frascino@arm.com> Cc: Alexander Potapenko <glider@google.com>, Branislav Rankov <Branislav.Rankov@arm.com>, Marco Elver <elver@google.com>, Catalin Marinas <catalin.marinas@arm.com>, Evgenii Stepanov <eugenis@google.com>, LKML <linux-kernel@vger.kernel.org>, kasan-dev <kasan-dev@googlegroups.com>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Andrew Morton <akpm@linux-foundation.org>, Will Deacon <will@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH v9 3/4] kasan: Add report for async mode Date: Fri, 29 Jan 2021 19:44:08 +0100 [thread overview] Message-ID: <CAAeHK+wcVMeqct2ime45eXckUpj7uvfuPe801tmRsFdxVLY-Fw@mail.gmail.com> (raw) In-Reply-To: <8021dbc4-8745-2430-8d52-6236ae8c47c7@arm.com> On Fri, Jan 29, 2021 at 7:42 PM Vincenzo Frascino <vincenzo.frascino@arm.com> wrote: > > Hi Andrey, > > On 1/29/21 6:16 PM, Vincenzo Frascino wrote: > > What I meant is instead of: > > > > if (addr) trace_error_report_end(...); > > > > you might want to do: > > > > if (!IS_ENABLED(CONFIG_KASAN_HW_TAGS)) trace_error_report_end(...); > > > > because, could make sense to trace 0 in other cases? > > > > I could not find the implementation of trace_error_report_end() hence I am not > > really sure on what it does. > > I figured it out how trace_error_report_end() works. It's intended for collecting crashes for CONFIG_KASAN_HW_TAGS. > And in doing that I > realized that the problem is sync vs async, hence I agree with what you are > proposing: > > if (addr) trace_error_report_end(...); > > I will post v10 shortly. If we want to trace the async mode we can improve it in > -rc1. Sounds good, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: Andrey Konovalov <andreyknvl@google.com> To: Vincenzo Frascino <vincenzo.frascino@arm.com> Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>, Branislav Rankov <Branislav.Rankov@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Marco Elver <elver@google.com>, kasan-dev <kasan-dev@googlegroups.com>, LKML <linux-kernel@vger.kernel.org>, Alexander Potapenko <glider@google.com>, Dmitry Vyukov <dvyukov@google.com>, Andrey Ryabinin <aryabinin@virtuozzo.com>, Andrew Morton <akpm@linux-foundation.org>, Will Deacon <will@kernel.org>, Evgenii Stepanov <eugenis@google.com> Subject: Re: [PATCH v9 3/4] kasan: Add report for async mode Date: Fri, 29 Jan 2021 19:44:08 +0100 [thread overview] Message-ID: <CAAeHK+wcVMeqct2ime45eXckUpj7uvfuPe801tmRsFdxVLY-Fw@mail.gmail.com> (raw) In-Reply-To: <8021dbc4-8745-2430-8d52-6236ae8c47c7@arm.com> On Fri, Jan 29, 2021 at 7:42 PM Vincenzo Frascino <vincenzo.frascino@arm.com> wrote: > > Hi Andrey, > > On 1/29/21 6:16 PM, Vincenzo Frascino wrote: > > What I meant is instead of: > > > > if (addr) trace_error_report_end(...); > > > > you might want to do: > > > > if (!IS_ENABLED(CONFIG_KASAN_HW_TAGS)) trace_error_report_end(...); > > > > because, could make sense to trace 0 in other cases? > > > > I could not find the implementation of trace_error_report_end() hence I am not > > really sure on what it does. > > I figured it out how trace_error_report_end() works. It's intended for collecting crashes for CONFIG_KASAN_HW_TAGS. > And in doing that I > realized that the problem is sync vs async, hence I agree with what you are > proposing: > > if (addr) trace_error_report_end(...); > > I will post v10 shortly. If we want to trace the async mode we can improve it in > -rc1. Sounds good, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-29 18:45 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-26 13:45 [PATCH v9 0/4] arm64: ARMv8.5-A: MTE: Add async mode support Vincenzo Frascino 2021-01-26 13:45 ` Vincenzo Frascino 2021-01-26 13:46 ` [PATCH v9 1/4] arm64: mte: Add asynchronous " Vincenzo Frascino 2021-01-26 13:46 ` Vincenzo Frascino 2021-01-26 13:46 ` [PATCH v9 2/4] kasan: Add KASAN mode kernel parameter Vincenzo Frascino 2021-01-26 13:46 ` Vincenzo Frascino 2021-01-26 13:46 ` [PATCH v9 3/4] kasan: Add report for async mode Vincenzo Frascino 2021-01-26 13:46 ` Vincenzo Frascino 2021-01-29 17:40 ` Andrey Konovalov 2021-01-29 17:40 ` Andrey Konovalov 2021-01-29 17:48 ` Vincenzo Frascino 2021-01-29 17:48 ` Vincenzo Frascino 2021-01-29 17:56 ` Andrey Konovalov 2021-01-29 17:56 ` Andrey Konovalov 2021-01-29 18:01 ` Vincenzo Frascino 2021-01-29 18:01 ` Vincenzo Frascino 2021-01-29 18:10 ` Andrey Konovalov 2021-01-29 18:10 ` Andrey Konovalov 2021-01-29 18:18 ` Vincenzo Frascino 2021-01-29 18:18 ` Vincenzo Frascino 2021-01-29 18:00 ` Vincenzo Frascino 2021-01-29 18:00 ` Vincenzo Frascino 2021-01-29 18:09 ` Andrey Konovalov 2021-01-29 18:09 ` Andrey Konovalov 2021-01-29 18:16 ` Vincenzo Frascino 2021-01-29 18:16 ` Vincenzo Frascino 2021-01-29 18:46 ` Vincenzo Frascino 2021-01-29 18:46 ` Vincenzo Frascino 2021-01-29 18:44 ` Andrey Konovalov [this message] 2021-01-29 18:44 ` Andrey Konovalov 2021-01-26 13:46 ` [PATCH v9 4/4] arm64: mte: Enable async tag check fault Vincenzo Frascino 2021-01-26 13:46 ` Vincenzo Frascino 2021-01-27 20:00 ` [PATCH v9 0/4] arm64: ARMv8.5-A: MTE: Add async mode support Andrey Konovalov 2021-01-27 20:00 ` Andrey Konovalov 2021-01-27 22:19 ` Will Deacon 2021-01-27 22:19 ` Will Deacon 2021-01-29 17:54 ` Vincenzo Frascino 2021-01-29 17:54 ` Vincenzo Frascino
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAeHK+wcVMeqct2ime45eXckUpj7uvfuPe801tmRsFdxVLY-Fw@mail.gmail.com \ --to=andreyknvl@google.com \ --cc=Branislav.Rankov@arm.com \ --cc=akpm@linux-foundation.org \ --cc=aryabinin@virtuozzo.com \ --cc=catalin.marinas@arm.com \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=eugenis@google.com \ --cc=glider@google.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=vincenzo.frascino@arm.com \ --cc=will@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.