From: Chunyan Zhang <zhang.lyra@gmail.com> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>, Mark Brown <broonie@kernel.org>, Nicolas Ferre <nicolas.ferre@microchip.com>, Alexandre Belloni <alexandre.belloni@bootlin.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>, Scott Branden <sbranden@broadcom.com>, bcm-kernel-feedback-list@broadcom.com, Andy Gross <agross@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Orson Zhai <orsonzhai@gmail.com>, Baolin Wang <baolin.wang7@gmail.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, Masahisa Kojima <masahisa.kojima@linaro.org>, Jassi Brar <jaswinder.singh@linaro.org>, Laxman Dewangan <ldewangan@nvidia.com>, Thierry Reding <thierry.reding@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, linux-spi@vger.kernel.org, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-rpi-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-tegra@vger.kernel.org Subject: Re: [PATCH 02/11] spi: sprd: Simplify with dev_err_probe() Date: Tue, 8 Sep 2020 15:27:29 +0800 [thread overview] Message-ID: <CAAfSe-v4o-9zQZOSgQfAU-C4ruJU7BJdHRe4ikghx7AFgh1qgg@mail.gmail.com> (raw) In-Reply-To: <20200901152713.18629-2-krzk@kernel.org> On Tue, 1 Sep 2020 at 23:27, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> Thanks, Chunyan > --- > drivers/spi/spi-sprd-adi.c | 5 +---- > drivers/spi/spi-sprd.c | 17 +++++------------ > 2 files changed, 6 insertions(+), 16 deletions(-) > > diff --git a/drivers/spi/spi-sprd-adi.c b/drivers/spi/spi-sprd-adi.c > index 127b8bd25831..392ec5cfa3d6 100644 > --- a/drivers/spi/spi-sprd-adi.c > +++ b/drivers/spi/spi-sprd-adi.c > @@ -504,10 +504,7 @@ static int sprd_adi_probe(struct platform_device *pdev) > dev_info(&pdev->dev, "no hardware spinlock supplied\n"); > break; > default: > - dev_err(&pdev->dev, > - "failed to find hwlock id, %d\n", ret); > - fallthrough; > - case -EPROBE_DEFER: > + dev_err_probe(&pdev->dev, ret, "failed to find hwlock id\n"); > goto put_ctlr; > } > } > diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c > index 0443fec3a6ab..635738f54c73 100644 > --- a/drivers/spi/spi-sprd.c > +++ b/drivers/spi/spi-sprd.c > @@ -553,22 +553,15 @@ static int sprd_spi_dma_tx_config(struct sprd_spi *ss, struct spi_transfer *t) > static int sprd_spi_dma_request(struct sprd_spi *ss) > { > ss->dma.dma_chan[SPRD_SPI_RX] = dma_request_chan(ss->dev, "rx_chn"); > - if (IS_ERR_OR_NULL(ss->dma.dma_chan[SPRD_SPI_RX])) { > - if (PTR_ERR(ss->dma.dma_chan[SPRD_SPI_RX]) == -EPROBE_DEFER) > - return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_RX]); > - > - dev_err(ss->dev, "request RX DMA channel failed!\n"); > - return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_RX]); > - } > + if (IS_ERR_OR_NULL(ss->dma.dma_chan[SPRD_SPI_RX])) > + return dev_err_probe(ss->dev, PTR_ERR(ss->dma.dma_chan[SPRD_SPI_RX]), > + "request RX DMA channel failed!\n"); > > ss->dma.dma_chan[SPRD_SPI_TX] = dma_request_chan(ss->dev, "tx_chn"); > if (IS_ERR_OR_NULL(ss->dma.dma_chan[SPRD_SPI_TX])) { > dma_release_channel(ss->dma.dma_chan[SPRD_SPI_RX]); > - if (PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]) == -EPROBE_DEFER) > - return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]); > - > - dev_err(ss->dev, "request TX DMA channel failed!\n"); > - return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]); > + return dev_err_probe(ss->dev, PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]), > + "request TX DMA channel failed!\n"); > } > > return 0; > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Chunyan Zhang <zhang.lyra@gmail.com> To: Krzysztof Kozlowski <krzk@kernel.org> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>, Bjorn Andersson <bjorn.andersson@linaro.org>, Thierry Reding <thierry.reding@gmail.com>, Masahisa Kojima <masahisa.kojima@linaro.org>, linux-stm32@st-md-mailman.stormreply.com, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, Jonathan Hunter <jonathanh@nvidia.com>, Ludovic Desroches <ludovic.desroches@microchip.com>, Andy Gross <agross@kernel.org>, bcm-kernel-feedback-list@broadcom.com, linux-arm-msm@vger.kernel.org, Orson Zhai <orsonzhai@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, Tudor Ambarus <tudor.ambarus@microchip.com>, Ray Jui <rjui@broadcom.com>, Jassi Brar <jaswinder.singh@linaro.org>, Mark Brown <broonie@kernel.org>, linux-rpi-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, Linux ARM <linux-arm-kernel@lists.infradead.org>, Scott Branden <sbranden@broadcom.com>, linux-spi@vger.kernel.org, Laxman Dewangan <ldewangan@nvidia.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Baolin Wang <baolin.wang7@gmail.com>, Nicolas Saenz Julienne <nsaenzjulienne@suse.de> Subject: Re: [PATCH 02/11] spi: sprd: Simplify with dev_err_probe() Date: Tue, 8 Sep 2020 15:27:29 +0800 [thread overview] Message-ID: <CAAfSe-v4o-9zQZOSgQfAU-C4ruJU7BJdHRe4ikghx7AFgh1qgg@mail.gmail.com> (raw) In-Reply-To: <20200901152713.18629-2-krzk@kernel.org> On Tue, 1 Sep 2020 at 23:27, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> Acked-by: Chunyan Zhang <zhang.lyra@gmail.com> Thanks, Chunyan > --- > drivers/spi/spi-sprd-adi.c | 5 +---- > drivers/spi/spi-sprd.c | 17 +++++------------ > 2 files changed, 6 insertions(+), 16 deletions(-) > > diff --git a/drivers/spi/spi-sprd-adi.c b/drivers/spi/spi-sprd-adi.c > index 127b8bd25831..392ec5cfa3d6 100644 > --- a/drivers/spi/spi-sprd-adi.c > +++ b/drivers/spi/spi-sprd-adi.c > @@ -504,10 +504,7 @@ static int sprd_adi_probe(struct platform_device *pdev) > dev_info(&pdev->dev, "no hardware spinlock supplied\n"); > break; > default: > - dev_err(&pdev->dev, > - "failed to find hwlock id, %d\n", ret); > - fallthrough; > - case -EPROBE_DEFER: > + dev_err_probe(&pdev->dev, ret, "failed to find hwlock id\n"); > goto put_ctlr; > } > } > diff --git a/drivers/spi/spi-sprd.c b/drivers/spi/spi-sprd.c > index 0443fec3a6ab..635738f54c73 100644 > --- a/drivers/spi/spi-sprd.c > +++ b/drivers/spi/spi-sprd.c > @@ -553,22 +553,15 @@ static int sprd_spi_dma_tx_config(struct sprd_spi *ss, struct spi_transfer *t) > static int sprd_spi_dma_request(struct sprd_spi *ss) > { > ss->dma.dma_chan[SPRD_SPI_RX] = dma_request_chan(ss->dev, "rx_chn"); > - if (IS_ERR_OR_NULL(ss->dma.dma_chan[SPRD_SPI_RX])) { > - if (PTR_ERR(ss->dma.dma_chan[SPRD_SPI_RX]) == -EPROBE_DEFER) > - return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_RX]); > - > - dev_err(ss->dev, "request RX DMA channel failed!\n"); > - return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_RX]); > - } > + if (IS_ERR_OR_NULL(ss->dma.dma_chan[SPRD_SPI_RX])) > + return dev_err_probe(ss->dev, PTR_ERR(ss->dma.dma_chan[SPRD_SPI_RX]), > + "request RX DMA channel failed!\n"); > > ss->dma.dma_chan[SPRD_SPI_TX] = dma_request_chan(ss->dev, "tx_chn"); > if (IS_ERR_OR_NULL(ss->dma.dma_chan[SPRD_SPI_TX])) { > dma_release_channel(ss->dma.dma_chan[SPRD_SPI_RX]); > - if (PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]) == -EPROBE_DEFER) > - return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]); > - > - dev_err(ss->dev, "request TX DMA channel failed!\n"); > - return PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]); > + return dev_err_probe(ss->dev, PTR_ERR(ss->dma.dma_chan[SPRD_SPI_TX]), > + "request TX DMA channel failed!\n"); > } > > return 0; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-09-08 7:28 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-01 15:27 [PATCH 01/11] spi: sprd: Release DMA channel also on probe deferral Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-01 15:27 ` [PATCH 02/11] spi: sprd: Simplify with dev_err_probe() Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-08 7:27 ` Chunyan Zhang [this message] 2020-09-08 7:27 ` Chunyan Zhang 2020-09-08 13:22 ` Mark Brown 2020-09-08 13:22 ` Mark Brown 2020-09-01 15:27 ` [PATCH 03/11] spi: atmel: " Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-01 19:12 ` Alexandre Belloni 2020-09-01 19:12 ` Alexandre Belloni 2020-09-01 15:27 ` [PATCH 04/11] spi: bcm2835: " Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-01 16:08 ` Florian Fainelli 2020-09-01 16:08 ` Florian Fainelli 2020-09-01 15:27 ` [PATCH 05/11] spi: cadence-quadspi: " Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-01 15:27 ` [PATCH 06/11] spi: spi-mux: " Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-01 15:27 ` [PATCH 07/11] spi: qcom-qspi: " Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-01 15:27 ` [PATCH 08/11] spi: stm32: " Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-08 13:53 ` Alain Volmat 2020-09-08 13:53 ` Alain Volmat 2020-09-01 15:27 ` [PATCH 09/11] spi: synquacer: " Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-01 15:27 ` [PATCH 10/11] spi: tegra114: " Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-01 15:27 ` [PATCH 11/11] spi: tegra20: " Krzysztof Kozlowski 2020-09-01 15:27 ` Krzysztof Kozlowski 2020-09-08 7:27 ` [PATCH 01/11] spi: sprd: Release DMA channel also on probe deferral Chunyan Zhang 2020-09-08 7:27 ` Chunyan Zhang 2020-09-08 17:21 ` Mark Brown 2020-09-08 17:21 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAAfSe-v4o-9zQZOSgQfAU-C4ruJU7BJdHRe4ikghx7AFgh1qgg@mail.gmail.com \ --to=zhang.lyra@gmail.com \ --cc=agross@kernel.org \ --cc=alexandre.belloni@bootlin.com \ --cc=alexandre.torgue@st.com \ --cc=baolin.wang7@gmail.com \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=f.fainelli@gmail.com \ --cc=jaswinder.singh@linaro.org \ --cc=jonathanh@nvidia.com \ --cc=krzk@kernel.org \ --cc=ldewangan@nvidia.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux-spi@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=linux-tegra@vger.kernel.org \ --cc=ludovic.desroches@microchip.com \ --cc=masahisa.kojima@linaro.org \ --cc=mcoquelin.stm32@gmail.com \ --cc=nicolas.ferre@microchip.com \ --cc=nsaenzjulienne@suse.de \ --cc=orsonzhai@gmail.com \ --cc=rjui@broadcom.com \ --cc=sbranden@broadcom.com \ --cc=thierry.reding@gmail.com \ --cc=tudor.ambarus@microchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.