Re: [PATCH v6 7/8] dt-bindings: Add common bindings for ARM and RISC-V idle states

From: Anup Patel <anup@brainfault.org>
To: Rob Herring <robh@kernel.org>
Cc: Anup Patel <anup.patel@wdc.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	"Rafael J . Wysocki" <rjw@rjwysocki.net>,
	linux-riscv <linux-riscv@lists.infradead.org>,
	Sandeep Tripathy <milun.tripathy@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Atish Patra <atish.patra@wdc.com>,
	"open list:THERMAL" <linux-pm@vger.kernel.org>,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	Alistair Francis <Alistair.Francis@wdc.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org List"
	<linux-kernel@vger.kernel.org>,
	Daniel Lezcano <daniel.lezcano@linaro.org>,
	DTML <devicetree@vger.kernel.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Rob Herring <robh+dt@kernel.org>, Liush <liush@allwinnertech.com>,
	Pavel Machek <pavel@ucw.cz>
Subject: Re: [PATCH v6 7/8] dt-bindings: Add common bindings for ARM and RISC-V idle states
Date: Thu, 10 Jun 2021 09:54:18 +0530	[thread overview]
Message-ID: <CAAhSdy2yqqdCJCaUkX8Ld8yUQcuGQx6c-TAVaNNVehgNHsjwzQ@mail.gmail.com> (raw)
In-Reply-To: <1623255403.618479.3763295.nullmailer@robh.at.kernel.org>

On Wed, Jun 9, 2021 at 9:46 PM Rob Herring <robh@kernel.org> wrote:
>
> On Wed, 09 Jun 2021 17:57:14 +0530, Anup Patel wrote:
> > The RISC-V CPU idle states will be described in under the
> > /cpus/idle-states DT node in the same way as ARM CPU idle
> > states.
> >
> > This patch adds common bindings documentation for both ARM
> > and RISC-V idle states.
> >
> > Signed-off-by: Anup Patel <anup.patel@wdc.com>
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > ---
> >  .../bindings/{arm => cpu}/idle-states.yaml    | 228 ++++++++++++++++--
> >  .../devicetree/bindings/riscv/cpus.yaml       |   6 +
> >  2 files changed, 217 insertions(+), 17 deletions(-)
> >  rename Documentation/devicetree/bindings/{arm => cpu}/idle-states.yaml (74%)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
>
> \ndoc reference errors (make refcheckdocs):
> Warning: Documentation/devicetree/bindings/arm/msm/qcom,idle-state.txt references a file that doesn't exist: Documentation/devicetree/bindings/arm/idle-states.yaml
> Warning: Documentation/devicetree/bindings/arm/psci.yaml references a file that doesn't exist: Documentation/devicetree/bindings/arm/idle-states.yaml
> Documentation/devicetree/bindings/arm/msm/qcom,idle-state.txt: Documentation/devicetree/bindings/arm/idle-states.yaml
> Documentation/devicetree/bindings/arm/psci.yaml: Documentation/devicetree/bindings/arm/idle-states.yaml
>
> See https://patchwork.ozlabs.org/patch/1489849
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>

Sure, I will quickly fix this one and send a v7 revision

Regards,
Anup