From: Vaibhav Agarwal <vaibhav.sr@gmail.com>
To: Wang Hai <wanghai38@huawei.com>
Cc: Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Dan Carpenter <dan.carpenter@oracle.com>,
aibhav.sr@gmail.com,
"moderated list:GREYBUS SUBSYSTEM" <greybus-dev@lists.linaro.org>,
devel@driverdev.osuosl.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls
Date: Sat, 5 Dec 2020 20:16:53 +0530 [thread overview]
Message-ID: <CAAs3648wsmiJw43BAfigLHC_Sr=9Coubk9b=na0dVNTtNwFqXA@mail.gmail.com> (raw)
In-Reply-To: <20201205103827.31244-1-wanghai38@huawei.com>
On Sat, Dec 5, 2020 at 4:02 PM Wang Hai <wanghai38@huawei.com> wrote:
>
> In gbaudio_dapm_free_controls(), if one of the widgets is not found, an error
> will be returned directly, which will cause the rest to be unable to be freed,
> resulting in leak.
>
> This patch fixes the bug. If if one of them is not found, just skip and free the others.
>
nit, typo error "If if one".
> Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic audio module")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
--
thanks,
vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Agarwal <vaibhav.sr@gmail.com>
To: Wang Hai <wanghai38@huawei.com>
Cc: devel@driverdev.osuosl.org, Alex Elder <elder@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johan Hovold <johan@kernel.org>,
aibhav.sr@gmail.com, open list <linux-kernel@vger.kernel.org>,
"moderated list:GREYBUS SUBSYSTEM" <greybus-dev@lists.linaro.org>,
Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH] staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls
Date: Sat, 5 Dec 2020 20:16:53 +0530 [thread overview]
Message-ID: <CAAs3648wsmiJw43BAfigLHC_Sr=9Coubk9b=na0dVNTtNwFqXA@mail.gmail.com> (raw)
In-Reply-To: <20201205103827.31244-1-wanghai38@huawei.com>
On Sat, Dec 5, 2020 at 4:02 PM Wang Hai <wanghai38@huawei.com> wrote:
>
> In gbaudio_dapm_free_controls(), if one of the widgets is not found, an error
> will be returned directly, which will cause the rest to be unable to be freed,
> resulting in leak.
>
> This patch fixes the bug. If if one of them is not found, just skip and free the others.
>
nit, typo error "If if one".
> Fixes: 510e340efe0c ("staging: greybus: audio: Add helper APIs for dynamic audio module")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
> ---
Reviewed-by: Vaibhav Agarwal <vaibhav.sr@gmail.com>
--
thanks,
vaibhav
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-12-05 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-05 10:38 [PATCH] staging: greybus: audio: Fix possible leak free widgets in gbaudio_dapm_free_controls Wang Hai
2020-12-05 10:38 ` Wang Hai
2020-12-05 14:46 ` Vaibhav Agarwal [this message]
2020-12-05 14:46 ` Vaibhav Agarwal
2020-12-08 9:35 ` Johan Hovold
2020-12-08 9:35 ` Johan Hovold
[not found] ` <ed57715b-c524-4726-3eaf-434af96d2d92@huawei.com>
2020-12-14 9:48 ` Johan Hovold
2020-12-14 9:48 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAs3648wsmiJw43BAfigLHC_Sr=9Coubk9b=na0dVNTtNwFqXA@mail.gmail.com' \
--to=vaibhav.sr@gmail.com \
--cc=aibhav.sr@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanghai38@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.