From: chetan loke <loke.chetan@gmail.com>
To: phil.sutter@viprinet.com, linux-arm-kernel@lists.infradead.org
Cc: netdev@vger.kernel.org, linux@arm.linux.org.uk, davem@davemloft.net
Subject: Re: FW: [PATCH] af_packet: flush complete kernel cache in packet_sendmsg
Date: Fri, 2 Sep 2011 10:00:16 -0400 [thread overview]
Message-ID: <CAAsGZS6Tt9FLXfanH1+DgKt_9gR_YPJ8kX_pryhnzWTQVkNkNw@mail.gmail.com> (raw)
In-Reply-To: <D3F292ADF945FB49B35E96C94C2061B90A239361@nsmail.netscout.com>
>
> This flushes the cache before and after accessing the mmapped packet
> buffer. It seems like the call to flush_dcache_page from inside
> __packet_get_status is not enough on Kirkwood (or ARM in general).
> + kw_extra_cache_flush();
> + rc = po->tx_ring.pg_vec ? tpacket_snd(po, msg) :
> + packet_snd(sock, msg, len);
> + kw_extra_cache_flush();
> + return rc;
> }
If a workaround is needed for mmap, then why not change tpacket_snd?
Also, is this workaround actually working for all the cases? Because
packet_get_status is not being touched in your patch.
Also, I don't see any changes for the Rx-path. Is that working ok?
Chetan Loke
WARNING: multiple messages have this Message-ID (diff)
From: loke.chetan@gmail.com (chetan loke)
To: linux-arm-kernel@lists.infradead.org
Subject: FW: [PATCH] af_packet: flush complete kernel cache in packet_sendmsg
Date: Fri, 2 Sep 2011 10:00:16 -0400 [thread overview]
Message-ID: <CAAsGZS6Tt9FLXfanH1+DgKt_9gR_YPJ8kX_pryhnzWTQVkNkNw@mail.gmail.com> (raw)
In-Reply-To: <D3F292ADF945FB49B35E96C94C2061B90A239361@nsmail.netscout.com>
>
> This flushes the cache before and after accessing the mmapped packet
> buffer. It seems like the call to flush_dcache_page from inside
> __packet_get_status is not enough on Kirkwood (or ARM in general).
> + ? ? ? kw_extra_cache_flush();
> + ? ? ? rc = po->tx_ring.pg_vec ? tpacket_snd(po, msg) :
> + ? ? ? ? ? ? ? ? ? ? ? packet_snd(sock, msg, len);
> + ? ? ? kw_extra_cache_flush();
> + ? ? ? return rc;
> ?}
If a workaround is needed for mmap, then why not change tpacket_snd?
Also, is this workaround actually working for all the cases? Because
packet_get_status is not being touched in your patch.
Also, I don't see any changes for the Rx-path. Is that working ok?
Chetan Loke
next prev parent reply other threads:[~2011-09-02 14:00 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 13:06 ARM, AF_PACKET: caching problems on Marvell Kirkwood Phil Sutter
2011-04-08 13:06 ` Phil Sutter
2011-05-05 14:11 ` Phil Sutter
2011-05-05 14:11 ` Phil Sutter
2011-05-05 14:56 ` Eric Dumazet
2011-05-05 14:56 ` Eric Dumazet
2011-05-06 16:12 ` Phil Sutter
2011-05-06 16:12 ` Phil Sutter
2011-05-05 19:46 ` Andrew Lunn
2011-05-05 19:46 ` Andrew Lunn
2011-05-06 16:17 ` Phil Sutter
2011-05-06 16:17 ` Phil Sutter
2011-05-09 8:59 ` Phil Sutter
2011-05-09 8:59 ` Phil Sutter
2011-05-25 10:32 ` Phil Sutter
2011-05-25 10:32 ` Phil Sutter
2011-09-02 11:08 ` [PATCH] af_packet: flush complete kernel cache in packet_sendmsg Phil Sutter
2011-09-02 11:08 ` Phil Sutter
2011-09-02 13:46 ` Ben Hutchings
2011-09-02 13:46 ` Ben Hutchings
2011-09-02 13:59 ` Phil Sutter
2011-09-02 13:59 ` Phil Sutter
2011-09-02 17:28 ` Russell King - ARM Linux
2011-09-02 17:28 ` Russell King - ARM Linux
2011-09-05 19:57 ` Phil Sutter
2011-09-05 19:57 ` Phil Sutter
2011-09-06 9:57 ` Russell King - ARM Linux
2011-09-06 9:57 ` Russell King - ARM Linux
2011-09-06 11:05 ` Phil Sutter
2011-09-06 11:05 ` Phil Sutter
[not found] ` <D3F292ADF945FB49B35E96C94C2061B90A239361@nsmail.netscout.com>
2011-09-02 14:00 ` chetan loke [this message]
2011-09-02 14:00 ` FW: " chetan loke
2011-09-02 15:31 ` Phil Sutter
2011-09-02 15:31 ` Phil Sutter
2011-09-02 16:49 ` chetan loke
2011-09-02 16:49 ` chetan loke
2011-09-06 9:44 ` Phil Sutter
2011-09-06 9:44 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAsGZS6Tt9FLXfanH1+DgKt_9gR_YPJ8kX_pryhnzWTQVkNkNw@mail.gmail.com \
--to=loke.chetan@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=phil.sutter@viprinet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.