Re: [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv'

From: Moritz Fischer <moritz.fischer@ettus.com>
To: Wu Hao <hao.wu@intel.com>
Cc: YueHaibing <yuehaibing@huawei.com>, Alan Tull <atull@kernel.org>,
	linux-fpga@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] fpga: dfl: fme: remove set but not used variable 'priv'
Date: Fri, 14 Sep 2018 16:18:12 +0000	[thread overview]
Message-ID: <CAAtXAHeWQ-QsD833ugV6Uqk=FOn8mxvg25FY4tyBJVe0bAf38g@mail.gmail.com> (raw)
In-Reply-To: <20180914102321.GA21810@hao-dev>

Hi,

On Fri, Sep 14, 2018 at 3:23 AM, Wu Hao <hao.wu@intel.com> wrote:
> On Fri, Sep 14, 2018 at 01:33:36AM +0000, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/fpga/dfl-fme-pr.c: In function 'pr_mgmt_uinit':
>> drivers/fpga/dfl-fme-pr.c:447:18: warning:
>>  variable 'priv' set but not used [-Wunused-but-set-variable]
>
> Looks good to me, thanks for this fixing.

Hao, is this an Acked-by? :)
>
> Thanks
> Hao
>
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Moritz Fischer <mdf@kernel.org>
>> ---
>>  drivers/fpga/dfl-fme-pr.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
>> index 0b84053..fe5a557 100644
>> --- a/drivers/fpga/dfl-fme-pr.c
>> +++ b/drivers/fpga/dfl-fme-pr.c
>> @@ -444,10 +444,8 @@ static void pr_mgmt_uinit(struct platform_device *pdev,
>>                         struct dfl_feature *feature)
>>  {
>>       struct dfl_feature_platform_data *pdata = dev_get_platdata(&pdev->dev);
>> -     struct dfl_fme *priv;
>>
>>       mutex_lock(&pdata->lock);
>> -     priv = dfl_fpga_pdata_get_private(pdata);
>>
>>       dfl_fme_destroy_regions(pdata);
>>       dfl_fme_destroy_bridges(pdata);

Thanks for the patch,

Moritz