All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Tomer <amittomer25@gmail.com>
To: "André Przywara" <andre.przywara@arm.com>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Andreas Färber" <afaerber@suse.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	cristian.ciocaltea@gmail.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-actions@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 10/10] arm64: dts: actions: Add uSD support for Cubieboard7
Date: Mon, 13 Jul 2020 14:33:54 +0530	[thread overview]
Message-ID: <CABHD4K-4c8DvaW1zt4TsCRHU5YNaWKEgXdT-DK59MT9CgjB87Q@mail.gmail.com> (raw)
In-Reply-To: <5e2eb92e-eada-9b14-3f15-38717284bc92@arm.com>

Hi,

> But this regulator is only used for the eMMC there, which we apparently
> don't have on the Cubieboard 7?

We do have eMMC present on Cubieboard 7 (both the versions of Cubieboard7), and
the regulator name is similar to what is used in
"s900-bubblegum-96.dts" .i.e. "vcc_3v1".

But Since this patch doesn't enable eMMC, it does make sense to remove this
"vcc_3v1" regulator and keep the other one.

> > Also, another day tested it without having these regulators in , and
> > still it seems to
> > work.  So should these be removed ?
>
> If there are not even referenced in the .dts, then fixed regulators are
> rather pointless. So yes, please remove this vcc-3v1 one.

Sure, I would do this.

> What is the story with the other regulator? Is there a PMIC or a power
> switch for the SD card? Or is the power supply actually hardwired?

SD_VCC is connected to SWITCH/LDO which gets input from ATM2603C PMIC.
This seems to be enabled by default ( in early bootloaders I guess).

Thanks
-Amit.

WARNING: multiple messages have this Message-ID (diff)
From: Amit Tomer <amittomer25@gmail.com>
To: "André Przywara" <andre.przywara@arm.com>
Cc: devicetree@vger.kernel.org, linux-actions@lists.infradead.org,
	linux-kernel@vger.kernel.org, cristian.ciocaltea@gmail.com,
	"Rob Herring" <robh+dt@kernel.org>,
	"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
	"Andreas Färber" <afaerber@suse.de>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 10/10] arm64: dts: actions: Add uSD support for Cubieboard7
Date: Mon, 13 Jul 2020 14:33:54 +0530	[thread overview]
Message-ID: <CABHD4K-4c8DvaW1zt4TsCRHU5YNaWKEgXdT-DK59MT9CgjB87Q@mail.gmail.com> (raw)
In-Reply-To: <5e2eb92e-eada-9b14-3f15-38717284bc92@arm.com>

Hi,

> But this regulator is only used for the eMMC there, which we apparently
> don't have on the Cubieboard 7?

We do have eMMC present on Cubieboard 7 (both the versions of Cubieboard7), and
the regulator name is similar to what is used in
"s900-bubblegum-96.dts" .i.e. "vcc_3v1".

But Since this patch doesn't enable eMMC, it does make sense to remove this
"vcc_3v1" regulator and keep the other one.

> > Also, another day tested it without having these regulators in , and
> > still it seems to
> > work.  So should these be removed ?
>
> If there are not even referenced in the .dts, then fixed regulators are
> rather pointless. So yes, please remove this vcc-3v1 one.

Sure, I would do this.

> What is the story with the other regulator? Is there a PMIC or a power
> switch for the SD card? Or is the power supply actually hardwired?

SD_VCC is connected to SWITCH/LDO which gets input from ATM2603C PMIC.
This seems to be enabled by default ( in early bootloaders I guess).

Thanks
-Amit.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-13  9:04 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-02 14:52 [PATCH v5 00/10] Add MMC and DMA support for Actions S700 Amit Singh Tomar
2020-07-02 14:52 ` Amit Singh Tomar
2020-07-02 14:52 ` [PATCH v5 01/10] dt-bindings: dmaengine: convert Actions Semi Owl SoCs bindings to yaml Amit Singh Tomar
2020-07-02 14:52   ` Amit Singh Tomar
2020-07-02 21:00   ` Rob Herring
2020-07-02 21:00     ` Rob Herring
2020-07-03  7:18     ` Amit Tomer
2020-07-03  7:18       ` Amit Tomer
2020-07-03  7:54       ` Amit Tomer
2020-07-03  7:54         ` Amit Tomer
2020-07-07 14:31         ` Rob Herring
2020-07-07 14:31           ` Rob Herring
2020-07-02 14:52 ` [PATCH v5 02/10] dmaengine: Actions: get rid of bit fields from dma descriptor Amit Singh Tomar
2020-07-02 14:52   ` Amit Singh Tomar
2020-07-12 17:11   ` Manivannan Sadhasivam
2020-07-12 17:11     ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 03/10] dmaengine: Actions: Add support for S700 DMA engine Amit Singh Tomar
2020-07-02 14:52   ` Amit Singh Tomar
2020-07-02 22:07   ` kernel test robot
2020-07-02 22:07     ` kernel test robot
2020-07-02 22:07     ` kernel test robot
2020-07-02 14:52 ` [PATCH v5 04/10] clk: actions: Add MMC clock-register reset bits Amit Singh Tomar
2020-07-02 14:52   ` Amit Singh Tomar
2020-07-12 17:20   ` Manivannan Sadhasivam
2020-07-12 17:20     ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 05/10] arm64: dts: actions: limit address range for pinctrl node Amit Singh Tomar
2020-07-02 14:52   ` Amit Singh Tomar
2020-07-12 17:23   ` Manivannan Sadhasivam
2020-07-12 17:23     ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 06/10] arm64: dts: actions: Add DMA Controller for S700 Amit Singh Tomar
2020-07-02 14:52   ` Amit Singh Tomar
2020-07-12 17:24   ` Manivannan Sadhasivam
2020-07-12 17:24     ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 07/10] dt-bindings: reset: s700: Add binding constants for mmc Amit Singh Tomar
2020-07-02 14:52   ` Amit Singh Tomar
2020-07-12 17:25   ` Manivannan Sadhasivam
2020-07-12 17:25     ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 08/10] dt-bindings: mmc: owl: add compatible string actions,s700-mmc Amit Singh Tomar
2020-07-02 14:52   ` [PATCH v5 08/10] dt-bindings: mmc: owl: add compatible string actions, s700-mmc Amit Singh Tomar
2020-07-12 17:26   ` [PATCH v5 08/10] dt-bindings: mmc: owl: add compatible string actions,s700-mmc Manivannan Sadhasivam
2020-07-12 17:26     ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 09/10] arm64: dts: actions: Add MMC controller support for S700 Amit Singh Tomar
2020-07-02 14:52   ` Amit Singh Tomar
2020-07-12 17:28   ` Manivannan Sadhasivam
2020-07-12 17:28     ` Manivannan Sadhasivam
2020-07-02 14:52 ` [PATCH v5 10/10] arm64: dts: actions: Add uSD support for Cubieboard7 Amit Singh Tomar
2020-07-02 14:52   ` Amit Singh Tomar
2020-07-12 17:30   ` Manivannan Sadhasivam
2020-07-12 17:30     ` Manivannan Sadhasivam
2020-07-12 18:45     ` Amit Tomer
2020-07-12 18:45       ` Amit Tomer
2020-07-12 23:17       ` André Przywara
2020-07-12 23:17         ` André Przywara
2020-07-13  9:03         ` Amit Tomer [this message]
2020-07-13  9:03           ` Amit Tomer
2020-07-13  3:00       ` Manivannan Sadhasivam
2020-07-13  3:00         ` Manivannan Sadhasivam
2020-07-13  9:08         ` Amit Tomer
2020-07-13  9:08           ` Amit Tomer
2020-07-17 14:40           ` Manivannan Sadhasivam
2020-07-17 14:40             ` Manivannan Sadhasivam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABHD4K-4c8DvaW1zt4TsCRHU5YNaWKEgXdT-DK59MT9CgjB87Q@mail.gmail.com \
    --to=amittomer25@gmail.com \
    --cc=afaerber@suse.de \
    --cc=andre.przywara@arm.com \
    --cc=cristian.ciocaltea@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-actions@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.