From: Guenter Roeck <groeck@google.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
kernel@pengutronix.de
Subject: Re: [PATCH] platform/chrome: cros_ec: Make cros_ec_unregister() return void
Date: Tue, 19 Oct 2021 14:31:46 -0700 [thread overview]
Message-ID: <CABXOdTeOO=Yf37_p1c8HVigkqqRyR90RqRDaLk5qxxp3jAGgEA@mail.gmail.com> (raw)
In-Reply-To: <20211019203850.3833915-1-u.kleine-koenig@pengutronix.de>
On Tue, Oct 19, 2021 at 1:39 PM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
>
> Up to now cros_ec_unregister() returns zero unconditionally. Make it
> return void instead which makes it easier to see in the callers that
> there is no error to handle.
>
> Also the return value of i2c, platform and spi remove callbacks is
> ignored anyway.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/platform/chrome/cros_ec.c | 2 +-
> drivers/platform/chrome/cros_ec.h | 2 +-
> drivers/platform/chrome/cros_ec_i2c.c | 4 +++-
> drivers/platform/chrome/cros_ec_lpc.c | 4 +++-
> drivers/platform/chrome/cros_ec_spi.c | 4 +++-
> 5 files changed, 11 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
> index fc5aa1525d13..eeb94b3563e2 100644
> --- a/drivers/platform/chrome/cros_ec.c
> +++ b/drivers/platform/chrome/cros_ec.c
> @@ -302,7 +302,7 @@ EXPORT_SYMBOL(cros_ec_register);
> *
> * Return: 0 on success or negative error code.
> */
> -int cros_ec_unregister(struct cros_ec_device *ec_dev)
> +void cros_ec_unregister(struct cros_ec_device *ec_dev)
> {
> if (ec_dev->pd)
> platform_device_unregister(ec_dev->pd);
Isn't there a "return 0;" hiding about here which would now result in
a compile error ?
Guenter
> diff --git a/drivers/platform/chrome/cros_ec.h b/drivers/platform/chrome/cros_ec.h
> index 78363dcfdf23..bbca0096868a 100644
> --- a/drivers/platform/chrome/cros_ec.h
> +++ b/drivers/platform/chrome/cros_ec.h
> @@ -11,7 +11,7 @@
> #include <linux/interrupt.h>
>
> int cros_ec_register(struct cros_ec_device *ec_dev);
> -int cros_ec_unregister(struct cros_ec_device *ec_dev);
> +void cros_ec_unregister(struct cros_ec_device *ec_dev);
>
> int cros_ec_suspend(struct cros_ec_device *ec_dev);
> int cros_ec_resume(struct cros_ec_device *ec_dev);
> diff --git a/drivers/platform/chrome/cros_ec_i2c.c b/drivers/platform/chrome/cros_ec_i2c.c
> index 30c8938c27d5..22feb0fd4ce7 100644
> --- a/drivers/platform/chrome/cros_ec_i2c.c
> +++ b/drivers/platform/chrome/cros_ec_i2c.c
> @@ -313,7 +313,9 @@ static int cros_ec_i2c_remove(struct i2c_client *client)
> {
> struct cros_ec_device *ec_dev = i2c_get_clientdata(client);
>
> - return cros_ec_unregister(ec_dev);
> + cros_ec_unregister(ec_dev);
> +
> + return 0;
> }
>
> #ifdef CONFIG_PM_SLEEP
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> index 1f7861944044..8527a1bac765 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -439,7 +439,9 @@ static int cros_ec_lpc_remove(struct platform_device *pdev)
> acpi_remove_notify_handler(adev->handle, ACPI_ALL_NOTIFY,
> cros_ec_lpc_acpi_notify);
>
> - return cros_ec_unregister(ec_dev);
> + cros_ec_unregister(ec_dev);
> +
> + return 0;
> }
>
> static const struct acpi_device_id cros_ec_lpc_acpi_device_ids[] = {
> diff --git a/drivers/platform/chrome/cros_ec_spi.c b/drivers/platform/chrome/cros_ec_spi.c
> index 14c4046fa04d..713c58687721 100644
> --- a/drivers/platform/chrome/cros_ec_spi.c
> +++ b/drivers/platform/chrome/cros_ec_spi.c
> @@ -790,7 +790,9 @@ static int cros_ec_spi_remove(struct spi_device *spi)
> {
> struct cros_ec_device *ec_dev = spi_get_drvdata(spi);
>
> - return cros_ec_unregister(ec_dev);
> + cros_ec_unregister(ec_dev);
> +
> + return 0;
> }
>
> #ifdef CONFIG_PM_SLEEP
> --
> 2.30.2
>
next prev parent reply other threads:[~2021-10-19 21:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 20:38 [PATCH] platform/chrome: cros_ec: Make cros_ec_unregister() return void Uwe Kleine-König
2021-10-19 21:31 ` Guenter Roeck [this message]
2021-10-20 7:17 ` [PATCH v2] platform/chrome: cros_ec: Make cros_ec_unregister() return " Uwe Kleine-König
2021-10-20 12:54 ` Guenter Roeck
2022-01-04 23:19 ` Uwe Kleine-König
2021-10-20 13:28 ` [PATCH] platform/chrome: cros_ec: Make cros_ec_unregister() " kernel test robot
2021-10-20 13:28 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABXOdTeOO=Yf37_p1c8HVigkqqRyR90RqRDaLk5qxxp3jAGgEA@mail.gmail.com' \
--to=groeck@google.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.