From: kernel test robot <lkp@intel.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Benson Leung" <bleung@chromium.org>,
"Enric Balletbo i Serra" <enric.balletbo@collabora.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Guenter Roeck <groeck@chromium.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] platform/chrome: cros_ec: Make cros_ec_unregister() return void
Date: Wed, 20 Oct 2021 21:28:46 +0800 [thread overview]
Message-ID: <202110201936.Ma2OuNVu-lkp@intel.com> (raw)
In-Reply-To: <20211019203850.3833915-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 4172 bytes --]
Hi "Uwe,
I love your patch! Yet something to improve:
[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on v5.15-rc6 next-20211020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/platform-chrome-cros_ec-Make-cros_ec_unregister-return-void/20211020-044024
base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
config: arm64-randconfig-r001-20211019 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 92a0389b0425a9535a99a0ce13ba0eeda2bce7ad)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/d2c1956b7b20b3b031619b800d1a3fffe98562fa
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Uwe-Kleine-K-nig/platform-chrome-cros_ec-Make-cros_ec_unregister-return-void/20211020-044024
git checkout d2c1956b7b20b3b031619b800d1a3fffe98562fa
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/platform/chrome/cros_ec.c:311:2: error: void function 'cros_ec_unregister' should not return a value [-Wreturn-type]
return 0;
^ ~
1 error generated.
vim +/cros_ec_unregister +311 drivers/platform/chrome/cros_ec.c
4ab6174e8cdb00 drivers/mfd/cros_ec.c Simon Glass 2013-02-25 296
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 297 /**
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 298 * cros_ec_unregister() - Remove a ChromeOS EC.
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 299 * @ec_dev: Device to unregister.
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 300 *
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 301 * Call this to deregister a ChromeOS EC, then clean up any private data.
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 302 *
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 303 * Return: 0 on success or negative error code.
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 304 */
d2c1956b7b20b3 drivers/platform/chrome/cros_ec.c Uwe Kleine-König 2021-10-19 305 void cros_ec_unregister(struct cros_ec_device *ec_dev)
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 306 {
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 307 if (ec_dev->pd)
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 308 platform_device_unregister(ec_dev->pd);
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 309 platform_device_unregister(ec_dev->ec);
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 310
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 @311 return 0;
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 312 }
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 313 EXPORT_SYMBOL(cros_ec_unregister);
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 314
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 39586 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] platform/chrome: cros_ec: Make cros_ec_unregister() return void
Date: Wed, 20 Oct 2021 21:28:46 +0800 [thread overview]
Message-ID: <202110201936.Ma2OuNVu-lkp@intel.com> (raw)
In-Reply-To: <20211019203850.3833915-1-u.kleine-koenig@pengutronix.de>
[-- Attachment #1: Type: text/plain, Size: 4237 bytes --]
Hi "Uwe,
I love your patch! Yet something to improve:
[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on v5.15-rc6 next-20211020]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Uwe-Kleine-K-nig/platform-chrome-cros_ec-Make-cros_ec_unregister-return-void/20211020-044024
base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
config: arm64-randconfig-r001-20211019 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 92a0389b0425a9535a99a0ce13ba0eeda2bce7ad)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/0day-ci/linux/commit/d2c1956b7b20b3b031619b800d1a3fffe98562fa
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Uwe-Kleine-K-nig/platform-chrome-cros_ec-Make-cros_ec_unregister-return-void/20211020-044024
git checkout d2c1956b7b20b3b031619b800d1a3fffe98562fa
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 ARCH=arm64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> drivers/platform/chrome/cros_ec.c:311:2: error: void function 'cros_ec_unregister' should not return a value [-Wreturn-type]
return 0;
^ ~
1 error generated.
vim +/cros_ec_unregister +311 drivers/platform/chrome/cros_ec.c
4ab6174e8cdb00 drivers/mfd/cros_ec.c Simon Glass 2013-02-25 296
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 297 /**
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 298 * cros_ec_unregister() - Remove a ChromeOS EC.
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 299 * @ec_dev: Device to unregister.
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 300 *
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 301 * Call this to deregister a ChromeOS EC, then clean up any private data.
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 302 *
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 303 * Return: 0 on success or negative error code.
c9b465683a5542 drivers/platform/chrome/cros_ec.c Gwendal Grignou 2019-11-19 304 */
d2c1956b7b20b3 drivers/platform/chrome/cros_ec.c Uwe Kleine-König 2021-10-19 305 void cros_ec_unregister(struct cros_ec_device *ec_dev)
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 306 {
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 307 if (ec_dev->pd)
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 308 platform_device_unregister(ec_dev->pd);
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 309 platform_device_unregister(ec_dev->ec);
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 310
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 @311 return 0;
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 312 }
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 313 EXPORT_SYMBOL(cros_ec_unregister);
7aa703bb882438 drivers/mfd/cros_ec.c Enric Balletbo i Serra 2019-09-02 314
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39586 bytes --]
next prev parent reply other threads:[~2021-10-20 13:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 20:38 [PATCH] platform/chrome: cros_ec: Make cros_ec_unregister() return void Uwe Kleine-König
2021-10-19 21:31 ` Guenter Roeck
2021-10-20 7:17 ` [PATCH v2] platform/chrome: cros_ec: Make cros_ec_unregister() return " Uwe Kleine-König
2021-10-20 12:54 ` Guenter Roeck
2022-01-04 23:19 ` Uwe Kleine-König
2021-10-20 13:28 ` kernel test robot [this message]
2021-10-20 13:28 ` [PATCH] platform/chrome: cros_ec: Make cros_ec_unregister() " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110201936.Ma2OuNVu-lkp@intel.com \
--to=lkp@intel.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=kbuild-all@lists.01.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.