From: Alexander Aring <alex.aring@gmail.com>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: Stefan Schmidt <stefan@datenfreihafen.org>,
"David S. Miller" <davem@davemloft.net>,
linux-wpan - ML <linux-wpan@vger.kernel.org>,
"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
syzbot+9ec037722d2603a9f52e@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] net: mac802154: Fix general protection fault
Date: Sun, 4 Apr 2021 20:43:45 -0400 [thread overview]
Message-ID: <CAB_54W6BmSuRo5pwGEH_Xug3Fo5cBMjmMAGjd3aaWJaGZpSsHQ@mail.gmail.com> (raw)
In-Reply-To: <20210304152125.1052825-1-paskripkin@gmail.com>
Hi,
On Thu, 4 Mar 2021 at 10:25, Pavel Skripkin <paskripkin@gmail.com> wrote:
>
> syzbot found general protection fault in crypto_destroy_tfm()[1].
> It was caused by wrong clean up loop in llsec_key_alloc().
> If one of the tfm array members is in IS_ERR() range it will
> cause general protection fault in clean up function [1].
>
> Call Trace:
> crypto_free_aead include/crypto/aead.h:191 [inline] [1]
> llsec_key_alloc net/mac802154/llsec.c:156 [inline]
> mac802154_llsec_key_add+0x9e0/0xcc0 net/mac802154/llsec.c:249
> ieee802154_add_llsec_key+0x56/0x80 net/mac802154/cfg.c:338
> rdev_add_llsec_key net/ieee802154/rdev-ops.h:260 [inline]
> nl802154_add_llsec_key+0x3d3/0x560 net/ieee802154/nl802154.c:1584
> genl_family_rcv_msg_doit+0x228/0x320 net/netlink/genetlink.c:739
> genl_family_rcv_msg net/netlink/genetlink.c:783 [inline]
> genl_rcv_msg+0x328/0x580 net/netlink/genetlink.c:800
> netlink_rcv_skb+0x153/0x420 net/netlink/af_netlink.c:2502
> genl_rcv+0x24/0x40 net/netlink/genetlink.c:811
> netlink_unicast_kernel net/netlink/af_netlink.c:1312 [inline]
> netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1338
> netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1927
> sock_sendmsg_nosec net/socket.c:654 [inline]
> sock_sendmsg+0xcf/0x120 net/socket.c:674
> ____sys_sendmsg+0x6e8/0x810 net/socket.c:2350
> ___sys_sendmsg+0xf3/0x170 net/socket.c:2404
> __sys_sendmsg+0xe5/0x1b0 net/socket.c:2433
> do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46
> entry_SYSCALL_64_after_hwframe+0x44/0xae
>
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> Reported-by: syzbot+9ec037722d2603a9f52e@syzkaller.appspotmail.com
> Change-Id: I29f7ac641a039096d63d1e6070bb32cb5a3beb07
I am sorry, I don't know the tag "Change-Id", I was doing a whole grep
on Documentation/ without any luck.
Dumb question: What is the meaning of it?
- Alex
next prev parent reply other threads:[~2021-04-05 0:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 16:27 [PATCH] net: mac802154: Fix null pointer dereference Pavel Skripkin
2021-03-04 2:40 ` Alexander Aring
2021-03-04 9:23 ` Pavel Skripkin
2021-03-04 14:22 ` Alexander Aring
2021-03-04 15:21 ` [PATCH v2] net: mac802154: Fix general protection fault Pavel Skripkin
2021-03-08 8:27 ` Stefan Schmidt
2021-04-05 0:43 ` Alexander Aring [this message]
2021-04-05 5:45 ` Pavel Skripkin
2021-04-05 11:50 ` Alexander Aring
2021-04-06 20:43 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAB_54W6BmSuRo5pwGEH_Xug3Fo5cBMjmMAGjd3aaWJaGZpSsHQ@mail.gmail.com \
--to=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paskripkin@gmail.com \
--cc=stefan@datenfreihafen.org \
--cc=syzbot+9ec037722d2603a9f52e@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.