From: Jassi Brar <jassisinghbrar@gmail.com>
To: Boojin Kim <boojin.kim@samsung.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
Kukjin Kim <kgene.kim@samsung.com>,
Russell King <linux@arm.linux.org.uk>,
Vinod Koul <vinod.koul@intel.com>,
Grant Likely <grant.likely@secretlab.ca>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH 13/15] spi/s3c64xx: Merge dma control code
Date: Tue, 9 Aug 2011 00:02:37 +0530 [thread overview]
Message-ID: <CABb+yY0ZRNnkrTNWhYShBRpLFr8RB=eL6NqQHuv1aW=o2KfoSA@mail.gmail.com> (raw)
In-Reply-To: <1311744697-10264-14-git-send-email-boojin.kim@samsung.com>
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim <boojin.kim@samsung.com> wrote:
> This patch modifies to merge the dma control code.
> Original s3c64xx spi driver has each dma control code for rx and tx channel.
> This patch merges these dma control codes into one.
> With this patch, a dma setup function and callback function handle
> for both rx and tx channel.
This is nothing really to do with underlying DMAENGINE API.
And, apparently it actually bloats the driver ? 76 insertions(+), 64
deletions(-)
Yet, I am not very against the idea.
If you must do it, maybe It would have been better to move it early in
the patchset,
which would have resulted in a smaller and cleaner "spi/s3c64xx: Add
support DMA engine API"
WARNING: multiple messages have this Message-ID (diff)
From: jassisinghbrar@gmail.com (Jassi Brar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 13/15] spi/s3c64xx: Merge dma control code
Date: Tue, 9 Aug 2011 00:02:37 +0530 [thread overview]
Message-ID: <CABb+yY0ZRNnkrTNWhYShBRpLFr8RB=eL6NqQHuv1aW=o2KfoSA@mail.gmail.com> (raw)
In-Reply-To: <1311744697-10264-14-git-send-email-boojin.kim@samsung.com>
On Wed, Jul 27, 2011 at 11:01 AM, Boojin Kim <boojin.kim@samsung.com> wrote:
> This patch modifies to merge the dma control code.
> Original s3c64xx spi driver has each dma control code for rx and tx channel.
> This patch merges these dma control codes into one.
> With this patch, a dma setup function and callback function handle
> for both rx and tx channel.
This is nothing really to do with underlying DMAENGINE API.
And, apparently it actually bloats the driver ? 76 insertions(+), 64
deletions(-)
Yet, I am not very against the idea.
If you must do it, maybe It would have been better to move it early in
the patchset,
which would have resulted in a smaller and cleaner "spi/s3c64xx: Add
support DMA engine API"
next prev parent reply other threads:[~2011-08-08 18:32 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 5:31 [PATCH V5 00/15] To use DMA generic APIs for Samsung DMA Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 01/15] DMA: PL330: Add support runtime PM for PL330 DMAC Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 6:14 ` [RFC PATCH] DMA: PL330: Update PL330 DMAC to support runtime PM Chanwoo Choi
2011-07-27 6:14 ` Chanwoo Choi
2011-07-27 7:31 ` Jassi Brar
2011-07-27 7:31 ` Jassi Brar
2011-07-27 8:53 ` Russell King - ARM Linux
2011-07-27 8:53 ` Russell King - ARM Linux
2011-07-27 9:43 ` Chanwoo Choi
2011-07-27 9:43 ` Chanwoo Choi
2011-07-27 7:43 ` [PATCH 01/15] DMA: PL330: Add support runtime PM for PL330 DMAC Jassi Brar
2011-07-27 7:43 ` Jassi Brar
2011-07-27 5:31 ` [PATCH 02/15] DMA: PL330: Update PL330 DMA API driver Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 03/15] DMA: PL330: Support DMA_SLAVE_CONFIG command Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 04/15] DMA: PL330: Add DMA_CYCLIC capability Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 05/15] ARM: SAMSUNG: Update to use PL330-DMA driver Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 06/15] ARM: SAMSUNG: Add common DMA operations Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 07/15] ARM: EXYNOS4: Use generic DMA PL330 driver Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-08-15 9:36 ` Thomas Abraham
2011-08-15 9:36 ` Thomas Abraham
2011-08-15 14:15 ` Thomas Abraham
2011-08-15 14:15 ` Thomas Abraham
2011-08-21 8:51 ` Russell King - ARM Linux
2011-08-21 8:51 ` Russell King - ARM Linux
2011-07-27 5:31 ` [PATCH 08/15] ARM: S5PV210: " Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 09/15] ARM: S5PC100: " Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 10/15] ARM: S5P64X0: " Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 11/15] ARM: SAMSUNG: Remove S3C-PL330-DMA driver Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 12/15] spi/s3c64xx: Add support DMA engine API Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-08-08 17:47 ` Jassi Brar
2011-08-08 17:47 ` Jassi Brar
2011-08-08 17:55 ` Heiko Stübner
2011-08-08 17:55 ` Heiko Stübner
2011-08-08 18:16 ` Jassi Brar
2011-08-08 18:16 ` Jassi Brar
2011-08-08 18:26 ` Heiko Stübner
2011-08-08 18:26 ` Heiko Stübner
2011-08-09 4:13 ` Alim Akhtar
2011-08-09 4:13 ` Alim Akhtar
2011-08-19 10:30 ` Alim Akhtar
2011-08-19 10:30 ` Alim Akhtar
2011-08-21 8:46 ` Russell King - ARM Linux
2011-08-21 8:46 ` Russell King - ARM Linux
2011-08-25 1:13 ` Alim Akhtar
2011-08-25 1:13 ` Alim Akhtar
2011-08-11 7:42 ` Boojin Kim
2011-08-11 7:42 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 13/15] spi/s3c64xx: Merge dma control code Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-08-08 18:32 ` Jassi Brar [this message]
2011-08-08 18:32 ` Jassi Brar
2011-07-27 5:31 ` [PATCH 14/15] ASoC: Samsung: Update DMA interface Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-08-08 19:27 ` Jassi Brar
2011-08-08 19:27 ` Jassi Brar
2011-08-11 10:04 ` Boojin Kim
2011-08-11 10:04 ` Boojin Kim
2011-07-27 5:31 ` [PATCH 15/15] ARM: SAMSUNG: Remove Samsung specific enum type for dma direction Boojin Kim
2011-07-27 5:31 ` Boojin Kim
2011-08-04 16:53 ` [PATCH V5 00/15] To use DMA generic APIs for Samsung DMA Linus Walleij
2011-08-04 16:53 ` Linus Walleij
2011-08-08 16:45 ` Koul, Vinod
2011-08-08 16:45 ` Koul, Vinod
2011-08-11 7:26 ` Kukjin Kim
2011-08-11 7:26 ` Kukjin Kim
2011-08-11 22:27 ` Koul, Vinod
2011-08-11 22:27 ` Koul, Vinod
2011-08-13 4:11 ` Kukjin Kim
2011-08-13 4:11 ` Kukjin Kim
2011-08-16 11:01 ` Koul, Vinod
2011-08-16 11:01 ` Koul, Vinod
2011-08-19 5:24 ` Kukjin Kim
2011-08-19 5:24 ` Kukjin Kim
2011-08-19 13:04 ` Koul, Vinod
2011-08-19 13:04 ` Koul, Vinod
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABb+yY0ZRNnkrTNWhYShBRpLFr8RB=eL6NqQHuv1aW=o2KfoSA@mail.gmail.com' \
--to=jassisinghbrar@gmail.com \
--cc=boojin.kim@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dan.j.williams@intel.com \
--cc=grant.likely@secretlab.ca \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.