From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Miller <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
ccaulfie@redhat.com, Helge Deller <deller@gmx.de>,
Paul Mackerras <paulus@samba.org>,
Ralf Baechle <ralf@linux-mips.org>,
Richard Henderson <rth@twiddle.net>,
cluster-devel <cluster-devel@redhat.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-alpha@vger.kernel.org,
linux-arch <linux-arch@vger.kernel.org>,
linux-mips@vger.kernel.org,
Parisc List <linux-parisc@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>
Subject: Re: [PATCH] socket: move compat timeout handling into sock.c
Date: Tue, 8 Jan 2019 13:29:09 -0800 [thread overview]
Message-ID: <CABeXuvpprn_AXF0ama9CsHyZ1yb8FuUH25MXauLzHyahxr+Vwg@mail.gmail.com> (raw)
In-Reply-To: <20190108200959.1686520-1-arnd@arndb.de>
On Tue, Jan 8, 2019 at 12:10 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> This is a cleanup to prepare for the addition of 64-bit time_t
> in O_SNDTIMEO/O_RCVTIMEO. The existing compat handler seems
> unnecessarily complex and error-prone, moving it all into the
> main setsockopt()/getsockopt() implementation requires half
> as much code and is easier to extend.
>
> 32-bit user space can now use old_timeval32 on both 32-bit
> and 64-bit machines, while 64-bit code can use
> __old_kernel_timeval.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This will make the other series so much nicer. Thank you.
Acked-by: Deepa Dinamani <deepa.kernel@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Miller <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
ccaulfie@redhat.com, Helge Deller <deller@gmx.de>,
Paul Mackerras <paulus@samba.org>,
Ralf Baechle <ralf@linux-mips.org>,
Richard Henderson <rth@twiddle.net>,
cluster-devel <cluster-devel@redhat.com>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
linux-alpha@vger.kernel.org,
linux-arch <linux-arch@vger.kernel.org>,
linux-mips@vger.kernel.org,
Parisc List <linux-parisc@vger.kernel.org>,
sparclinux <sparclinux@vger.kernel.org>
Subject: Re: [PATCH] socket: move compat timeout handling into sock.c
Date: Tue, 08 Jan 2019 21:29:09 +0000 [thread overview]
Message-ID: <CABeXuvpprn_AXF0ama9CsHyZ1yb8FuUH25MXauLzHyahxr+Vwg@mail.gmail.com> (raw)
In-Reply-To: <20190108200959.1686520-1-arnd@arndb.de>
On Tue, Jan 8, 2019 at 12:10 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> This is a cleanup to prepare for the addition of 64-bit time_t
> in O_SNDTIMEO/O_RCVTIMEO. The existing compat handler seems
> unnecessarily complex and error-prone, moving it all into the
> main setsockopt()/getsockopt() implementation requires half
> as much code and is easier to extend.
>
> 32-bit user space can now use old_timeval32 on both 32-bit
> and 64-bit machines, while 64-bit code can use
> __old_kernel_timeval.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This will make the other series so much nicer. Thank you.
Acked-by: Deepa Dinamani <deepa.kernel@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arch <linux-arch@vger.kernel.org>,
Parisc List <linux-parisc@vger.kernel.org>,
y2038 Mailman List <y2038@lists.linaro.org>,
Networking <netdev@vger.kernel.org>, Helge Deller <deller@gmx.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@vger.kernel.org,
cluster-devel <cluster-devel@redhat.com>,
ccaulfie@redhat.com, Paul Mackerras <paulus@samba.org>,
linux-alpha@vger.kernel.org,
sparclinux <sparclinux@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
David Miller <davem@davemloft.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [PATCH] socket: move compat timeout handling into sock.c
Date: Tue, 8 Jan 2019 13:29:09 -0800 [thread overview]
Message-ID: <CABeXuvpprn_AXF0ama9CsHyZ1yb8FuUH25MXauLzHyahxr+Vwg@mail.gmail.com> (raw)
In-Reply-To: <20190108200959.1686520-1-arnd@arndb.de>
On Tue, Jan 8, 2019 at 12:10 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> This is a cleanup to prepare for the addition of 64-bit time_t
> in O_SNDTIMEO/O_RCVTIMEO. The existing compat handler seems
> unnecessarily complex and error-prone, moving it all into the
> main setsockopt()/getsockopt() implementation requires half
> as much code and is easier to extend.
>
> 32-bit user space can now use old_timeval32 on both 32-bit
> and 64-bit machines, while 64-bit code can use
> __old_kernel_timeval.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This will make the other series so much nicer. Thank you.
Acked-by: Deepa Dinamani <deepa.kernel@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: Deepa Dinamani <deepa.kernel@gmail.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH] socket: move compat timeout handling into sock.c
Date: Tue, 8 Jan 2019 13:29:09 -0800 [thread overview]
Message-ID: <CABeXuvpprn_AXF0ama9CsHyZ1yb8FuUH25MXauLzHyahxr+Vwg@mail.gmail.com> (raw)
In-Reply-To: <20190108200959.1686520-1-arnd@arndb.de>
On Tue, Jan 8, 2019 at 12:10 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> This is a cleanup to prepare for the addition of 64-bit time_t
> in O_SNDTIMEO/O_RCVTIMEO. The existing compat handler seems
> unnecessarily complex and error-prone, moving it all into the
> main setsockopt()/getsockopt() implementation requires half
> as much code and is easier to extend.
>
> 32-bit user space can now use old_timeval32 on both 32-bit
> and 64-bit machines, while 64-bit code can use
> __old_kernel_timeval.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
This will make the other series so much nicer. Thank you.
Acked-by: Deepa Dinamani <deepa.kernel@gmail.com>
next prev parent reply other threads:[~2019-01-08 21:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 5:22 [PATCH 0/3] net: y2038-safe socket timeout options Deepa Dinamani
2019-01-08 5:22 ` [Cluster-devel] " Deepa Dinamani
2019-01-08 5:22 ` Deepa Dinamani
2019-01-08 5:22 ` Deepa Dinamani
2019-01-08 5:22 ` [PATCH 1/3] socket: Use old_timeval types for socket timeouts Deepa Dinamani
2019-01-08 5:22 ` [PATCH 2/3] socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes Deepa Dinamani
2019-01-08 5:22 ` [Cluster-devel] " Deepa Dinamani
2019-01-08 5:22 ` Deepa Dinamani
2019-01-08 5:22 ` Deepa Dinamani
2019-01-08 20:03 ` Arnd Bergmann
2019-01-08 20:03 ` [Cluster-devel] " Arnd Bergmann
2019-01-08 20:03 ` Arnd Bergmann
2019-01-08 20:03 ` Arnd Bergmann
2019-01-08 20:09 ` [PATCH] socket: move compat timeout handling into sock.c Arnd Bergmann
2019-01-08 20:09 ` [Cluster-devel] " Arnd Bergmann
2019-01-08 20:09 ` Arnd Bergmann
2019-01-08 20:09 ` Arnd Bergmann
2019-01-08 20:09 ` Arnd Bergmann
2019-01-08 21:29 ` Deepa Dinamani [this message]
2019-01-08 21:29 ` [Cluster-devel] " Deepa Dinamani
2019-01-08 21:29 ` Deepa Dinamani
2019-01-08 21:29 ` Deepa Dinamani
2019-01-08 21:19 ` [PATCH 2/3] socket: Rename SO_RCVTIMEO/ SO_SNDTIMEO with _OLD suffixes Deepa Dinamani
2019-01-08 21:19 ` [Cluster-devel] " Deepa Dinamani
2019-01-08 21:19 ` Deepa Dinamani
2019-01-08 21:19 ` Deepa Dinamani
2019-01-08 5:22 ` [PATCH 3/3] sock: Add SO_RCVTIMEO_NEW and SO_SNDTIMEO_NEW Deepa Dinamani
2019-01-08 5:22 ` [Cluster-devel] " Deepa Dinamani
2019-01-08 5:22 ` Deepa Dinamani
2019-01-08 5:22 ` Deepa Dinamani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABeXuvpprn_AXF0ama9CsHyZ1yb8FuUH25MXauLzHyahxr+Vwg@mail.gmail.com \
--to=deepa.kernel@gmail.com \
--cc=arnd@arndb.de \
--cc=ccaulfie@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=ralf@linux-mips.org \
--cc=rth@twiddle.net \
--cc=sparclinux@vger.kernel.org \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.