From: Adrien Grassein <adrien.grassein@gmail.com> To: Adam Ford <aford173@gmail.com> Cc: Abel Vesa <abel.vesa@nxp.com>, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Sascha Hauer <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Peng Fan <peng.fan@nxp.com>, Anson Huang <Anson.Huang@nxp.com>, DTML <devicetree@vger.kernel.org>, arm-soc <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v1 0/2] Add imx8m power domain driver Date: Sat, 3 Apr 2021 00:26:17 +0200 [thread overview] Message-ID: <CABkfQAEm=AE_p3YT_Xi+E8haW5eXqPHY-Lh3L--rU8VSeD40SA@mail.gmail.com> (raw) In-Reply-To: <CAHCN7x+cb-Nz9_3aciJLWx=j603RFXgLG92WbBk0MMYwM_mx6g@mail.gmail.com> Hi, Le sam. 3 avr. 2021 à 00:10, Adam Ford <aford173@gmail.com> a écrit : > > On Fri, Apr 2, 2021 at 1:16 PM Adrien Grassein > <adrien.grassein@gmail.com> wrote: > > > > Le ven. 2 avr. 2021 à 19:58, Abel Vesa <abel.vesa@nxp.com> a écrit : > > > > > > On 21-04-02 19:48:41, Adrien Grassein wrote: > > > > Hi, > > > > > > > > Le ven. 2 avr. 2021 à 19:42, Abel Vesa <abel.vesa@nxp.com> a écrit : > > > > > > > > > > On 21-04-02 18:45:04, Adrien Grassein wrote: > > > > > > Hi, > > > > > > > > > > > > this patch et aims to add the support of the i.MX 8 Power Domain driver. > > > > > > Some devices (like usbotg2) can't work without this patch as their > > > > > > attached power domain are down. > > > > > > > > > > > > The original drivr was taken from le imx kernel and aapted to fit with > > > > > > the actual mainline (minor fixes). > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > Big NACK for the whole series. > > > > > > > > > > This approach has already been rejected upstream. > > > > > > > > So what is the correct approach? > > > > At this point otg2 node of imx8mm is not working at all (and blocks the whole > > > > boot of the kernel) > > > > > > > > > > Have a look at this thread: > > > > > > https://lkml.org/lkml/2020/4/27/706 > > > > > Understood, so I will try to update the gpc driver (at least for otg). > > Thanks for doing that. I know Lucas tried a few times to get something > going. I'm willing to adapt whatever work you do on the Mini toward > the Nano if you don't have time. > NP, the problem here is that I don't have an Nano to test. > adam > > > > > > > > > > > > Plus, you changed the original author, this work was originally done by Jacky Bai. > > > > > > > > I have not changed this, the original author is not mentioned on the > > > > original patch. > > > > > > Here is the original commit: > > > > > > https://github.com/Freescale/linux-fslc/commit/7ebcf5ccf423afe4ccd9c53ef204018b0b653ce0 > > > > > > > > > > > > > > > > > > > > > Adrien Grassein (2): > > > > > > dt-bindings: power: Add documentation for imx8m power domain driver > > > > > > soc: imx: add Power Domain driver for i.MX8M(M|N|P) > > > > > > > > > > > > .../bindings/power/fsl,imx-power-domain.yaml | 89 +++++++ > > > > > > MAINTAINERS | 10 + > > > > > > drivers/soc/imx/Kconfig | 7 + > > > > > > drivers/soc/imx/Makefile | 1 + > > > > > > drivers/soc/imx/imx8m_pm_domains.c | 233 ++++++++++++++++++ > > > > > > include/dt-bindings/power/imx8mm-power.h | 21 ++ > > > > > > include/dt-bindings/power/imx8mn-power.h | 15 ++ > > > > > > include/dt-bindings/power/imx8mp-power.h | 28 +++ > > > > > > include/soc/imx/imx_sip.h | 12 + > > > > > > 9 files changed, 416 insertions(+) > > > > > > create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml > > > > > > create mode 100644 drivers/soc/imx/imx8m_pm_domains.c > > > > > > create mode 100644 include/dt-bindings/power/imx8mm-power.h > > > > > > create mode 100644 include/dt-bindings/power/imx8mn-power.h > > > > > > create mode 100644 include/dt-bindings/power/imx8mp-power.h > > > > > > create mode 100644 include/soc/imx/imx_sip.h > > > > > > > > > > > > -- > > > > > > 2.25.1 > > > > > > > > > > > > > > Thanks, > > > > Thanks, > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Adrien Grassein <adrien.grassein@gmail.com> To: Adam Ford <aford173@gmail.com> Cc: Abel Vesa <abel.vesa@nxp.com>, Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Sascha Hauer <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Arnd Bergmann <arnd@arndb.de>, Peng Fan <peng.fan@nxp.com>, Anson Huang <Anson.Huang@nxp.com>, DTML <devicetree@vger.kernel.org>, arm-soc <linux-arm-kernel@lists.infradead.org>, linux-kernel <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v1 0/2] Add imx8m power domain driver Date: Sat, 3 Apr 2021 00:26:17 +0200 [thread overview] Message-ID: <CABkfQAEm=AE_p3YT_Xi+E8haW5eXqPHY-Lh3L--rU8VSeD40SA@mail.gmail.com> (raw) In-Reply-To: <CAHCN7x+cb-Nz9_3aciJLWx=j603RFXgLG92WbBk0MMYwM_mx6g@mail.gmail.com> Hi, Le sam. 3 avr. 2021 à 00:10, Adam Ford <aford173@gmail.com> a écrit : > > On Fri, Apr 2, 2021 at 1:16 PM Adrien Grassein > <adrien.grassein@gmail.com> wrote: > > > > Le ven. 2 avr. 2021 à 19:58, Abel Vesa <abel.vesa@nxp.com> a écrit : > > > > > > On 21-04-02 19:48:41, Adrien Grassein wrote: > > > > Hi, > > > > > > > > Le ven. 2 avr. 2021 à 19:42, Abel Vesa <abel.vesa@nxp.com> a écrit : > > > > > > > > > > On 21-04-02 18:45:04, Adrien Grassein wrote: > > > > > > Hi, > > > > > > > > > > > > this patch et aims to add the support of the i.MX 8 Power Domain driver. > > > > > > Some devices (like usbotg2) can't work without this patch as their > > > > > > attached power domain are down. > > > > > > > > > > > > The original drivr was taken from le imx kernel and aapted to fit with > > > > > > the actual mainline (minor fixes). > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > Big NACK for the whole series. > > > > > > > > > > This approach has already been rejected upstream. > > > > > > > > So what is the correct approach? > > > > At this point otg2 node of imx8mm is not working at all (and blocks the whole > > > > boot of the kernel) > > > > > > > > > > Have a look at this thread: > > > > > > https://lkml.org/lkml/2020/4/27/706 > > > > > Understood, so I will try to update the gpc driver (at least for otg). > > Thanks for doing that. I know Lucas tried a few times to get something > going. I'm willing to adapt whatever work you do on the Mini toward > the Nano if you don't have time. > NP, the problem here is that I don't have an Nano to test. > adam > > > > > > > > > > > > Plus, you changed the original author, this work was originally done by Jacky Bai. > > > > > > > > I have not changed this, the original author is not mentioned on the > > > > original patch. > > > > > > Here is the original commit: > > > > > > https://github.com/Freescale/linux-fslc/commit/7ebcf5ccf423afe4ccd9c53ef204018b0b653ce0 > > > > > > > > > > > > > > > > > > > > > Adrien Grassein (2): > > > > > > dt-bindings: power: Add documentation for imx8m power domain driver > > > > > > soc: imx: add Power Domain driver for i.MX8M(M|N|P) > > > > > > > > > > > > .../bindings/power/fsl,imx-power-domain.yaml | 89 +++++++ > > > > > > MAINTAINERS | 10 + > > > > > > drivers/soc/imx/Kconfig | 7 + > > > > > > drivers/soc/imx/Makefile | 1 + > > > > > > drivers/soc/imx/imx8m_pm_domains.c | 233 ++++++++++++++++++ > > > > > > include/dt-bindings/power/imx8mm-power.h | 21 ++ > > > > > > include/dt-bindings/power/imx8mn-power.h | 15 ++ > > > > > > include/dt-bindings/power/imx8mp-power.h | 28 +++ > > > > > > include/soc/imx/imx_sip.h | 12 + > > > > > > 9 files changed, 416 insertions(+) > > > > > > create mode 100644 Documentation/devicetree/bindings/power/fsl,imx-power-domain.yaml > > > > > > create mode 100644 drivers/soc/imx/imx8m_pm_domains.c > > > > > > create mode 100644 include/dt-bindings/power/imx8mm-power.h > > > > > > create mode 100644 include/dt-bindings/power/imx8mn-power.h > > > > > > create mode 100644 include/dt-bindings/power/imx8mp-power.h > > > > > > create mode 100644 include/soc/imx/imx_sip.h > > > > > > > > > > > > -- > > > > > > 2.25.1 > > > > > > > > > > > > > > Thanks, > > > > Thanks, > > > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel Thanks, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-02 22:26 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-02 16:45 [PATCH v1 0/2] Add imx8m power domain driver Adrien Grassein 2021-04-02 16:45 ` Adrien Grassein 2021-04-02 16:45 ` [PATCH v1 1/2] dt-bindings: power: Add documentation for " Adrien Grassein 2021-04-02 16:45 ` Adrien Grassein 2021-04-02 16:45 ` [PATCH v1 2/2] soc: imx: add Power Domain driver for i.MX8M(M|N|P) Adrien Grassein 2021-04-02 16:45 ` Adrien Grassein 2021-04-02 21:26 ` kernel test robot 2021-04-02 17:42 ` [PATCH v1 0/2] Add imx8m power domain driver Abel Vesa 2021-04-02 17:42 ` Abel Vesa 2021-04-02 17:48 ` Adrien Grassein 2021-04-02 17:48 ` Adrien Grassein 2021-04-02 17:58 ` Abel Vesa 2021-04-02 17:58 ` Abel Vesa 2021-04-02 18:11 ` Adrien Grassein 2021-04-02 18:11 ` Adrien Grassein 2021-04-02 22:09 ` Adam Ford 2021-04-02 22:09 ` Adam Ford 2021-04-02 22:26 ` Adrien Grassein [this message] 2021-04-02 22:26 ` Adrien Grassein
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CABkfQAEm=AE_p3YT_Xi+E8haW5eXqPHY-Lh3L--rU8VSeD40SA@mail.gmail.com' \ --to=adrien.grassein@gmail.com \ --cc=Anson.Huang@nxp.com \ --cc=abel.vesa@nxp.com \ --cc=aford173@gmail.com \ --cc=arnd@arndb.de \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=peng.fan@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.