From: ChiaEn Wu <peterwu.pub@gmail.com>
To: Han Jingoo <jingoohan1@gmail.com>
Cc: lee@kernel.org, Daniel Thompson <daniel.thompson@linaro.org>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Helge Deller <deller@gmx.de>, Mark Brown <broonie@kernel.org>,
mazziesaccount@gmail.com, andriy.shevchenko@linux.intel.com,
ChiaEn Wu <chiaen_wu@richtek.com>,
Alice Chen <alice_chen@richtek.com>,
ChiYuan Huang <cy_huang@richtek.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
szuni chen <szunichen@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support
Date: Wed, 21 Sep 2022 09:48:21 +0800 [thread overview]
Message-ID: <CABtFH5+PuK4vptVNmpn4h2FCxNFp3wWvhUrOxgqArx4YxCY99w@mail.gmail.com> (raw)
In-Reply-To: <CAPOBaE7rz2F-sij-LbYau6TRxFoOfmoUc=R__Z7iUrFWmZPgrg@mail.gmail.com>
On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo <jingoohan1@gmail.com> wrote:
>
> On Mon, Aug 29, 2022 ChiaEn Wu <peterwu.pub@gmail.com> wrote:
...
> > +#define MT6370_ITORCH_MIN_uA 25000
> > +#define MT6370_ITORCH_STEP_uA 12500
> > +#define MT6370_ITORCH_MAX_uA 400000
> > +#define MT6370_ITORCH_DOUBLE_MAX_uA 800000
> > +#define MT6370_ISTRB_MIN_uA 50000
> > +#define MT6370_ISTRB_STEP_uA 12500
> > +#define MT6370_ISTRB_MAX_uA 1500000
> > +#define MT6370_ISTRB_DOUBLE_MAX_uA 3000000
>
> Use upper letters as below:
>
> #define MT6370_ITORCH_MIN_UA 25000
> #define MT6370_ITORCH_STEP_UA 12500
> #define MT6370_ITORCH_MAX_UA 400000
> #define MT6370_ITORCH_DOUBLE_MAX_UA 800000
> #define MT6370_ISTRB_MIN_UA 50000
> #define MT6370_ISTRB_STEP_UA 12500
> #define MT6370_ISTRB_MAX_UA 1500000
> #define MT6370_ISTRB_DOUBLE_MAX_UA 3000000
>
>
> > +#define MT6370_STRBTO_MIN_US 64000
> > +#define MT6370_STRBTO_STEP_US 32000
> > +#define MT6370_STRBTO_MAX_US 2432000
> > +
Hi Jingoo,
This coding style is in accordance with Andy's opinion in this mail:
https://lore.kernel.org/linux-arm-kernel/CAHp75Vciq4M4kVrabNV9vTLLcd1vR=bMe8JLEdAF9MkRTpcB5g@mail.gmail.com/
And I will revise other parts in v12.
Thanks for your review!
--
Best Regards,
ChiaEn Wu
WARNING: multiple messages have this Message-ID (diff)
From: ChiaEn Wu <peterwu.pub@gmail.com>
To: Han Jingoo <jingoohan1@gmail.com>
Cc: "open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alice Chen <alice_chen@richtek.com>,
linux-iio <linux-iio@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ChiYuan Huang <cy_huang@richtek.com>, Pavel Machek <pavel@ucw.cz>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Helge Deller <deller@gmx.de>,
lee@kernel.org, Andy Shevchenko <andy.shevchenko@gmail.com>,
devicetree <devicetree@vger.kernel.org>,
mazziesaccount@gmail.com, szuni chen <szunichen@gmail.com>,
ChiaEn Wu <chiaen_wu@richtek.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
andriy.shevchenko@linux.intel.com,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux PM <linux-pm@vger.kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support
Date: Wed, 21 Sep 2022 09:48:21 +0800 [thread overview]
Message-ID: <CABtFH5+PuK4vptVNmpn4h2FCxNFp3wWvhUrOxgqArx4YxCY99w@mail.gmail.com> (raw)
In-Reply-To: <CAPOBaE7rz2F-sij-LbYau6TRxFoOfmoUc=R__Z7iUrFWmZPgrg@mail.gmail.com>
On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo <jingoohan1@gmail.com> wrote:
>
> On Mon, Aug 29, 2022 ChiaEn Wu <peterwu.pub@gmail.com> wrote:
...
> > +#define MT6370_ITORCH_MIN_uA 25000
> > +#define MT6370_ITORCH_STEP_uA 12500
> > +#define MT6370_ITORCH_MAX_uA 400000
> > +#define MT6370_ITORCH_DOUBLE_MAX_uA 800000
> > +#define MT6370_ISTRB_MIN_uA 50000
> > +#define MT6370_ISTRB_STEP_uA 12500
> > +#define MT6370_ISTRB_MAX_uA 1500000
> > +#define MT6370_ISTRB_DOUBLE_MAX_uA 3000000
>
> Use upper letters as below:
>
> #define MT6370_ITORCH_MIN_UA 25000
> #define MT6370_ITORCH_STEP_UA 12500
> #define MT6370_ITORCH_MAX_UA 400000
> #define MT6370_ITORCH_DOUBLE_MAX_UA 800000
> #define MT6370_ISTRB_MIN_UA 50000
> #define MT6370_ISTRB_STEP_UA 12500
> #define MT6370_ISTRB_MAX_UA 1500000
> #define MT6370_ISTRB_DOUBLE_MAX_UA 3000000
>
>
> > +#define MT6370_STRBTO_MIN_US 64000
> > +#define MT6370_STRBTO_STEP_US 32000
> > +#define MT6370_STRBTO_MAX_US 2432000
> > +
Hi Jingoo,
This coding style is in accordance with Andy's opinion in this mail:
https://lore.kernel.org/linux-arm-kernel/CAHp75Vciq4M4kVrabNV9vTLLcd1vR=bMe8JLEdAF9MkRTpcB5g@mail.gmail.com/
And I will revise other parts in v12.
Thanks for your review!
--
Best Regards,
ChiaEn Wu
WARNING: multiple messages have this Message-ID (diff)
From: ChiaEn Wu <peterwu.pub@gmail.com>
To: Han Jingoo <jingoohan1@gmail.com>
Cc: lee@kernel.org, Daniel Thompson <daniel.thompson@linaro.org>,
Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Helge Deller <deller@gmx.de>, Mark Brown <broonie@kernel.org>,
mazziesaccount@gmail.com, andriy.shevchenko@linux.intel.com,
ChiaEn Wu <chiaen_wu@richtek.com>,
Alice Chen <alice_chen@richtek.com>,
ChiYuan Huang <cy_huang@richtek.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
szuni chen <szunichen@gmail.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support
Date: Wed, 21 Sep 2022 09:48:21 +0800 [thread overview]
Message-ID: <CABtFH5+PuK4vptVNmpn4h2FCxNFp3wWvhUrOxgqArx4YxCY99w@mail.gmail.com> (raw)
In-Reply-To: <CAPOBaE7rz2F-sij-LbYau6TRxFoOfmoUc=R__Z7iUrFWmZPgrg@mail.gmail.com>
On Sun, Sep 18, 2022 at 3:22 AM Han Jingoo <jingoohan1@gmail.com> wrote:
>
> On Mon, Aug 29, 2022 ChiaEn Wu <peterwu.pub@gmail.com> wrote:
...
> > +#define MT6370_ITORCH_MIN_uA 25000
> > +#define MT6370_ITORCH_STEP_uA 12500
> > +#define MT6370_ITORCH_MAX_uA 400000
> > +#define MT6370_ITORCH_DOUBLE_MAX_uA 800000
> > +#define MT6370_ISTRB_MIN_uA 50000
> > +#define MT6370_ISTRB_STEP_uA 12500
> > +#define MT6370_ISTRB_MAX_uA 1500000
> > +#define MT6370_ISTRB_DOUBLE_MAX_uA 3000000
>
> Use upper letters as below:
>
> #define MT6370_ITORCH_MIN_UA 25000
> #define MT6370_ITORCH_STEP_UA 12500
> #define MT6370_ITORCH_MAX_UA 400000
> #define MT6370_ITORCH_DOUBLE_MAX_UA 800000
> #define MT6370_ISTRB_MIN_UA 50000
> #define MT6370_ISTRB_STEP_UA 12500
> #define MT6370_ISTRB_MAX_UA 1500000
> #define MT6370_ISTRB_DOUBLE_MAX_UA 3000000
>
>
> > +#define MT6370_STRBTO_MIN_US 64000
> > +#define MT6370_STRBTO_STEP_US 32000
> > +#define MT6370_STRBTO_MAX_US 2432000
> > +
Hi Jingoo,
This coding style is in accordance with Andy's opinion in this mail:
https://lore.kernel.org/linux-arm-kernel/CAHp75Vciq4M4kVrabNV9vTLLcd1vR=bMe8JLEdAF9MkRTpcB5g@mail.gmail.com/
And I will revise other parts in v12.
Thanks for your review!
--
Best Regards,
ChiaEn Wu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-21 1:49 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-30 3:40 [PATCH v9 01/10] dt-bindings: power: supply: Add MediaTek MT6370 Charger ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` [PATCH v9 02/10] dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED indicator ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` [PATCH v9 03/10] dt-bindings: leds: Add MediaTek MT6370 flashlight ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` [PATCH v9 04/10] dt-bindings: backlight: Add MediaTek MT6370 backlight ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-09-05 15:18 ` Lee Jones
2022-09-05 15:18 ` Lee Jones
2022-09-05 15:18 ` Lee Jones
2022-08-30 3:40 ` [PATCH v9 05/10] lib: add linear range index macro ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 10:22 ` Matti Vaittinen
2022-08-30 10:22 ` Matti Vaittinen
2022-08-30 10:22 ` Matti Vaittinen
2022-08-30 3:40 ` [PATCH v9 06/10] iio: adc: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` [PATCH v9 07/10] power: supply: mt6370: Add MediaTek MT6370 charger driver ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 10:34 ` Matti Vaittinen
2022-08-30 10:34 ` Matti Vaittinen
2022-08-30 10:34 ` Matti Vaittinen
2022-08-30 3:40 ` [PATCH v9 08/10] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` [PATCH v9 09/10] leds: flash: mt6370: Add MediaTek MT6370 flashlight support ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 8:49 ` AngeloGioacchino Del Regno
2022-08-30 8:49 ` AngeloGioacchino Del Regno
2022-08-30 8:49 ` AngeloGioacchino Del Regno
[not found] ` <CAPOBaE7rz2F-sij-LbYau6TRxFoOfmoUc=R__Z7iUrFWmZPgrg@mail.gmail.com>
2022-09-21 1:48 ` ChiaEn Wu [this message]
2022-09-21 1:48 ` ChiaEn Wu
2022-09-21 1:48 ` ChiaEn Wu
2022-09-21 11:47 ` Andy Shevchenko
2022-09-21 11:47 ` Andy Shevchenko
2022-09-21 11:47 ` Andy Shevchenko
2022-09-23 21:34 ` Han Jingoo
2022-09-23 21:34 ` Han Jingoo
2022-09-23 21:34 ` Han Jingoo
2022-09-23 22:02 ` Joe Perches
2022-09-23 22:02 ` Joe Perches
2022-09-23 22:02 ` Joe Perches
2022-08-30 3:40 ` [PATCH v9 10/10] video: backlight: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-08-30 3:40 ` ChiaEn Wu
2022-09-05 15:17 ` Lee Jones
2022-09-05 15:17 ` Lee Jones
2022-09-05 15:17 ` Lee Jones
2022-09-05 15:17 ` Lee Jones
2022-09-05 15:17 ` Lee Jones
2022-09-05 15:17 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABtFH5+PuK4vptVNmpn4h2FCxNFp3wWvhUrOxgqArx4YxCY99w@mail.gmail.com \
--to=peterwu.pub@gmail.com \
--cc=alice_chen@richtek.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.