From: Matthias Brugger <matthias.bgg@gmail.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>,
linux-mediatek@lists.infradead.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-serial@vger.kernel.org, Alan Cox <alan@linux.intel.com>
Subject: Re: [PATCH 2/4] tty: serial: 8250_mtk: Use devm_clk_get
Date: Mon, 4 May 2015 11:36:00 +0200 [thread overview]
Message-ID: <CABuKBe+qXf6xHkvTbBQ-FDVQAoQL-S-OiAS6dCry6e+aCyVvqQ@mail.gmail.com> (raw)
In-Reply-To: <1430117397-13517-3-git-send-email-s.hauer@pengutronix.de>
2015-04-27 8:49 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> When a struct device * is present clk_get should be used rather
> than of_clk_get. Use the devm variant of this function to be able to
> drop the clk_put in the error and remove pathes. While at it fix
> a wrong error message.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/tty/serial/8250/8250_mtk.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/4] tty: serial: 8250_mtk: Use devm_clk_get
Date: Mon, 4 May 2015 11:36:00 +0200 [thread overview]
Message-ID: <CABuKBe+qXf6xHkvTbBQ-FDVQAoQL-S-OiAS6dCry6e+aCyVvqQ@mail.gmail.com> (raw)
In-Reply-To: <1430117397-13517-3-git-send-email-s.hauer@pengutronix.de>
2015-04-27 8:49 GMT+02:00 Sascha Hauer <s.hauer@pengutronix.de>:
> When a struct device * is present clk_get should be used rather
> than of_clk_get. Use the devm variant of this function to be able to
> drop the clk_put in the error and remove pathes. While at it fix
> a wrong error message.
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
> drivers/tty/serial/8250/8250_mtk.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
next prev parent reply other threads:[~2015-05-04 9:36 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 6:49 [PATCH v2] tty: serial: 8250_mtk: Add support for second clock Sascha Hauer
2015-04-27 6:49 ` Sascha Hauer
2015-04-27 6:49 ` [PATCH 1/4] tty: serial: 8250_mtk: remove unnecessary test Sascha Hauer
2015-04-27 6:49 ` Sascha Hauer
2015-05-04 9:32 ` Matthias Brugger
2015-05-04 9:32 ` Matthias Brugger
2015-05-04 9:32 ` Matthias Brugger
2015-04-27 6:49 ` [PATCH 2/4] tty: serial: 8250_mtk: Use devm_clk_get Sascha Hauer
2015-04-27 6:49 ` Sascha Hauer
2015-05-04 9:36 ` Matthias Brugger [this message]
2015-05-04 9:36 ` Matthias Brugger
2015-05-04 9:36 ` Matthias Brugger
2015-04-27 6:49 ` [PATCH 3/4] tty: serial: 8250_mtk: use pm_runtime callbacks for enabling Sascha Hauer
2015-04-27 6:49 ` Sascha Hauer
2015-04-27 6:49 ` Sascha Hauer
2015-05-04 11:05 ` Matthias Brugger
2015-05-04 11:05 ` Matthias Brugger
2015-05-04 11:05 ` Matthias Brugger
2015-05-04 12:06 ` Sascha Hauer
2015-05-04 12:06 ` Sascha Hauer
2015-05-04 12:06 ` Sascha Hauer
2015-05-05 15:29 ` Matthias Brugger
2015-05-05 15:29 ` Matthias Brugger
2015-05-05 15:29 ` Matthias Brugger
2015-04-27 6:49 ` [PATCH 4/4] tty: serial: 8250_mtk: Add support for bus clock Sascha Hauer
2015-04-27 6:49 ` Sascha Hauer
2015-05-05 15:41 ` Matthias Brugger
2015-05-05 15:41 ` Matthias Brugger
2015-05-05 15:41 ` Matthias Brugger
2015-05-05 15:50 ` Sascha Hauer
2015-05-05 15:50 ` Sascha Hauer
2015-05-05 15:50 ` Sascha Hauer
2015-05-08 8:59 ` Matthias Brugger
2015-05-08 8:59 ` Matthias Brugger
2015-05-08 8:59 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABuKBe+qXf6xHkvTbBQ-FDVQAoQL-S-OiAS6dCry6e+aCyVvqQ@mail.gmail.com \
--to=matthias.bgg@gmail.com \
--cc=alan@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.