From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Russell King <linux@arm.linux.org.uk>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Pawel Moll <pawel.moll@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Marc Carino <marc.ceeeee@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Sascha Hauer <kernel@pengutronix.de>,
srv_heupstream <srv_heupstream@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 3/9] clocksource: mediatek: do not enable GPT_CLK_EVT when setup
Date: Wed, 20 May 2015 12:22:38 +0200 [thread overview]
Message-ID: <CABuKBeKFv7vCtz7WC8eiea1jBvUY9JFgJbYgjhy6LfTnBRTogw@mail.gmail.com> (raw)
In-Reply-To: <1431763110-443-4-git-send-email-yingjoe.chen@mediatek.com>
2015-05-16 9:58 GMT+02:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
> Spurious mtk timer interrupt is noticed at boot and cause kernel
> crash. It seems if GPT is enabled, it will latch irq status even
> when its IRQ is disabled. When irq is enabled afterward, we see
> spurious interrupt.
> Change init flow to only enable GPT_CLK_SRC at mtk_timer_init.
>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> ---
> drivers/clocksource/mtk_timer.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
> index 68ab423..91206f9 100644
> --- a/drivers/clocksource/mtk_timer.c
> +++ b/drivers/clocksource/mtk_timer.c
> @@ -157,8 +157,11 @@ static void mtk_timer_global_reset(struct mtk_clock_event_device *evt)
> }
>
> static void
> -mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option)
> +mtk_timer_setup(struct mtk_clock_event_device *evt,
> + u8 timer, u8 option, u8 enable)
Nicer would be:
static void mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer,
u8 option, u8 enable)
Apart from that parameter enable should be of type bool.
Thanks,
Matthias
--
motzblog.wordpress.com
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Thomas Gleixner <tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Daniel Lezcano
<daniel.lezcano-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Marc Carino <marc.ceeeee-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
srv_heupstream
<srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH v2 3/9] clocksource: mediatek: do not enable GPT_CLK_EVT when setup
Date: Wed, 20 May 2015 12:22:38 +0200 [thread overview]
Message-ID: <CABuKBeKFv7vCtz7WC8eiea1jBvUY9JFgJbYgjhy6LfTnBRTogw@mail.gmail.com> (raw)
In-Reply-To: <1431763110-443-4-git-send-email-yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2015-05-16 9:58 GMT+02:00 Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>:
> Spurious mtk timer interrupt is noticed at boot and cause kernel
> crash. It seems if GPT is enabled, it will latch irq status even
> when its IRQ is disabled. When irq is enabled afterward, we see
> spurious interrupt.
> Change init flow to only enable GPT_CLK_SRC at mtk_timer_init.
>
> Signed-off-by: Yingjoe Chen <yingjoe.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> ---
> drivers/clocksource/mtk_timer.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
> index 68ab423..91206f9 100644
> --- a/drivers/clocksource/mtk_timer.c
> +++ b/drivers/clocksource/mtk_timer.c
> @@ -157,8 +157,11 @@ static void mtk_timer_global_reset(struct mtk_clock_event_device *evt)
> }
>
> static void
> -mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option)
> +mtk_timer_setup(struct mtk_clock_event_device *evt,
> + u8 timer, u8 option, u8 enable)
Nicer would be:
static void mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer,
u8 option, u8 enable)
Apart from that parameter enable should be of type bool.
Thanks,
Matthias
--
motzblog.wordpress.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/9] clocksource: mediatek: do not enable GPT_CLK_EVT when setup
Date: Wed, 20 May 2015 12:22:38 +0200 [thread overview]
Message-ID: <CABuKBeKFv7vCtz7WC8eiea1jBvUY9JFgJbYgjhy6LfTnBRTogw@mail.gmail.com> (raw)
In-Reply-To: <1431763110-443-4-git-send-email-yingjoe.chen@mediatek.com>
2015-05-16 9:58 GMT+02:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
> Spurious mtk timer interrupt is noticed at boot and cause kernel
> crash. It seems if GPT is enabled, it will latch irq status even
> when its IRQ is disabled. When irq is enabled afterward, we see
> spurious interrupt.
> Change init flow to only enable GPT_CLK_SRC at mtk_timer_init.
>
> Signed-off-by: Yingjoe Chen <yingjoe.chen@mediatek.com>
> ---
> drivers/clocksource/mtk_timer.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/clocksource/mtk_timer.c b/drivers/clocksource/mtk_timer.c
> index 68ab423..91206f9 100644
> --- a/drivers/clocksource/mtk_timer.c
> +++ b/drivers/clocksource/mtk_timer.c
> @@ -157,8 +157,11 @@ static void mtk_timer_global_reset(struct mtk_clock_event_device *evt)
> }
>
> static void
> -mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer, u8 option)
> +mtk_timer_setup(struct mtk_clock_event_device *evt,
> + u8 timer, u8 option, u8 enable)
Nicer would be:
static void mtk_timer_setup(struct mtk_clock_event_device *evt, u8 timer,
u8 option, u8 enable)
Apart from that parameter enable should be of type bool.
Thanks,
Matthias
--
motzblog.wordpress.com
next prev parent reply other threads:[~2015-05-20 10:22 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 7:58 [PATCH v2 0/9] Add SMP bringup support for mt65xx socs Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 1/9] ARM: correct secondary_startup_arm mode Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 9:08 ` Matthias Brugger
2015-05-16 9:08 ` Matthias Brugger
2015-05-16 9:08 ` Matthias Brugger
2015-05-16 21:19 ` Russell King - ARM Linux
2015-05-16 21:19 ` Russell King - ARM Linux
2015-05-16 21:19 ` Russell King - ARM Linux
2015-05-16 7:58 ` [PATCH v2 2/9] ARM: add secondary_startup_arm prototype in header file Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 9:02 ` Matthias Brugger
2015-05-16 9:02 ` Matthias Brugger
2015-05-16 9:02 ` Matthias Brugger
2015-05-16 21:19 ` Russell King - ARM Linux
2015-05-16 21:19 ` Russell King - ARM Linux
2015-05-16 21:19 ` Russell King - ARM Linux
2015-05-18 8:56 ` Yingjoe Chen
2015-05-18 8:56 ` Yingjoe Chen
2015-05-18 8:56 ` Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 3/9] clocksource: mediatek: do not enable GPT_CLK_EVT when setup Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-20 10:22 ` Matthias Brugger [this message]
2015-05-20 10:22 ` Matthias Brugger
2015-05-20 10:22 ` Matthias Brugger
2015-05-16 7:58 ` [PATCH v2 4/9] clocksource: mediatek: Use GPT as sched clock source Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-20 11:02 ` Matthias Brugger
2015-05-20 11:02 ` Matthias Brugger
2015-05-20 11:02 ` Matthias Brugger
2015-05-20 14:05 ` Yingjoe Chen
2015-05-20 14:05 ` Yingjoe Chen
2015-05-20 14:05 ` Yingjoe Chen
2015-05-20 15:00 ` Matthias Brugger
2015-05-20 15:00 ` Matthias Brugger
2015-05-20 15:00 ` Matthias Brugger
2015-05-20 18:37 ` Stephen Boyd
2015-05-20 18:37 ` Stephen Boyd
2015-05-20 18:37 ` Stephen Boyd
2015-07-03 13:48 ` Daniel Kurtz
2015-07-03 13:48 ` Daniel Kurtz
2015-07-03 13:48 ` Daniel Kurtz
2015-07-03 15:51 ` Matthias Brugger
2015-07-03 15:51 ` Matthias Brugger
2015-07-03 15:51 ` Matthias Brugger
2015-07-11 10:32 ` Yingjoe Chen
2015-07-11 10:32 ` Yingjoe Chen
2015-07-11 10:32 ` Yingjoe Chen
2015-08-03 15:51 ` Daniel Lezcano
2015-08-03 15:51 ` Daniel Lezcano
2015-05-16 7:58 ` [PATCH v2 5/9] ARM: mediatek: enable gpt6 on boot up to make arch timer working Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-19 19:51 ` Stephen Boyd
2015-05-19 19:51 ` Stephen Boyd
2015-05-20 8:43 ` Matthias Brugger
2015-05-20 8:43 ` Matthias Brugger
2015-05-20 8:43 ` Matthias Brugger
2015-05-20 8:46 ` Yingjoe Chen
2015-05-20 8:46 ` Yingjoe Chen
2015-05-20 8:46 ` Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 6/9] devicetree: bindings: add new SMP enable method Mediatek SoC Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 7/9] ARM: mediatek: add smp bringup code Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 8/9] ARM: dts: mt8135: enable basic SMP bringup for mt8135 Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` [PATCH v2 9/9] ARM: dts: mt8127: enable basic SMP bringup for mt8127 Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
2015-05-16 7:58 ` Yingjoe Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABuKBeKFv7vCtz7WC8eiea1jBvUY9JFgJbYgjhy6LfTnBRTogw@mail.gmail.com \
--to=matthias.bgg@gmail.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.ceeeee@gmail.com \
--cc=mark.rutland@arm.com \
--cc=olof@lixom.net \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.