From: Akinobu Mita <akinobu.mita@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-nvme@lists.infradead.org, linux-hwmon@vger.kernel.org,
Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2 1/2] nvme: hwmon: provide temperature min and max values for each sensor
Date: Thu, 21 Nov 2019 22:48:21 +0900 [thread overview]
Message-ID: <CAC5umyh8kbQTPh22CX6uEcR1jNEHxa+5HCjGDahnZ_i1k=cEPg@mail.gmail.com> (raw)
In-Reply-To: <20191120184827.GA12322@lst.de>
2019年11月21日(木) 3:48 Christoph Hellwig <hch@lst.de>:
>
> On Fri, Nov 15, 2019 at 12:40:00AM +0900, Akinobu Mita wrote:
> > +/* These macros should be moved to linux/temperature.h */
> > +#define MILLICELSIUS_TO_KELVIN(t) DIV_ROUND_CLOSEST((t) + 273150, 1000)
> > +#define KELVIN_TO_MILLICELSIUS(t) ((t) * 1000L - 273150)
>
> Didn't we want to move this to a generic header?
Yes. I start preparing for <linux/temperature.h>.
Once the change is accepted, I'll move the macros to the header.
WARNING: multiple messages have this Message-ID (diff)
From: Akinobu Mita <akinobu.mita@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-hwmon@vger.kernel.org, Jean Delvare <jdelvare@suse.com>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, Jens Axboe <axboe@fb.com>,
Keith Busch <kbusch@kernel.org>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH v2 1/2] nvme: hwmon: provide temperature min and max values for each sensor
Date: Thu, 21 Nov 2019 22:48:21 +0900 [thread overview]
Message-ID: <CAC5umyh8kbQTPh22CX6uEcR1jNEHxa+5HCjGDahnZ_i1k=cEPg@mail.gmail.com> (raw)
In-Reply-To: <20191120184827.GA12322@lst.de>
2019年11月21日(木) 3:48 Christoph Hellwig <hch@lst.de>:
>
> On Fri, Nov 15, 2019 at 12:40:00AM +0900, Akinobu Mita wrote:
> > +/* These macros should be moved to linux/temperature.h */
> > +#define MILLICELSIUS_TO_KELVIN(t) DIV_ROUND_CLOSEST((t) + 273150, 1000)
> > +#define KELVIN_TO_MILLICELSIUS(t) ((t) * 1000L - 273150)
>
> Didn't we want to move this to a generic header?
Yes. I start preparing for <linux/temperature.h>.
Once the change is accepted, I'll move the macros to the header.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-11-21 13:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 15:39 [PATCH v2 0/2] nvme: hwmon: provide temperature threshold features Akinobu Mita
2019-11-14 15:39 ` Akinobu Mita
2019-11-14 15:40 ` [PATCH v2 1/2] nvme: hwmon: provide temperature min and max values for each sensor Akinobu Mita
2019-11-14 15:40 ` Akinobu Mita
2019-11-14 19:06 ` Guenter Roeck
2019-11-14 19:06 ` Guenter Roeck
2019-11-20 18:48 ` Christoph Hellwig
2019-11-20 18:48 ` Christoph Hellwig
2019-11-21 13:48 ` Akinobu Mita [this message]
2019-11-21 13:48 ` Akinobu Mita
2019-11-21 14:27 ` Guenter Roeck
2019-11-21 14:27 ` Guenter Roeck
2019-11-21 15:15 ` Keith Busch
2019-11-21 15:15 ` Keith Busch
2019-11-14 15:40 ` [PATCH v2 2/2] nvme: hwmon: add quirk to avoid changing temperature threshold Akinobu Mita
2019-11-14 15:40 ` Akinobu Mita
2019-11-14 19:14 ` Guenter Roeck
2019-11-14 19:14 ` Guenter Roeck
2019-11-20 18:48 ` Christoph Hellwig
2019-11-20 18:48 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAC5umyh8kbQTPh22CX6uEcR1jNEHxa+5HCjGDahnZ_i1k=cEPg@mail.gmail.com' \
--to=akinobu.mita@gmail.com \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=jdelvare@suse.com \
--cc=kbusch@kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.