From: "DebBarma, Tarun Kanti" <tarun.kanti@ti.com> To: Paul Walmsley <paul@pwsan.com> Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Kevin Hilman <khilman@ti.com>, Rajendra Nayak <rnayak@ti.com>, Santosh Shilimkar <santosh.shilimkar@ti.com>, "Cousson, Benoit" <b-cousson@ti.com>, linus.walleij@stericsson.com, grant.likely@secretlab.ca Subject: Re: [PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init() Date: Wed, 11 Jul 2012 23:26:31 +0530 [thread overview] Message-ID: <CAC83ZvK614pB0Jx56OMXfmFf89cTAP+AAf=H-imbH2Y1Qv7DSg@mail.gmail.com> (raw) In-Reply-To: <alpine.DEB.2.00.1207111148400.25585@utopia.booyaka.com> On Wed, Jul 11, 2012 at 11:21 PM, Paul Walmsley <paul@pwsan.com> wrote: > On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote: > >> Since the bank->dbck initialization in a one time operation there >> is no need to keep this within gpio_debounce(). Therefore, moving >> clk_get(bank->dbck) to omap_gpio_mod_init(). Since the value of >> bank->dbck would be NULL at the beginning, this check has been >> removed. >> >> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com> >> Reported-by: Paul Walmsley <paul@pwsan.com> >> Reviewed-by: Jon Hunter <jon-hunter@ti.com> >> Cc: Kevin Hilman <khilman@ti.com> >> Cc: Rajendra Nayak <rnayak@ti.com> >> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> >> Cc: Cousson, Benoit <b-cousson@ti.com> >> Cc: Paul Walmsley <paul@pwsan.com> >> --- >> drivers/gpio/gpio-omap.c | 10 ++++------ >> 1 files changed, 4 insertions(+), 6 deletions(-) > > Reviewed-by: Paul Walmsley <paul@pwsan.com> > > These drivers are maintained by Grant Likely and Linus Walleij: > > GPIO SUBSYSTEM > M: Grant Likely <grant.likely@secretlab.ca> > M: Linus Walleij <linus.walleij@stericsson.com> > S: Maintained > T: git git://git.secretlab.ca/git/linux-2.6.git > F: Documentation/gpio.txt > F: drivers/gpio/ > F: include/linux/gpio* > > So you'll want to cc them. They are probably also who should merge these. Ok, I wanted Kevin to have a look first. Anyways, I have cc'ed. Thanks. -- Tarun > > > - Paul
WARNING: multiple messages have this Message-ID (diff)
From: tarun.kanti@ti.com (DebBarma, Tarun Kanti) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init() Date: Wed, 11 Jul 2012 23:26:31 +0530 [thread overview] Message-ID: <CAC83ZvK614pB0Jx56OMXfmFf89cTAP+AAf=H-imbH2Y1Qv7DSg@mail.gmail.com> (raw) In-Reply-To: <alpine.DEB.2.00.1207111148400.25585@utopia.booyaka.com> On Wed, Jul 11, 2012 at 11:21 PM, Paul Walmsley <paul@pwsan.com> wrote: > On Wed, 11 Jul 2012, Tarun Kanti DebBarma wrote: > >> Since the bank->dbck initialization in a one time operation there >> is no need to keep this within gpio_debounce(). Therefore, moving >> clk_get(bank->dbck) to omap_gpio_mod_init(). Since the value of >> bank->dbck would be NULL at the beginning, this check has been >> removed. >> >> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com> >> Reported-by: Paul Walmsley <paul@pwsan.com> >> Reviewed-by: Jon Hunter <jon-hunter@ti.com> >> Cc: Kevin Hilman <khilman@ti.com> >> Cc: Rajendra Nayak <rnayak@ti.com> >> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> >> Cc: Cousson, Benoit <b-cousson@ti.com> >> Cc: Paul Walmsley <paul@pwsan.com> >> --- >> drivers/gpio/gpio-omap.c | 10 ++++------ >> 1 files changed, 4 insertions(+), 6 deletions(-) > > Reviewed-by: Paul Walmsley <paul@pwsan.com> > > These drivers are maintained by Grant Likely and Linus Walleij: > > GPIO SUBSYSTEM > M: Grant Likely <grant.likely@secretlab.ca> > M: Linus Walleij <linus.walleij@stericsson.com> > S: Maintained > T: git git://git.secretlab.ca/git/linux-2.6.git > F: Documentation/gpio.txt > F: drivers/gpio/ > F: include/linux/gpio* > > So you'll want to cc them. They are probably also who should merge these. Ok, I wanted Kevin to have a look first. Anyways, I have cc'ed. Thanks. -- Tarun > > > - Paul
next prev parent reply other threads:[~2012-07-11 17:56 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-07-11 9:13 [PATCH 0/2] gpio/omap: few code realignment and update of missing code Tarun Kanti DebBarma 2012-07-11 9:13 ` Tarun Kanti DebBarma 2012-07-11 9:13 ` Tarun Kanti DebBarma 2012-07-11 9:13 ` [PATCH 1/2] gpio/omap: move bank->dbck initialization to omap_gpio_mod_init() Tarun Kanti DebBarma 2012-07-11 9:13 ` Tarun Kanti DebBarma 2012-07-11 9:13 ` Tarun Kanti DebBarma 2012-07-11 17:51 ` Paul Walmsley 2012-07-11 17:51 ` Paul Walmsley 2012-07-11 17:56 ` DebBarma, Tarun Kanti [this message] 2012-07-11 17:56 ` DebBarma, Tarun Kanti 2012-07-11 21:51 ` Linus Walleij 2012-07-11 21:51 ` Linus Walleij 2012-07-11 9:13 ` [PATCH 2/2] gpio/omap: add *remove* callback in platform_driver Tarun Kanti DebBarma 2012-07-11 9:13 ` Tarun Kanti DebBarma 2012-07-11 9:13 ` Tarun Kanti DebBarma 2012-07-11 21:54 ` Linus Walleij 2012-07-11 21:54 ` Linus Walleij 2012-07-11 23:25 ` Kevin Hilman 2012-07-11 23:25 ` Kevin Hilman 2012-07-11 23:25 ` Kevin Hilman 2012-07-12 11:03 ` Linus Walleij 2012-07-12 11:03 ` Linus Walleij 2012-07-12 17:48 ` Kevin Hilman 2012-07-12 17:48 ` Kevin Hilman 2012-07-12 17:48 ` Kevin Hilman 2012-07-14 20:51 ` Linus Walleij 2012-07-14 20:51 ` Linus Walleij 2012-07-16 17:10 ` Kevin Hilman 2012-07-16 17:10 ` Kevin Hilman 2012-07-16 17:10 ` Kevin Hilman 2012-07-16 20:49 ` Linus Walleij 2012-07-16 20:49 ` Linus Walleij 2012-07-16 22:01 ` Kevin Hilman 2012-07-16 22:01 ` Kevin Hilman 2012-07-16 22:01 ` Kevin Hilman 2012-07-17 6:03 ` Shilimkar, Santosh 2012-07-17 6:03 ` Shilimkar, Santosh
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAC83ZvK614pB0Jx56OMXfmFf89cTAP+AAf=H-imbH2Y1Qv7DSg@mail.gmail.com' \ --to=tarun.kanti@ti.com \ --cc=b-cousson@ti.com \ --cc=grant.likely@secretlab.ca \ --cc=khilman@ti.com \ --cc=linus.walleij@stericsson.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=paul@pwsan.com \ --cc=rnayak@ti.com \ --cc=santosh.shilimkar@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.