Re: [PULL 00/50] Net patches

From: Jason Wang <jasowang@redhat.com>
To: Michael Tokarev <mjt@tls.msk.ru>
Cc: qemu-devel@nongnu.org, Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: Re: [PULL 00/50] Net patches
Date: Wed, 24 May 2023 12:06:09 +0800	[thread overview]
Message-ID: <CACGkMEssJ8=_ityBAN-T29JwTGDB+=-cbq0pfNqZtOE6-RmjCA@mail.gmail.com> (raw)
In-Reply-To: <1d43383e-e13c-0217-b1df-3572826ff87d@tls.msk.ru>

On Wed, May 24, 2023 at 3:54 AM Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> 23.05.2023 10:31, Jason Wang wrote:
>
> >    https://github.com/jasowang/qemu.git tags/net-pull-request
>
> I might be wrong but it looks like besides the rtl8139 fix which went
> to -stable already, and "e1000e: Fix tx/rx counters" change which has
> been agreed upon before, there are a few other changes which are worth
> to have in -stable, in 8.0 and some even in 7.2. What do you think,
> which ones are important for -stable?

I'm not sure, most fixes are for igb, considering igb is complicated
and just introduced since 8.0, it should be considered as a technical
preview somehow. Then I'm not sure whether or not it's worth it to
backport them. For the rest, it looks like it should be fine to go for
-stable.

Akihiko, what's your thoughts?

Thanks

>
> If there's stable material in the future, please Cc: qemu-stable@nongnu.org.
>
> Thanks,
>
> /mjt
>
> > Akihiko Odaki (48):
> >        hw/net/net_tx_pkt: Decouple implementation from PCI
> >        hw/net/net_tx_pkt: Decouple interface from PCI
> >        e1000x: Fix BPRC and MPRC
> >        igb: Fix Rx packet type encoding
> >        igb: Do not require CTRL.VME for tx VLAN tagging
> >        igb: Clear IMS bits when committing ICR access
> >        net/net_rx_pkt: Use iovec for net_rx_pkt_set_protocols()
> >        e1000e: Always copy ethernet header
> >        igb: Always copy ethernet header
> >        Fix references to igb Avocado test
> >        tests/avocado: Remove unused imports
> >        tests/avocado: Remove test_igb_nomsi_kvm
> >        hw/net/net_tx_pkt: Remove net_rx_pkt_get_l4_info
> >        net/eth: Rename eth_setup_vlan_headers_ex
> >        e1000x: Share more Rx filtering logic
> >        e1000x: Take CRC into consideration for size check
> >        e1000x: Rename TcpIpv6 into TcpIpv6Ex
> >        e1000e: Always log status after building rx metadata
> >        igb: Always log status after building rx metadata
> >        igb: Remove goto
> >        igb: Read DCMD.VLE of the first Tx descriptor
> >        e1000e: Reset packet state after emptying Tx queue
> >        vmxnet3: Reset packet state after emptying Tx queue
> >        igb: Add more definitions for Tx descriptor
> >        igb: Share common VF constants
> >        igb: Fix igb_mac_reg_init coding style alignment
> >        igb: Clear EICR bits for delayed MSI-X interrupts
> >        e1000e: Rename a variable in e1000e_receive_internal()
> >        igb: Rename a variable in igb_receive_internal()
> >        net/eth: Use void pointers
> >        net/eth: Always add VLAN tag
> >        hw/net/net_rx_pkt: Enforce alignment for eth_header
> >        tests/qtest/libqos/igb: Set GPIE.Multiple_MSIX
> >        igb: Implement MSI-X single vector mode
> >        igb: Use UDP for RSS hash
> >        igb: Implement Rx SCTP CSO
> >        igb: Implement Tx SCTP CSO
> >        igb: Strip the second VLAN tag for extended VLAN
> >        igb: Filter with the second VLAN tag for extended VLAN
> >        igb: Implement igb-specific oversize check
> >        igb: Implement Rx PTP2 timestamp
> >        igb: Implement Tx timestamp
> >        e1000e: Notify only new interrupts
> >        igb: Notify only new interrupts
> >        igb: Clear-on-read ICR when ICR.INTA is set
> >        vmxnet3: Do not depend on PC
> >        MAINTAINERS: Add a reviewer for network packet abstractions
> >        docs/system/devices/igb: Note igb is tested for DPDK
>