From: Joel Stanley <joel@jms.id.au> To: Vijay Khemka <vijaykhemka@fb.com> Cc: Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Andrew Jeffery <andrew@aj.id.au>, devicetree <devicetree@vger.kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-aspeed@lists.ozlabs.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "openbmc @ lists . ozlabs . org" <openbmc@lists.ozlabs.org> Subject: Re: [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Date: Wed, 30 Jan 2019 14:27:00 +1100 [thread overview] Message-ID: <CACPK8Xc91m9TWoRSgDCT7bVJC=C=w7mse8xbdCgw5vMVgMXM=Q@mail.gmail.com> (raw) In-Reply-To: <20190123230733.1821501-1-vijaykhemka@fb.com> On Thu, 24 Jan 2019 at 10:07, Vijay Khemka <vijaykhemka@fb.com> wrote: > index 73e58a821613..d60dbb019f82 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > > +&peci0 { > + status = "okay"; > +}; I don't think we have an upstream tree that contains a node called peci0. Therefore this does not build. I have dropped this hunk from your patch. Please make sure you test before sending patches. Cheers, Joel
WARNING: multiple messages have this Message-ID (diff)
From: Joel Stanley <joel@jms.id.au> To: Vijay Khemka <vijaykhemka@fb.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree <devicetree@vger.kernel.org>, linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>, "openbmc @ lists . ozlabs . org" <openbmc@lists.ozlabs.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Date: Wed, 30 Jan 2019 14:27:00 +1100 [thread overview] Message-ID: <CACPK8Xc91m9TWoRSgDCT7bVJC=C=w7mse8xbdCgw5vMVgMXM=Q@mail.gmail.com> (raw) In-Reply-To: <20190123230733.1821501-1-vijaykhemka@fb.com> On Thu, 24 Jan 2019 at 10:07, Vijay Khemka <vijaykhemka@fb.com> wrote: > index 73e58a821613..d60dbb019f82 100644 > --- a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > +++ b/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts > > +&peci0 { > + status = "okay"; > +}; I don't think we have an upstream tree that contains a node called peci0. Therefore this does not build. I have dropped this hunk from your patch. Please make sure you test before sending patches. Cheers, Joel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-30 3:27 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-23 23:07 [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Vijay Khemka 2019-01-23 23:07 ` Vijay Khemka 2019-01-23 23:07 ` Vijay Khemka 2019-01-23 23:07 ` [PATCH 2/2] ARM: dts: aspeed: Add uarts for SoL in Facebook Vijay Khemka 2019-01-23 23:07 ` Vijay Khemka 2019-01-23 23:07 ` Vijay Khemka 2019-01-30 3:27 ` Joel Stanley 2019-01-30 3:27 ` Joel Stanley 2019-01-30 3:27 ` Joel Stanley 2019-01-30 3:27 ` Joel Stanley [this message] 2019-01-30 3:27 ` [PATCH 1/2] ARM: dts: aspeed: Add peci and lpc for Facebook Joel Stanley 2019-01-30 3:27 ` Joel Stanley 2019-01-30 18:01 ` Vijay Khemka 2019-01-30 18:01 ` Vijay Khemka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACPK8Xc91m9TWoRSgDCT7bVJC=C=w7mse8xbdCgw5vMVgMXM=Q@mail.gmail.com' \ --to=joel@jms.id.au \ --cc=andrew@aj.id.au \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=openbmc@lists.ozlabs.org \ --cc=robh+dt@kernel.org \ --cc=vijaykhemka@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.