From: Joel Stanley <joel@jms.id.au> To: Arnd Bergmann <arnd@arndb.de> Cc: Andrew Jeffery <andrew@aj.id.au>, Patrick Venture <venture@google.com>, Vijay Khemka <vijaykhemka@fb.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, linux-aspeed@lists.ozlabs.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] soc: aspeed: fix probe error handling Date: Thu, 20 Jun 2019 08:29:36 +0000 [thread overview] Message-ID: <CACPK8Xe0Ppr8QjPSTPyNSHEbSXvuZLjC04hqP6ATTSystY888w@mail.gmail.com> (raw) In-Reply-To: <20190619125636.1109665-1-arnd@arndb.de> On Wed, 19 Jun 2019 at 12:56, Arnd Bergmann <arnd@arndb.de> wrote: > > gcc warns that a mising "flash" phandle node leads to undefined > behavior later: > > drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe': > drivers/soc/aspeed/aspeed-lpc-ctrl.c:201:18: error: '*((void *)&resm+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > The device cannot work without this node, so just error out here. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks Arnd. This looks like it applies on top of Vijay's recent patch? The intent of that change was to make the driver usable for systems that do not want to depend on the flash phandle. I think the fix we want looks like this: --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c @@ -224,10 +224,11 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev) dev_err(dev, "Couldn't address to resource for flash\n"); return rc; } + + lpc_ctrl->pnor_size = resource_size(&resm); + lpc_ctrl->pnor_base = resm.start; } - lpc_ctrl->pnor_size = resource_size(&resm); - lpc_ctrl->pnor_base = resm.start; Vijay, do you agree? Cheers, Joel > --- > drivers/soc/aspeed/aspeed-lpc-ctrl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/aspeed/aspeed-lpc-ctrl.c b/drivers/soc/aspeed/aspeed-lpc-ctrl.c > index 239520bb207e..81109d22af6a 100644 > --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c > +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c > @@ -212,6 +212,7 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev) > node = of_parse_phandle(dev->of_node, "flash", 0); > if (!node) { > dev_dbg(dev, "Didn't find host pnor flash node\n"); > + return -ENXIO; > } else { > rc = of_address_to_resource(node, 1, &resm); > of_node_put(node); > -- > 2.20.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Joel Stanley <joel@jms.id.au> To: Arnd Bergmann <arnd@arndb.de> Cc: linux-aspeed@lists.ozlabs.org, Andrew Jeffery <andrew@aj.id.au>, Patrick Venture <venture@google.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Vijay Khemka <vijaykhemka@fb.com>, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH] soc: aspeed: fix probe error handling Date: Thu, 20 Jun 2019 08:29:36 +0000 [thread overview] Message-ID: <CACPK8Xe0Ppr8QjPSTPyNSHEbSXvuZLjC04hqP6ATTSystY888w@mail.gmail.com> (raw) In-Reply-To: <20190619125636.1109665-1-arnd@arndb.de> On Wed, 19 Jun 2019 at 12:56, Arnd Bergmann <arnd@arndb.de> wrote: > > gcc warns that a mising "flash" phandle node leads to undefined > behavior later: > > drivers/soc/aspeed/aspeed-lpc-ctrl.c: In function 'aspeed_lpc_ctrl_probe': > drivers/soc/aspeed/aspeed-lpc-ctrl.c:201:18: error: '*((void *)&resm+8)' may be used uninitialized in this function [-Werror=maybe-uninitialized] > > The device cannot work without this node, so just error out here. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks Arnd. This looks like it applies on top of Vijay's recent patch? The intent of that change was to make the driver usable for systems that do not want to depend on the flash phandle. I think the fix we want looks like this: --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c @@ -224,10 +224,11 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev) dev_err(dev, "Couldn't address to resource for flash\n"); return rc; } + + lpc_ctrl->pnor_size = resource_size(&resm); + lpc_ctrl->pnor_base = resm.start; } - lpc_ctrl->pnor_size = resource_size(&resm); - lpc_ctrl->pnor_base = resm.start; Vijay, do you agree? Cheers, Joel > --- > drivers/soc/aspeed/aspeed-lpc-ctrl.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/aspeed/aspeed-lpc-ctrl.c b/drivers/soc/aspeed/aspeed-lpc-ctrl.c > index 239520bb207e..81109d22af6a 100644 > --- a/drivers/soc/aspeed/aspeed-lpc-ctrl.c > +++ b/drivers/soc/aspeed/aspeed-lpc-ctrl.c > @@ -212,6 +212,7 @@ static int aspeed_lpc_ctrl_probe(struct platform_device *pdev) > node = of_parse_phandle(dev->of_node, "flash", 0); > if (!node) { > dev_dbg(dev, "Didn't find host pnor flash node\n"); > + return -ENXIO; > } else { > rc = of_address_to_resource(node, 1, &resm); > of_node_put(node); > -- > 2.20.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-06-20 8:29 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-06-19 12:56 [PATCH] soc: aspeed: fix probe error handling Arnd Bergmann 2019-06-19 12:56 ` Arnd Bergmann 2019-06-20 8:29 ` Joel Stanley [this message] 2019-06-20 8:29 ` Joel Stanley 2019-06-21 16:53 ` Vijay Khemka 2019-06-21 16:53 ` Vijay Khemka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACPK8Xe0Ppr8QjPSTPyNSHEbSXvuZLjC04hqP6ATTSystY888w@mail.gmail.com \ --to=joel@jms.id.au \ --cc=andrew@aj.id.au \ --cc=arnd@arndb.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=venture@google.com \ --cc=vijaykhemka@fb.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.