From: Joel Stanley <joel@jms.id.au>
To: Troy Lee <troy_lee@aspeedtech.com>
Cc: "John Wang" <wangzhiqiang.bj@bytedance.com>,
郁雷 <yulei.sh@bytedance.com>, "Rob Herring" <robh+dt@kernel.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
"open list" <linux-kernel@vger.kernel.org>,
leetroy@gmail.com
Subject: Re: [PATCH v1] ARM: dts: Fix 64MiB OpenBMC flash layout and aspeed-ast2600-evb.dts
Date: Fri, 16 Apr 2021 03:03:25 +0000 [thread overview]
Message-ID: <CACPK8XeYtaLLWDMR8xZhERrQ_WCUJ2RM_JZmZNQ6oZSvgSDM_w@mail.gmail.com> (raw)
In-Reply-To: <20210316085932.2601-1-troy_lee@aspeedtech.com>
On Tue, 16 Mar 2021 at 08:59, Troy Lee <troy_lee@aspeedtech.com> wrote:
>
> Aspeed AST2600 u-boot requires 600KiB+ flash space. Sharing the same
> openbmc-flash-layout-64.dtsi requires to resize the flash partition.
>
> The updated flash layout as follows:
> - u-boot: 896 KiB
> - u-boot-env: 128 KiB
> - kernel: 9MiB
> - rofs: 32 MiB
> - rwfs: 22 MiB
Changing the 64MB layout will break the systems that are already using
this layout. I'll get the Bytedance people to chime in, as theirs is
the only system using this layout so far.
John, Lei?
>
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> ---
> arch/arm/boot/dts/aspeed-ast2600-evb.dts | 32 +------------------
> .../arm/boot/dts/openbmc-flash-layout-64.dtsi | 18 +++++------
> 2 files changed, 10 insertions(+), 40 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> index 89be13197780..2cfae9cfed3a 100644
> --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> @@ -121,37 +121,7 @@ flash@0 {
> m25p,fast-read;
> label = "bmc";
> spi-max-frequency = <50000000>;
> -
> - partitions {
> - compatible = "fixed-partitions";
> - #address-cells = <1>;
> - #size-cells = <1>;
> -
> - u-boot@0 {
> - reg = <0x0 0xe0000>; // 896KB
> - label = "u-boot";
> - };
> -
> - u-boot-env@e0000 {
> - reg = <0xe0000 0x20000>; // 128KB
> - label = "u-boot-env";
> - };
> -
> - kernel@100000 {
> - reg = <0x100000 0x900000>; // 9MB
> - label = "kernel";
> - };
> -
> - rofs@a00000 {
> - reg = <0xa00000 0x2000000>; // 32MB
> - label = "rofs";
> - };
> -
> - rwfs@6000000 {
> - reg = <0x2a00000 0x1600000>; // 22MB
> - label = "rwfs";
> - };
> - };
> +#include "openbmc-flash-layout-64.dtsi"
> };
> };
>
> diff --git a/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi b/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
> index 91163867be34..31f59de5190b 100644
> --- a/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
> +++ b/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
> @@ -9,27 +9,27 @@ partitions {
> #size-cells = <1>;
>
> u-boot@0 {
> - reg = <0x0 0x60000>; // 384KB
> + reg = <0x0 0xe0000>; // 896KB
> label = "u-boot";
> };
>
> - u-boot-env@60000 {
> - reg = <0x60000 0x20000>; // 128KB
> + u-boot-env@e0000 {
> + reg = <0xe0000 0x20000>; // 128KB
> label = "u-boot-env";
> };
>
> - kernel@80000 {
> - reg = <0x80000 0x500000>; // 5MB
> + kernel@100000 {
> + reg = <0x100000 0x900000>; // 9MB
> label = "kernel";
> };
>
> - rofs@580000 {
> - reg = <0x580000 0x2a80000>; // 42.5MB
> + rofs@a00000 {
> + reg = <0xa00000 0x2000000>; // 32MB
> label = "rofs";
> };
>
> - rwfs@3000000 {
> - reg = <0x3000000 0x1000000>; // 16MB
> + rwfs@6000000 {
> + reg = <0x2a00000 0x1600000>; // 22MB
> label = "rwfs";
> };
> };
> --
> 2.25.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Joel Stanley <joel@jms.id.au>
To: Troy Lee <troy_lee@aspeedtech.com>
Cc: "John Wang" <wangzhiqiang.bj@bytedance.com>,
郁雷 <yulei.sh@bytedance.com>, "Rob Herring" <robh+dt@kernel.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
"open list" <linux-kernel@vger.kernel.org>,
leetroy@gmail.com
Subject: Re: [PATCH v1] ARM: dts: Fix 64MiB OpenBMC flash layout and aspeed-ast2600-evb.dts
Date: Fri, 16 Apr 2021 03:03:25 +0000 [thread overview]
Message-ID: <CACPK8XeYtaLLWDMR8xZhERrQ_WCUJ2RM_JZmZNQ6oZSvgSDM_w@mail.gmail.com> (raw)
In-Reply-To: <20210316085932.2601-1-troy_lee@aspeedtech.com>
On Tue, 16 Mar 2021 at 08:59, Troy Lee <troy_lee@aspeedtech.com> wrote:
>
> Aspeed AST2600 u-boot requires 600KiB+ flash space. Sharing the same
> openbmc-flash-layout-64.dtsi requires to resize the flash partition.
>
> The updated flash layout as follows:
> - u-boot: 896 KiB
> - u-boot-env: 128 KiB
> - kernel: 9MiB
> - rofs: 32 MiB
> - rwfs: 22 MiB
Changing the 64MB layout will break the systems that are already using
this layout. I'll get the Bytedance people to chime in, as theirs is
the only system using this layout so far.
John, Lei?
>
> Signed-off-by: Troy Lee <troy_lee@aspeedtech.com>
> ---
> arch/arm/boot/dts/aspeed-ast2600-evb.dts | 32 +------------------
> .../arm/boot/dts/openbmc-flash-layout-64.dtsi | 18 +++++------
> 2 files changed, 10 insertions(+), 40 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed-ast2600-evb.dts b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> index 89be13197780..2cfae9cfed3a 100644
> --- a/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> +++ b/arch/arm/boot/dts/aspeed-ast2600-evb.dts
> @@ -121,37 +121,7 @@ flash@0 {
> m25p,fast-read;
> label = "bmc";
> spi-max-frequency = <50000000>;
> -
> - partitions {
> - compatible = "fixed-partitions";
> - #address-cells = <1>;
> - #size-cells = <1>;
> -
> - u-boot@0 {
> - reg = <0x0 0xe0000>; // 896KB
> - label = "u-boot";
> - };
> -
> - u-boot-env@e0000 {
> - reg = <0xe0000 0x20000>; // 128KB
> - label = "u-boot-env";
> - };
> -
> - kernel@100000 {
> - reg = <0x100000 0x900000>; // 9MB
> - label = "kernel";
> - };
> -
> - rofs@a00000 {
> - reg = <0xa00000 0x2000000>; // 32MB
> - label = "rofs";
> - };
> -
> - rwfs@6000000 {
> - reg = <0x2a00000 0x1600000>; // 22MB
> - label = "rwfs";
> - };
> - };
> +#include "openbmc-flash-layout-64.dtsi"
> };
> };
>
> diff --git a/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi b/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
> index 91163867be34..31f59de5190b 100644
> --- a/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
> +++ b/arch/arm/boot/dts/openbmc-flash-layout-64.dtsi
> @@ -9,27 +9,27 @@ partitions {
> #size-cells = <1>;
>
> u-boot@0 {
> - reg = <0x0 0x60000>; // 384KB
> + reg = <0x0 0xe0000>; // 896KB
> label = "u-boot";
> };
>
> - u-boot-env@60000 {
> - reg = <0x60000 0x20000>; // 128KB
> + u-boot-env@e0000 {
> + reg = <0xe0000 0x20000>; // 128KB
> label = "u-boot-env";
> };
>
> - kernel@80000 {
> - reg = <0x80000 0x500000>; // 5MB
> + kernel@100000 {
> + reg = <0x100000 0x900000>; // 9MB
> label = "kernel";
> };
>
> - rofs@580000 {
> - reg = <0x580000 0x2a80000>; // 42.5MB
> + rofs@a00000 {
> + reg = <0xa00000 0x2000000>; // 32MB
> label = "rofs";
> };
>
> - rwfs@3000000 {
> - reg = <0x3000000 0x1000000>; // 16MB
> + rwfs@6000000 {
> + reg = <0x2a00000 0x1600000>; // 22MB
> label = "rwfs";
> };
> };
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-16 3:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 8:59 [PATCH v1] ARM: dts: Fix 64MiB OpenBMC flash layout and aspeed-ast2600-evb.dts Troy Lee
2021-03-16 8:59 ` Troy Lee
2021-04-16 3:03 ` Joel Stanley [this message]
2021-04-16 3:03 ` Joel Stanley
2021-04-16 7:35 ` [External] " Lei Yu
2021-04-16 7:35 ` Lei Yu
2021-06-03 6:02 ` Joel Stanley
2021-06-03 6:02 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACPK8XeYtaLLWDMR8xZhERrQ_WCUJ2RM_JZmZNQ6oZSvgSDM_w@mail.gmail.com \
--to=joel@jms.id.au \
--cc=andrew@aj.id.au \
--cc=devicetree@vger.kernel.org \
--cc=leetroy@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=troy_lee@aspeedtech.com \
--cc=wangzhiqiang.bj@bytedance.com \
--cc=yulei.sh@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.