Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state

From: Joel Stanley <joel@jms.id.au>
To: Alistair Popple <alistair@popple.id.au>,
	Greg KH <gregkh@linuxfoundation.org>
Cc: OpenBMC Maillist <openbmc@lists.ozlabs.org>,
	Andrew Jeffery <andrew@aj.id.au>,
	Eddie James <eajames@linux.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fsi: sbefifo: Don't fail operations when in SBE IPL state
Date: Mon, 17 Jun 2019 05:41:34 +0000	[thread overview]
Message-ID: <CACPK8XfqSyMB4pWLffzx+8qOj+m54h=aWUhYsKMV4TQR0fKVUg@mail.gmail.com> (raw)
In-Reply-To: <1780173.icGFXHrAMq@townsend>

On Mon, 17 Jun 2019 at 02:09, Alistair Popple <alistair@popple.id.au> wrote:
>
> On Monday, 21 January 2019 11:15:58 AM AEST Eddie James wrote:
> > SBE fifo operations should be allowed while the SBE is in any of the
> > "IPL" states. Operations should succeed in this state.
> >
> > Signed-off-by: Eddie James <eajames@linux.ibm.com>
>
> This fixed the problem I was having trying to issue istep operations to the
> SBE.
>
> Tested-by: Alistair Popple <alistair@popple.id.au>

This one slipped through the cracks.

Fixes: 9f4a8a2d7f9d fsi/sbefifo: Add driver for the SBE FIFO
Reviewed-by: Joel Stanley <joel@jsm.id.au>

Greg, can you please queue this one up for 5.3?

Cheers,

Joel

> > ---
> >  drivers/fsi/fsi-sbefifo.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> > index c7d13ac..f7665b3 100644
> > --- a/drivers/fsi/fsi-sbefifo.c
> > +++ b/drivers/fsi/fsi-sbefifo.c
> > @@ -290,11 +290,11 @@ static int sbefifo_check_sbe_state(struct sbefifo
> > *sbefifo) switch ((sbm & CFAM_SBM_SBE_STATE_MASK) >>
> > CFAM_SBM_SBE_STATE_SHIFT) { case SBE_STATE_UNKNOWN:
> >               return -ESHUTDOWN;
> > +     case SBE_STATE_DMT:
> > +             return -EBUSY;
> >       case SBE_STATE_IPLING:
> >       case SBE_STATE_ISTEP:
> >       case SBE_STATE_MPIPL:
> > -     case SBE_STATE_DMT:
> > -             return -EBUSY;
> >       case SBE_STATE_RUNTIME:
> >       case SBE_STATE_DUMP: /* Not sure about that one */
> >               break;
>
>