From: Joel Stanley <joel@jms.id.au> To: "Heiko Stübner" <heiko@sntech.de> Cc: linux-arm-kernel@lists.infradead.org, Arnd Bergmann <arnd@arndb.de>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Jeremy Kerr <jk@ozlabs.org>, mturquette@baylibre.com, sboyd@codeaurora.org, linux-clk@vger.kernel.org Subject: Re: [PATCH v2 03/11] doc/devicetree: Add Aspeed clock bindings Date: Wed, 27 Apr 2016 18:01:00 +0930 [thread overview] Message-ID: <CACPK8XfvLR+yZv77C0Eq=RsPOufrwvQjdPtBhnufNc=eJRLZYg@mail.gmail.com> (raw) In-Reply-To: <4956403.scaVRGhPEf@diego> On Thu, Apr 21, 2016 at 8:50 PM, Heiko St=C3=BCbner <heiko@sntech.de> wrote= : > [+clock-related patches should include clock-maintainers and lists] Thanks. > Am Donnerstag, 21. April 2016, 17:34:01 schrieb Joel Stanley: >> +For example: >> + >> + clk_clkin: clk_clkin { >> + #clock-cells =3D <0>; >> + compatible =3D "fixed-clock"; >> + clock-frequency =3D <48000000>; >> + }; >> + >> + clk_hpll: clk_hpll { >> + compatible =3D "aspeed,g4-hpll-clock"; >> + #clock-cells =3D <0>; >> + reg =3D <0x1e6e2008 0x4>; >> + }; >> + >> + clk_apb: clk_apb@1e6e2008 { >> + #clock-cells =3D <0>; >> + compatible =3D "aspeed,g4-apb-clock"; >> + reg =3D <0x1e6e2008 0x4>; >> + clocks =3D <&clk_hpll>; >> + }; > > You have both the hpll and apb_clk in the same register (probably even mo= re > clocks?) and separate clock instances where each instance will of_iomap t= he > register itself (and thus multiple times in general). Yep. I agree that's not ideal. > > From what I remember exposing the clock controller as one block (instead = of > declaring each clock individually in the dts) is still the preferred way = but I > don't think I can find Mike's mail from back then easily. I can't picture how that would look. I took my lead from the moxart clock driver; is there a better example that I should follow? Cheers, Joel
WARNING: multiple messages have this Message-ID (diff)
From: joel@jms.id.au (Joel Stanley) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 03/11] doc/devicetree: Add Aspeed clock bindings Date: Wed, 27 Apr 2016 18:01:00 +0930 [thread overview] Message-ID: <CACPK8XfvLR+yZv77C0Eq=RsPOufrwvQjdPtBhnufNc=eJRLZYg@mail.gmail.com> (raw) In-Reply-To: <4956403.scaVRGhPEf@diego> On Thu, Apr 21, 2016 at 8:50 PM, Heiko St?bner <heiko@sntech.de> wrote: > [+clock-related patches should include clock-maintainers and lists] Thanks. > Am Donnerstag, 21. April 2016, 17:34:01 schrieb Joel Stanley: >> +For example: >> + >> + clk_clkin: clk_clkin { >> + #clock-cells = <0>; >> + compatible = "fixed-clock"; >> + clock-frequency = <48000000>; >> + }; >> + >> + clk_hpll: clk_hpll { >> + compatible = "aspeed,g4-hpll-clock"; >> + #clock-cells = <0>; >> + reg = <0x1e6e2008 0x4>; >> + }; >> + >> + clk_apb: clk_apb at 1e6e2008 { >> + #clock-cells = <0>; >> + compatible = "aspeed,g4-apb-clock"; >> + reg = <0x1e6e2008 0x4>; >> + clocks = <&clk_hpll>; >> + }; > > You have both the hpll and apb_clk in the same register (probably even more > clocks?) and separate clock instances where each instance will of_iomap the > register itself (and thus multiple times in general). Yep. I agree that's not ideal. > > From what I remember exposing the clock controller as one block (instead of > declaring each clock individually in the dts) is still the preferred way but I > don't think I can find Mike's mail from back then easily. I can't picture how that would look. I took my lead from the moxart clock driver; is there a better example that I should follow? Cheers, Joel
next prev parent reply other threads:[~2016-04-27 8:31 UTC|newest] Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-04-14 9:47 [PATCH 0/9] Aspeed AST2400 BMC support Joel Stanley 2016-04-14 9:47 ` Joel Stanley 2016-04-14 9:47 ` [PATCH 1/9] doc/devicetree: Add Aspeed and Tyan to vendor-prefixes Joel Stanley 2016-04-14 9:47 ` [PATCH 2/9] doc/devicetree: Add Aspeed VIC bindings Joel Stanley 2016-04-14 9:47 ` [PATCH 3/9] doc/devicetree: Add Aspeed clock bindings Joel Stanley 2016-04-14 9:47 ` [PATCH 4/9] clocksource/moxart: Generalise timer for use on other socs Joel Stanley 2016-04-14 9:47 ` [PATCH 5/9] irqchip: Add irq controller for Aspeed Joel Stanley 2016-04-14 9:47 ` [PATCH 6/9] drivers/clk: Add Aspeed clock driver Joel Stanley 2016-04-14 9:47 ` [PATCH 7/9] arm/dts: Add aspeed device trees Joel Stanley 2016-04-14 9:47 ` [PATCH 8/9] arm: Add Aspeed AST2400 machine Joel Stanley 2016-04-14 9:47 ` [PATCH 9/9] arm/configs: Add aspeed defconfig Joel Stanley 2016-04-21 8:03 ` [PATCH v2 00/11] Aspeed AST2400 and AST2500 BMC support Joel Stanley 2016-04-21 8:03 ` [PATCH v2 01/11] doc/devicetree: Add Aspeed and Tyan to vendor-prefixes Joel Stanley 2016-04-21 8:04 ` [PATCH v2 02/11] doc/devicetree: Add Aspeed VIC bindings Joel Stanley 2016-04-21 8:04 ` [PATCH v2 03/11] doc/devicetree: Add Aspeed clock bindings Joel Stanley 2016-04-21 11:20 ` Heiko Stübner 2016-04-21 11:20 ` Heiko Stübner 2016-04-27 8:31 ` Joel Stanley [this message] 2016-04-27 8:31 ` Joel Stanley 2016-04-27 9:12 ` Heiko Stübner 2016-04-27 9:12 ` Heiko Stübner 2016-04-28 6:50 ` Joel Stanley 2016-04-28 6:50 ` Joel Stanley 2016-04-28 7:25 ` Heiko Stübner 2016-04-28 7:25 ` Heiko Stübner 2016-04-28 8:38 ` Benjamin Herrenschmidt 2016-04-28 8:38 ` Benjamin Herrenschmidt 2016-04-21 8:04 ` [PATCH v2 04/11] clocksource/moxart: Generalise timer for use on other socs Joel Stanley 2016-04-21 8:22 ` Arnd Bergmann 2016-04-22 1:06 ` Joel Stanley 2016-04-22 17:30 ` Daniel Lezcano 2016-04-22 23:55 ` Benjamin Herrenschmidt 2016-05-03 5:56 ` Joel Stanley 2016-05-03 13:36 ` Daniel Lezcano 2016-05-06 14:50 ` Jonas Jensen 2016-04-21 8:04 ` [PATCH v2 05/11] irqchip: Add irq controller for Aspeed Joel Stanley 2016-04-21 8:04 ` [PATCH v2 06/11] clk: Add driver for Aspeed fourth gen SoCs Joel Stanley 2016-04-21 8:04 ` [PATCH v2 07/11] clk: Add driver for Aspeed fifth " Joel Stanley 2016-04-21 8:04 ` [PATCH v2 08/11] arm/dts: Add Aspeed ast2400 device tree Joel Stanley 2016-04-21 8:25 ` Arnd Bergmann 2016-04-21 8:04 ` [PATCH v2 09/11] arm/dst: Add Aspeed ast2500 " Joel Stanley 2016-05-05 23:11 ` Xo Wang 2016-05-06 7:28 ` Joel Stanley 2016-04-21 8:04 ` [PATCH v2 10/11] arm: Add Aspeed machine Joel Stanley 2016-04-21 8:35 ` Arnd Bergmann 2016-04-21 22:28 ` Benjamin Herrenschmidt 2016-04-21 23:02 ` Benjamin Herrenschmidt 2016-04-22 5:20 ` Afzal Mohammed 2016-04-22 5:32 ` Joel Stanley 2016-04-22 16:37 ` Arnd Bergmann 2016-04-21 8:04 ` [PATCH v2 11/11] arm/configs: Add aspeed defconfig Joel Stanley 2016-04-21 8:44 ` Arnd Bergmann 2016-04-21 8:54 ` [PATCH v2 00/11] Aspeed AST2400 and AST2500 BMC support Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CACPK8XfvLR+yZv77C0Eq=RsPOufrwvQjdPtBhnufNc=eJRLZYg@mail.gmail.com' \ --to=joel@jms.id.au \ --cc=arnd@arndb.de \ --cc=benh@kernel.crashing.org \ --cc=heiko@sntech.de \ --cc=jk@ozlabs.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=mturquette@baylibre.com \ --cc=sboyd@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.