From: Linus Walleij <linus.walleij@linaro.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [PATCH v3 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument
Date: Tue, 15 Nov 2016 10:19:21 +0100 [thread overview]
Message-ID: <CACRpkdYED7dMFGpurWHXRcCozP+OrvJ+-ejZ1quJKOPpo9BHOA@mail.gmail.com> (raw)
In-Reply-To: <20161111095036.11803-2-wens@csie.org>
On Fri, Nov 11, 2016 at 10:50 AM, Chen-Yu Tsai <wens@csie.org> wrote:
> According to pinconf-generic.h, the argument for
> PIN_CONFIG_BIAS_PULL_{DOWN,UP} is non-zero if the bias is enabled
> with a pull up/down resistor, zero if it is directly connected
> to VDD or ground.
>
> Since Allwinner hardware uses a weak pull resistor internally,
> the argument should be 1.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied this v3 rather than the v2.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN, UP} argument
Date: Tue, 15 Nov 2016 10:19:21 +0100 [thread overview]
Message-ID: <CACRpkdYED7dMFGpurWHXRcCozP+OrvJ+-ejZ1quJKOPpo9BHOA@mail.gmail.com> (raw)
In-Reply-To: <20161111095036.11803-2-wens@csie.org>
On Fri, Nov 11, 2016 at 10:50 AM, Chen-Yu Tsai <wens@csie.org> wrote:
> According to pinconf-generic.h, the argument for
> PIN_CONFIG_BIAS_PULL_{DOWN,UP} is non-zero if the bias is enabled
> with a pull up/down resistor, zero if it is directly connected
> to VDD or ground.
>
> Since Allwinner hardware uses a weak pull resistor internally,
> the argument should be 1.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied this v3 rather than the v2.
Yours,
Linus Walleij
next prev parent reply other threads:[~2016-11-15 9:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 9:50 [PATCH v3 0/3] pinctrl: sunxi: Support generic pinconf functions Chen-Yu Tsai
2016-11-11 9:50 ` Chen-Yu Tsai
2016-11-11 9:50 ` Chen-Yu Tsai
[not found] ` <20161111095036.11803-1-wens-jdAy2FN1RRM@public.gmane.org>
2016-11-11 9:50 ` [PATCH v3 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument Chen-Yu Tsai
2016-11-11 9:50 ` [PATCH v3 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN, UP} argument Chen-Yu Tsai
2016-11-11 9:50 ` [PATCH v3 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument Chen-Yu Tsai
2016-11-15 9:19 ` Linus Walleij [this message]
2016-11-15 9:19 ` [PATCH v3 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN, UP} argument Linus Walleij
2016-11-15 9:19 ` [PATCH v3 1/3] pinctrl: sunxi: Fix PIN_CONFIG_BIAS_PULL_{DOWN,UP} argument Linus Walleij
2016-11-11 9:50 ` [PATCH v3 2/3] pinctrl: sunxi: Add support for fetching pinconf settings from hardware Chen-Yu Tsai
2016-11-11 9:50 ` Chen-Yu Tsai
2016-11-11 9:50 ` Chen-Yu Tsai
[not found] ` <20161111095036.11803-3-wens-jdAy2FN1RRM@public.gmane.org>
2016-11-11 13:51 ` Maxime Ripard
2016-11-11 13:51 ` Maxime Ripard
2016-11-11 13:51 ` Maxime Ripard
2016-11-11 13:57 ` Chen-Yu Tsai
2016-11-11 13:57 ` Chen-Yu Tsai
2016-11-11 13:57 ` Chen-Yu Tsai
2016-11-15 9:21 ` Linus Walleij
2016-11-15 9:21 ` Linus Walleij
2016-11-15 9:21 ` Linus Walleij
2016-11-11 9:50 ` [PATCH v3 3/3] pinctrl: sunxi: Make sunxi_pconf_group_set use sunxi_pconf_reg helper Chen-Yu Tsai
2016-11-11 9:50 ` Chen-Yu Tsai
2016-11-11 9:50 ` Chen-Yu Tsai
[not found] ` <20161111095036.11803-4-wens-jdAy2FN1RRM@public.gmane.org>
2016-11-15 9:22 ` Linus Walleij
2016-11-15 9:22 ` Linus Walleij
2016-11-15 9:22 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYED7dMFGpurWHXRcCozP+OrvJ+-ejZ1quJKOPpo9BHOA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.