From: Linus Walleij <linus.walleij@linaro.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "ext Tony Lindgren" <tony@atomide.com>,
"viresh kumar" <viresh.kumar@linaro.org>,
"David Brown" <david.brown@linaro.org>,
"Xu Wei" <xuwei5@hisilicon.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"Viresh Kumar" <vireshk@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Kukjin Kim" <kgene@kernel.org>,
"Andy Gross" <andy.gross@linaro.org>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-arm-msm@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Barry Song" <baohua@kernel.org>,
"Frank Rowand" <frank.rowand@am.sony.com>,
"Patrice CHOTARD" <patrice.chotard@st.com>,
"shiraz hashim" <shiraz.linux.kernel@gmail.com>
Subject: Re: [PATCH 1/3] arm: Convert arm boot_lock to raw
Date: Fri, 7 Dec 2018 13:49:56 +0100 [thread overview]
Message-ID: <CACRpkdYGkTrVy25nzZa9A-Kp7iNr4aMpTS_DyOEjHVmWOBbd6g@mail.gmail.com> (raw)
In-Reply-To: <20181207102749.15205-2-bigeasy@linutronix.de>
On Fri, Dec 7, 2018 at 11:28 AM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> From: Frank Rowand <frank.rowand@am.sony.com>
>
> The arm boot_lock is used by the secondary processor startup code. The locking
> task is the idle thread, which has idle->sched_class == &idle_sched_class.
> idle_sched_class->enqueue_task == NULL, so if the idle task blocks on the
> lock, the attempt to wake it when the lock becomes available will fail:
>
> try_to_wake_up()
> ...
> activate_task()
> enqueue_task()
> p->sched_class->enqueue_task(rq, p, flags)
>
> Fix by converting boot_lock to a raw spin lock.
This makes perfect sense.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "ext Tony Lindgren" <tony@atomide.com>,
"viresh kumar" <viresh.kumar@linaro.org>,
"David Brown" <david.brown@linaro.org>,
"Xu Wei" <xuwei5@hisilicon.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"Viresh Kumar" <vireshk@kernel.org>,
"Russell King" <linux@armlinux.org.uk>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"Chen-Yu Tsai" <wens@csie.org>, "Kukjin Kim" <kgene@kernel.org>,
"Andy Gross" <andy.gross@linaro.org>,
"Arnd Bergmann" <arnd@arndb.de>,
linux-arm-msm@vger.kernel.org,
"Thomas Gleixner" <tglx@linutronix.de>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"Linux ARM" <linux-arm-kernel@lists.infradead.org>,
"Barry Song" <baohua@kernel.org>,
"Frank Rowand" <frank.rowand@am.sony.com>,
"Patrice CHOTARD" <patrice.chotard@st.com>,
"shiraz hashim" <shiraz.linux.kernel@gmail.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: Re: [PATCH 1/3] arm: Convert arm boot_lock to raw
Date: Fri, 7 Dec 2018 13:49:56 +0100 [thread overview]
Message-ID: <CACRpkdYGkTrVy25nzZa9A-Kp7iNr4aMpTS_DyOEjHVmWOBbd6g@mail.gmail.com> (raw)
In-Reply-To: <20181207102749.15205-2-bigeasy@linutronix.de>
On Fri, Dec 7, 2018 at 11:28 AM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
> From: Frank Rowand <frank.rowand@am.sony.com>
>
> The arm boot_lock is used by the secondary processor startup code. The locking
> task is the idle thread, which has idle->sched_class == &idle_sched_class.
> idle_sched_class->enqueue_task == NULL, so if the idle task blocks on the
> lock, the attempt to wake it when the lock becomes available will fail:
>
> try_to_wake_up()
> ...
> activate_task()
> enqueue_task()
> p->sched_class->enqueue_task(rq, p, flags)
>
> Fix by converting boot_lock to a raw spin lock.
This makes perfect sense.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-07 12:49 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 10:27 [PATCH 0/3 REPOST] arm: covert a few spinlock_t locks to raw_spinlock_t Sebastian Andrzej Siewior
2018-12-07 10:27 ` [PATCH 1/3] arm: Convert arm boot_lock to raw Sebastian Andrzej Siewior
2018-12-07 12:49 ` Linus Walleij [this message]
2018-12-07 12:49 ` Linus Walleij
2018-12-07 13:00 ` Russell King - ARM Linux
2018-12-07 13:00 ` Russell King - ARM Linux
2018-12-08 23:15 ` Linus Walleij
2018-12-08 23:15 ` Linus Walleij
2018-12-09 0:41 ` Russell King - ARM Linux
2018-12-09 0:41 ` Russell King - ARM Linux
2018-12-10 14:37 ` Sebastian Andrzej Siewior
2018-12-10 14:37 ` Sebastian Andrzej Siewior
2018-12-11 18:19 ` Linus Walleij
2018-12-11 18:19 ` Linus Walleij
2018-12-11 21:23 ` [PATCH 1/3 v2] arm: versatile: Convert " Sebastian Andrzej Siewior
2018-12-11 21:23 ` Sebastian Andrzej Siewior
2018-12-11 21:29 ` [PATCH 1/3] arm: Convert arm " Sebastian Andrzej Siewior
2018-12-11 21:29 ` Sebastian Andrzej Siewior
2018-12-13 11:48 ` Russell King - ARM Linux
2018-12-13 11:48 ` Russell King - ARM Linux
2018-12-13 12:42 ` Sebastian Andrzej Siewior
2018-12-13 12:42 ` Sebastian Andrzej Siewior
2018-12-12 11:15 ` Russell King - ARM Linux
2018-12-12 11:15 ` Russell King - ARM Linux
2018-12-07 10:27 ` [PATCH 2/3] arm: kprobe: make patch_lock a raw_spinlock_t Sebastian Andrzej Siewior
2019-02-13 8:46 ` Sebastian Andrzej Siewior
2018-12-07 10:27 ` [PATCH 3/3] arm: use a raw_spinlock_t in unwind Sebastian Andrzej Siewior
2019-02-13 8:46 ` Sebastian Andrzej Siewior
2019-02-13 15:14 ` Arnd Bergmann
2019-02-13 15:57 ` Sebastian Andrzej Siewior
-- strict thread matches above, loose matches on Subject: below --
2018-07-11 11:00 [PATCH 0/3] arm: covert a few locks to raw_spin_lock_t Sebastian Andrzej Siewior
2018-07-11 11:00 ` [PATCH 1/3] arm: Convert arm boot_lock to raw Sebastian Andrzej Siewior
2018-07-11 11:00 ` Sebastian Andrzej Siewior
2018-07-11 15:29 ` Andreas Färber
2018-07-11 15:29 ` Andreas Färber
2018-07-16 4:20 ` Viresh Kumar
2018-07-16 4:20 ` Viresh Kumar
2018-07-16 7:42 ` Patrice CHOTARD
2018-07-16 7:42 ` Patrice CHOTARD
2018-07-16 15:30 ` Wei Xu
2018-07-16 15:30 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYGkTrVy25nzZa9A-Kp7iNr4aMpTS_DyOEjHVmWOBbd6g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=andy.gross@linaro.org \
--cc=arnd@arndb.de \
--cc=baohua@kernel.org \
--cc=bigeasy@linutronix.de \
--cc=david.brown@linaro.org \
--cc=frank.rowand@am.sony.com \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maxime.ripard@bootlin.com \
--cc=patrice.chotard@st.com \
--cc=shiraz.linux.kernel@gmail.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
--cc=wens@csie.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.