All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	STEricsson_nomadik_linux@list.st.com,
	linus.walleij@stericsson.com, arnd@arndb.de
Subject: Re: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping
Date: Tue, 10 Jul 2012 23:08:39 +0200	[thread overview]
Message-ID: <CACRpkdYJi3Kk3gpdgFLWr+tun4LZNMw0ET6W2nHJfY5jSvgcjw@mail.gmail.com> (raw)
In-Reply-To: <4FFB4B5F.30103@linaro.org>

On Mon, Jul 9, 2012 at 11:21 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On 09/07/12 23:03, Linus Walleij wrote:

>> Now since I was fooled by the last patch, thinking you had tested it
>> before
>> submitting (obviously not) - please send a test log of some
>> cat /dev/input/event* for this one before I ACK it this time.

(Hm, sorry for grumpy mode...)

> I did test it, but must have only looked at the one IRQ incrementing.

That's not enough, cat /dev/input/event/* whatever event node is used
by the ponkey, press it and verify you get some garbage (=events)
in the console.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping
Date: Tue, 10 Jul 2012 23:08:39 +0200	[thread overview]
Message-ID: <CACRpkdYJi3Kk3gpdgFLWr+tun4LZNMw0ET6W2nHJfY5jSvgcjw@mail.gmail.com> (raw)
In-Reply-To: <4FFB4B5F.30103@linaro.org>

On Mon, Jul 9, 2012 at 11:21 PM, Lee Jones <lee.jones@linaro.org> wrote:
> On 09/07/12 23:03, Linus Walleij wrote:

>> Now since I was fooled by the last patch, thinking you had tested it
>> before
>> submitting (obviously not) - please send a test log of some
>> cat /dev/input/event* for this one before I ACK it this time.

(Hm, sorry for grumpy mode...)

> I did test it, but must have only looked at the one IRQ incrementing.

That's not enough, cat /dev/input/event/* whatever event node is used
by the ponkey, press it and verify you get some garbage (=events)
in the console.

Yours,
Linus Walleij

  reply	other threads:[~2012-07-10 21:08 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-05 13:06 [PATCH 0/9] Final batch of clean-ups bound for v3.6 Lee Jones
2012-07-05 13:06 ` Lee Jones
2012-07-05 13:06 ` [PATCH 1/9] pinctrl: pinctrl-nomadik: Fix possible memory leak Lee Jones
2012-07-05 13:06   ` Lee Jones
2012-07-06  7:03   ` Linus Walleij
2012-07-06  7:03     ` Linus Walleij
2012-07-05 13:06 ` [PATCH 2/9] pinctrl: pinctrl-nomadik: Append sleepmode property with vendor specific prefixes Lee Jones
2012-07-05 13:06   ` Lee Jones
2012-07-06  7:04   ` Linus Walleij
2012-07-06  7:04     ` Linus Walleij
2012-07-05 13:06 ` [PATCH 3/9] ARM: ux500: Remove AB8500 regulator register initialisation information Lee Jones
2012-07-05 13:06   ` Lee Jones
2012-07-05 13:51   ` Arnd Bergmann
2012-07-05 13:51     ` Arnd Bergmann
2012-07-05 13:55     ` Lee Jones
2012-07-05 13:55       ` Lee Jones
2012-07-05 21:21     ` Linus Walleij
2012-07-05 21:21       ` Linus Walleij
2012-07-06  6:55   ` Linus Walleij
2012-07-06  6:55     ` Linus Walleij
2012-07-06  7:45     ` Lee Jones
2012-07-06  7:45       ` Lee Jones
2012-07-06 11:23       ` Mark Brown
2012-07-06 11:23         ` Mark Brown
2012-07-06 11:52         ` Lee Jones
2012-07-06 11:52           ` Lee Jones
2012-07-06 12:34           ` Mark Brown
2012-07-06 12:34             ` Mark Brown
2012-07-05 13:06 ` [PATCH 4/9] ARM: ux500: Ensure vendor specific properties have the vendor's identifier Lee Jones
2012-07-05 13:06   ` Lee Jones
2012-07-06  7:10   ` Linus Walleij
2012-07-06  7:10     ` Linus Walleij
2012-07-05 13:06 ` [PATCH 5/9] ARM: ux500: Remove temporary snowball_of_platform_devs enablement structure Lee Jones
2012-07-05 13:06   ` Lee Jones
2012-07-06  7:10   ` Linus Walleij
2012-07-06  7:10     ` Linus Walleij
2012-07-05 13:06 ` [PATCH 6/9] ARM: ux500: Remove PMU platform registration when booting with DT Lee Jones
2012-07-05 13:06   ` Lee Jones
2012-07-06  7:11   ` Linus Walleij
2012-07-06  7:11     ` Linus Walleij
2012-07-05 13:06 ` [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Lee Jones
2012-07-05 13:06   ` Lee Jones
2012-07-06  7:18   ` Linus Walleij
2012-07-06  7:18     ` Linus Walleij
2012-07-05 13:06 ` [PATCH 8/9] ARM: ux500: Clean-up temporary Device Tree enablement helpers Lee Jones
2012-07-05 13:06   ` Lee Jones
2012-07-06  7:23   ` Linus Walleij
2012-07-06  7:23     ` Linus Walleij
2012-07-06  8:33   ` Lee Jones
2012-07-06  8:33     ` Lee Jones
2012-07-08 19:11     ` Linus Walleij
2012-07-08 19:11       ` Linus Walleij
2012-07-09 18:50       ` Lee Jones
2012-07-09 18:50         ` Lee Jones
2012-07-09 20:36         ` Linus Walleij
2012-07-09 20:36           ` Linus Walleij
2012-07-05 13:06 ` [PATCH 9/9] ARM: ux500: Over-ride the DT device naming scheme for pinctrl Lee Jones
2012-07-05 13:06   ` Lee Jones
2012-07-06  7:25   ` Linus Walleij
2012-07-06  7:25     ` Linus Walleij
2012-07-06  7:52 ` [PATCH 7/9] Input: ab8500-ponkey: Create AB8500 domain IRQ mapping Lee Jones
2012-07-06  7:52   ` Lee Jones
2012-07-06 17:39   ` Dmitry Torokhov
2012-07-06 17:39     ` Dmitry Torokhov
2012-07-06 17:51     ` Lee Jones
2012-07-09 18:53     ` Lee Jones
2012-07-09 18:53       ` Lee Jones
2012-07-09 20:14       ` Dmitry Torokhov
2012-07-09 20:14         ` Dmitry Torokhov
2012-07-09 20:34         ` Lee Jones
2012-07-09 20:34           ` Lee Jones
2012-07-09 20:35         ` Lee Jones
2012-07-09 20:35           ` Lee Jones
2012-07-09 20:37           ` Linus Walleij
2012-07-09 20:37             ` Linus Walleij
2012-07-09 20:42             ` Lee Jones
2012-07-09 20:42               ` Lee Jones
2012-07-09 20:46           ` Dmitry Torokhov
2012-07-09 20:46             ` Dmitry Torokhov
2012-07-09 20:56             ` Lee Jones
2012-07-09 20:56               ` Lee Jones
2012-07-09 20:59             ` Lee Jones
2012-07-09 20:59               ` Lee Jones
2012-07-09 21:03               ` Linus Walleij
2012-07-09 21:03                 ` Linus Walleij
2012-07-09 21:21                 ` Lee Jones
2012-07-09 21:21                   ` Lee Jones
2012-07-10 21:08                   ` Linus Walleij [this message]
2012-07-10 21:08                     ` Linus Walleij
2012-07-12 16:37                     ` Mark Brown
2012-07-12 16:37                       ` Mark Brown
2012-07-13 13:43                     ` Lee Jones
2012-07-13 13:43                       ` Lee Jones
2012-07-14 21:36                       ` Linus Walleij
2012-07-14 21:36                         ` Linus Walleij
2012-07-10  6:17               ` Dmitry Torokhov
2012-07-10  6:17                 ` Dmitry Torokhov
2012-07-10  6:22                 ` Lee Jones
2012-07-10  6:22                   ` Lee Jones
2012-07-16  7:35                 ` Lee Jones
2012-07-16  7:35                   ` Lee Jones
2012-07-16 13:57                   ` Samuel Ortiz
2012-07-16 13:57                     ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdYJi3Kk3gpdgFLWr+tun4LZNMw0ET6W2nHJfY5jSvgcjw@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=STEricsson_nomadik_linux@list.st.com \
    --cc=arnd@arndb.de \
    --cc=dmitry.torokhov@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.