From: Linus Walleij <linus.walleij@linaro.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Robert Foss <robert.foss@linaro.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Emil Velikov <emil.velikov@collabora.com>,
Inki Dae <inki.dae@samsung.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Jordan Crouse <jcrouse@codeaurora.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rajendra Nayak <rnayak@codeaurora.org>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Rob Clark <robdclark@gmail.com>, Sam Ravnborg <sam@ravnborg.org>,
Sean Paul <sean@poorly.run>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Viresh Kumar <viresh.kumar@linaro.org>,
Xin Ji <xji@analogixsemi.com>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
freedreno <freedreno@lists.freedesktop.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features
Date: Mon, 28 Jun 2021 13:10:23 +0200 [thread overview]
Message-ID: <CACRpkdYK3nw890YFNxgtrwDvxcoeNVu7MxqUw94NN_6PiYxkJQ@mail.gmail.com> (raw)
In-Reply-To: <CANMq1KAsvXZAjmYCMQsAUwpkzuA9-PRnNWkpsLuNbOkP6DixGA@mail.gmail.com>
On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat <drinkcat@chromium.org> wrote:
> On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > > dsi->mode_flags =
> > > MIPI_DSI_CLOCK_NON_CONTINUOUS |
> > > - MIPI_DSI_MODE_EOT_PACKET;
> > > + MIPI_DSI_MODE_NO_EOT_PACKET;
> >
> > Same, just delete the flag.
> >
> > These are all just semantic bugs due to the ambiguity of the flags, it is
> > possible to provide a Fixes: flag for each file using this flag the wrong way
> > but I dunno if it's worth it.
>
> Wow nice catch.
>
> I think we should fix all of those _before_ my patch is applied, with
> proper Fixes tags so that this can be backported to stable branches,
> even if it's a no-op. I can look into it but that may take a bit of
> time.
This is fixed now, please will you proceed with this patch, because I
really like it!
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Robert Foss <robert.foss@linaro.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Emil Velikov <emil.velikov@collabora.com>,
Inki Dae <inki.dae@samsung.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Jordan Crouse <jcrouse@codeaurora.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rajendra Nayak <rnayak@codeaurora.org>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Rob Clark <robdclark@gmail.com>, Sam Ravnborg <sam@ravnborg.org>,
Sean Paul <sean@poorly.run>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Viresh Kumar <viresh.kumar@linaro.org>,
Xin Ji <xji@analogixsemi.com>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
freedreno <freedreno@lists.freedesktop.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features
Date: Mon, 28 Jun 2021 13:10:23 +0200 [thread overview]
Message-ID: <CACRpkdYK3nw890YFNxgtrwDvxcoeNVu7MxqUw94NN_6PiYxkJQ@mail.gmail.com> (raw)
In-Reply-To: <CANMq1KAsvXZAjmYCMQsAUwpkzuA9-PRnNWkpsLuNbOkP6DixGA@mail.gmail.com>
On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat <drinkcat@chromium.org> wrote:
> On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > > dsi->mode_flags =
> > > MIPI_DSI_CLOCK_NON_CONTINUOUS |
> > > - MIPI_DSI_MODE_EOT_PACKET;
> > > + MIPI_DSI_MODE_NO_EOT_PACKET;
> >
> > Same, just delete the flag.
> >
> > These are all just semantic bugs due to the ambiguity of the flags, it is
> > possible to provide a Fixes: flag for each file using this flag the wrong way
> > but I dunno if it's worth it.
>
> Wow nice catch.
>
> I think we should fix all of those _before_ my patch is applied, with
> proper Fixes tags so that this can be backported to stable branches,
> even if it's a no-op. I can look into it but that may take a bit of
> time.
This is fixed now, please will you proceed with this patch, because I
really like it!
Yours,
Linus Walleij
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
Robert Foss <robert.foss@linaro.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
Emil Velikov <emil.velikov@collabora.com>,
Inki Dae <inki.dae@samsung.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Jonas Karlman <jonas@kwiboo.se>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Jordan Crouse <jcrouse@codeaurora.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Maxime Ripard <mripard@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Rajendra Nayak <rnayak@codeaurora.org>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Rob Clark <robdclark@gmail.com>, Sam Ravnborg <sam@ravnborg.org>,
Sean Paul <sean@poorly.run>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thomas Zimmermann <tzimmermann@suse.de>,
Viresh Kumar <viresh.kumar@linaro.org>,
Xin Ji <xji@analogixsemi.com>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
freedreno <freedreno@lists.freedesktop.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Subject: Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features
Date: Mon, 28 Jun 2021 13:10:23 +0200 [thread overview]
Message-ID: <CACRpkdYK3nw890YFNxgtrwDvxcoeNVu7MxqUw94NN_6PiYxkJQ@mail.gmail.com> (raw)
In-Reply-To: <CANMq1KAsvXZAjmYCMQsAUwpkzuA9-PRnNWkpsLuNbOkP6DixGA@mail.gmail.com>
On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat <drinkcat@chromium.org> wrote:
> On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > > dsi->mode_flags =
> > > MIPI_DSI_CLOCK_NON_CONTINUOUS |
> > > - MIPI_DSI_MODE_EOT_PACKET;
> > > + MIPI_DSI_MODE_NO_EOT_PACKET;
> >
> > Same, just delete the flag.
> >
> > These are all just semantic bugs due to the ambiguity of the flags, it is
> > possible to provide a Fixes: flag for each file using this flag the wrong way
> > but I dunno if it's worth it.
>
> Wow nice catch.
>
> I think we should fix all of those _before_ my patch is applied, with
> proper Fixes tags so that this can be backported to stable branches,
> even if it's a no-op. I can look into it but that may take a bit of
> time.
This is fixed now, please will you proceed with this patch, because I
really like it!
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Nicolas Boichat <drinkcat@chromium.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
Viresh Kumar <viresh.kumar@linaro.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Andrzej Hajda <a.hajda@samsung.com>,
Thierry Reding <thierry.reding@gmail.com>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Sam Ravnborg <sam@ravnborg.org>,
Emil Velikov <emil.velikov@collabora.com>,
linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Joonyoung Shim <jy0922.shim@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Jonas Karlman <jonas@kwiboo.se>,
MSM <linux-arm-msm@vger.kernel.org>,
Jordan Crouse <jcrouse@codeaurora.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Paul <sean@poorly.run>, Xin Ji <xji@analogixsemi.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Rajendra Nayak <rnayak@codeaurora.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
Seung-Woo Kim <sw0312.kim@samsung.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Robert Foss <robert.foss@linaro.org>,
Kyungmin Park <kyungmin.park@samsung.com>,
freedreno <freedreno@lists.freedesktop.org>
Subject: Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features
Date: Mon, 28 Jun 2021 13:10:23 +0200 [thread overview]
Message-ID: <CACRpkdYK3nw890YFNxgtrwDvxcoeNVu7MxqUw94NN_6PiYxkJQ@mail.gmail.com> (raw)
In-Reply-To: <CANMq1KAsvXZAjmYCMQsAUwpkzuA9-PRnNWkpsLuNbOkP6DixGA@mail.gmail.com>
On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat <drinkcat@chromium.org> wrote:
> On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij <linus.walleij@linaro.org> wrote:
> > > dsi->mode_flags =
> > > MIPI_DSI_CLOCK_NON_CONTINUOUS |
> > > - MIPI_DSI_MODE_EOT_PACKET;
> > > + MIPI_DSI_MODE_NO_EOT_PACKET;
> >
> > Same, just delete the flag.
> >
> > These are all just semantic bugs due to the ambiguity of the flags, it is
> > possible to provide a Fixes: flag for each file using this flag the wrong way
> > but I dunno if it's worth it.
>
> Wow nice catch.
>
> I think we should fix all of those _before_ my patch is applied, with
> proper Fixes tags so that this can be backported to stable branches,
> even if it's a no-op. I can look into it but that may take a bit of
> time.
This is fixed now, please will you proceed with this patch, because I
really like it!
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-06-28 11:10 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 3:33 [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features Nicolas Boichat
2021-02-11 3:33 ` Nicolas Boichat
2021-02-11 3:33 ` Nicolas Boichat
2021-02-11 3:33 ` Nicolas Boichat
2021-02-12 9:04 ` Robert Foss
2021-02-12 9:04 ` Robert Foss
2021-02-12 9:04 ` Robert Foss
2021-02-12 9:04 ` Robert Foss
2021-02-16 6:31 ` Chun-Kuang Hu
2021-02-16 6:31 ` Chun-Kuang Hu
2021-02-16 6:31 ` Chun-Kuang Hu
2021-02-16 6:31 ` Chun-Kuang Hu
2021-02-18 6:14 ` Xin Ji
2021-02-18 6:14 ` Xin Ji
2021-02-18 6:14 ` Xin Ji
2021-02-18 6:14 ` Xin Ji
2021-02-18 19:35 ` [Freedreno] " abhinavk
2021-02-18 19:35 ` abhinavk
2021-02-18 19:35 ` abhinavk
2021-02-21 19:08 ` Laurent Pinchart
2021-02-21 19:08 ` Laurent Pinchart
2021-02-21 19:08 ` Laurent Pinchart
2021-02-21 19:08 ` Laurent Pinchart
2021-02-22 5:31 ` Nicolas Boichat
2021-02-22 5:31 ` Nicolas Boichat
2021-02-22 5:31 ` Nicolas Boichat
2021-02-22 5:31 ` Nicolas Boichat
2021-02-22 7:20 ` Andrzej Hajda
2021-02-22 7:20 ` Andrzej Hajda
2021-02-22 7:20 ` Andrzej Hajda
2021-02-22 7:20 ` Andrzej Hajda
2021-02-22 11:00 ` Nicolas Boichat
2021-02-22 11:00 ` Nicolas Boichat
2021-02-22 11:00 ` Nicolas Boichat
2021-02-22 11:00 ` Nicolas Boichat
2021-03-01 8:59 ` Linus Walleij
2021-03-01 8:59 ` Linus Walleij
2021-03-01 8:59 ` Linus Walleij
2021-03-01 8:59 ` Linus Walleij
2021-03-03 10:31 ` Nicolas Boichat
2021-03-03 10:31 ` Nicolas Boichat
2021-03-03 10:31 ` Nicolas Boichat
2021-03-03 10:31 ` Nicolas Boichat
2021-06-28 11:10 ` Linus Walleij [this message]
2021-06-28 11:10 ` Linus Walleij
2021-06-28 11:10 ` Linus Walleij
2021-06-28 11:10 ` Linus Walleij
2021-06-28 23:44 ` Nicolas Boichat
2021-06-28 23:44 ` Nicolas Boichat
2021-06-28 23:44 ` Nicolas Boichat
2021-06-28 23:44 ` Nicolas Boichat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYK3nw890YFNxgtrwDvxcoeNVu7MxqUw94NN_6PiYxkJQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=chunkuang.hu@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=drinkcat@chromium.org \
--cc=emil.velikov@collabora.com \
--cc=freedreno@lists.freedesktop.org \
--cc=inki.dae@samsung.com \
--cc=jcrouse@codeaurora.org \
--cc=jernej.skrabec@siol.net \
--cc=jonas@kwiboo.se \
--cc=jy0922.shim@samsung.com \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mripard@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=rikard.falkeborn@gmail.com \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=sw0312.kim@samsung.com \
--cc=thierry.reding@gmail.com \
--cc=tzimmermann@suse.de \
--cc=viresh.kumar@linaro.org \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.