All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Arnd Bergmann <arnd@arndb.de>,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	Tony Lindgren <tony@atomide.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Christophe Leroy <christophe.leroy@csgroup.eu>,
	Vincenzo Palazzo <vincenzopalazzodev@gmail.com>,
	Devarsh Thakkar <devarsht@ti.com>,
	Michael Walle <michael@walle.cc>,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Dipen Patel <dipenp@nvidia.com>,
	Thierry Reding <treding@nvidia.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Lee Jones <lee@kernel.org>,
	linux-gpio@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-doc-tw-discuss@lists.sourceforge.net,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-samsung-soc@vger.kernel.org,
	linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org,
	linux-sh@vger.kernel.org, linux-acpi@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-input@vger.kernel.org,
	linux-media@vger.kernel.org, linux-wpan@vger.kernel.org,
	netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
	brcm80211-dev-list.pdl@broadcom.com,
	SHA-cyfmac-dev-list@infineon.com, linux-arch@vger.kernel.org,
	devicetree@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>,
	Jonathan Corbet <corbet@lwn.net>, Alex Shi <alexs@kernel.org>,
	Yanteng Si <siyanteng@loongson.cn>, Hu Haowen <src.res@email.cn>,
	Russell King <linux@armlinux.org.uk>,
	Aaro Koskinen <aaro.koskinen@iki.fi>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Rich Felker <dalias@libc.org>,
	Mun Yew Tham <mun.yew.tham@intel.com>, Keerthy <j-keerthy@ti.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Alexander Aring <alex.aring@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Arend van Spriel <aspriel@gmail.com>,
	Franky Lin <franky.lin@broadcom.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	Kalle Valo <kvalo@kernel.org>, Qiang Zhao <qiang.zhao@nxp.com>,
	Li Yang <leoyang.li@nxp.com>, Rob Herring <robh+dt@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH v4 02/18] ARM: s3c24xx: Use the right include
Date: Thu, 9 Feb 2023 11:45:18 +0100	[thread overview]
Message-ID: <CACRpkdYRTq35gJq3YODGh9S_JnH1jxSOT8mNnetyRQY9Z5LhWQ@mail.gmail.com> (raw)
In-Reply-To: <30234963-33e5-e2d7-a6ef-112e89efbdd0@linaro.org>

On Wed, Feb 8, 2023 at 6:39 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> On 08/02/2023 18:33, Andy Shevchenko wrote:
> > From: Linus Walleij <linus.walleij@linaro.org>
> >
> > The file s3c64xx.c is including <linux/gpio.h> despite using no
> > symbols from the file, however it needs it to implicitly bring in
> > of_have_populated_dt() so include <linux/of.h> explicitly instead.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/arm/mach-s3c/s3c64xx.c | 2 +-
>
> It's not s3c24xx anymore, so subject prefix:
> ARM: s3c64xx:

My mistake, mea culpa.

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Alexander Aring <alex.aring@gmail.com>,
	Rich Felker <dalias@libc.org>, Devarsh Thakkar <devarsht@ti.com>,
	linux-doc@vger.kernel.org, Tony Lindgren <tony@atomide.com>,
	Eric Dumazet <edumazet@google.com>,
	Thierry Reding <thierry.reding@gmail.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>, Li Yang <leoyang.li@nxp.com>,
	Frank Rowand <frowand.list@gmail.com>,
	Stefan Schmidt <stefan@datenfreihafen.org>,
	Qiang Zhao <qiang.zhao@nxp.com>,
	linux-arch@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	linux-omap@vger.kernel.org, Alex Shi <alexs@kernel.org>,
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>,
	linux-sh@vger.kernel.org, Bartosz Golaszewski <brgl@bgdev.pl>,
	Lee Jones <lee@kernel.org>,
	Janusz Krzysztofik <jmkrzyszt@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	linux-acpi@vger. kernel.org, SHA-cyfmac-dev-list@infineon.com,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Vincenzo Palazzo <vincenzopalazzodev@gmail.com>,
	linux-input@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Thierry Reding <treding@nvidia.com>,
	Kalle Valo <kvalo@kernel.org>,
	linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>, Yanteng Si <siyanteng@loongson.cn>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Arend van Spriel <aspriel@gmail.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Hante Meuleman <hante.meuleman@broadcom.com>,
	linux-gpio@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
	linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-arm-kernel@lists.infradead.org,
	Franky Lin <franky.lin@broadcom.com>,
	brcm80211-dev-list.pdl@broadcom.com, Keerthy <j-keerthy@ti.com>,
	Yoshinori Sato <ysato@users.sou rceforge.jp>,
	Mun Yew Tham <mun.yew.tham@intel.com>,
	Dipen Patel <dipenp@nvidia.com>,
	linux-wpan@vger.kernel.org,
	linux-doc-tw-discuss@lists.sourceforge.net,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	Michael Walle <michael@walle.cc>,
	Rob Herring <robh+dt@kernel.org>,
	netdev@vger.kernel.org, Aaro Koskinen <aaro.koskinen@iki.fi>,
	Hu Haowen <src.res@email.cn>,
	linuxppc-dev@lists.ozlabs.org,
	Gregory Clement <gregory.clement@bootlin.com>
Subject: Re: [PATCH v4 02/18] ARM: s3c24xx: Use the right include
Date: Thu, 9 Feb 2023 11:45:18 +0100	[thread overview]
Message-ID: <CACRpkdYRTq35gJq3YODGh9S_JnH1jxSOT8mNnetyRQY9Z5LhWQ@mail.gmail.com> (raw)
In-Reply-To: <30234963-33e5-e2d7-a6ef-112e89efbdd0@linaro.org>

On Wed, Feb 8, 2023 at 6:39 PM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> On 08/02/2023 18:33, Andy Shevchenko wrote:
> > From: Linus Walleij <linus.walleij@linaro.org>
> >
> > The file s3c64xx.c is including <linux/gpio.h> despite using no
> > symbols from the file, however it needs it to implicitly bring in
> > of_have_populated_dt() so include <linux/of.h> explicitly instead.
> >
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  arch/arm/mach-s3c/s3c64xx.c | 2 +-
>
> It's not s3c24xx anymore, so subject prefix:
> ARM: s3c64xx:

My mistake, mea culpa.

Yours,
Linus Walleij

  parent reply	other threads:[~2023-02-09 10:47 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 17:33 [PATCH v4 00/18] gpiolib cleanups Andy Shevchenko
2023-02-08 17:33 ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 01/18] ARM: orion/gpio: Use the right include Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 02/18] ARM: s3c24xx: " Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:39   ` Krzysztof Kozlowski
2023-02-08 17:39     ` Krzysztof Kozlowski
2023-02-08 17:43     ` Andy Shevchenko
2023-02-08 17:43       ` Andy Shevchenko
2023-02-09 10:45     ` Linus Walleij [this message]
2023-02-09 10:45       ` Linus Walleij
2023-02-08 18:02   ` Krzysztof Kozlowski
2023-02-08 18:02     ` Krzysztof Kozlowski
2023-02-08 17:33 ` [PATCH v4 03/18] hte: tegra-194: Use proper includes Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-09 11:29   ` Dipen Patel
2023-02-09 11:29     ` Dipen Patel
2023-02-08 17:33 ` [PATCH v4 04/18] gpiolib: Make the legacy <linux/gpio.h> consumer-only Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 05/18] gpiolib: remove empty asm/gpio.h files Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 06/18] gpiolib: coldfire: remove custom asm/gpio.h Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 07/18] gpiolib: remove asm-generic/gpio.h Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 08/18] gpiolib: remove gpio_set_debounce() Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-10  0:30   ` Dmitry Torokhov
2023-02-10  0:30     ` Dmitry Torokhov
2023-02-08 17:33 ` [PATCH v4 09/18] gpiolib: remove legacy gpio_export() Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 10/18] gpiolib: split linux/gpio/driver.h out of linux/gpio.h Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 11/18] gpiolib: split of_mm_gpio_chip out of linux/of_gpio.h Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 12/18] gpio: aggregator: Add missing header(s) Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-09 10:43   ` Linus Walleij
2023-02-09 10:43     ` Linus Walleij
2023-02-08 17:33 ` [PATCH v4 13/18] gpio: reg: " Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-09 10:43   ` Linus Walleij
2023-02-09 10:43     ` Linus Walleij
2023-02-08 17:33 ` [PATCH v4 14/18] gpio: regmap: " Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-09 10:41   ` Linus Walleij
2023-02-09 10:41     ` Linus Walleij
2023-02-08 17:33 ` [PATCH v4 15/18] gpiolib: Drop unused forward declaration from driver.h Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-08 17:33 ` [PATCH v4 16/18] gpiolib: Deduplicate forward declarations in consumer.h Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-09 10:42   ` Linus Walleij
2023-02-09 10:42     ` Linus Walleij
2023-02-08 17:33 ` [PATCH v4 17/18] gpiolib: Group " Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-09 10:42   ` Linus Walleij
2023-02-09 10:42     ` Linus Walleij
2023-02-08 17:33 ` [PATCH v4 18/18] gpiolib: Clean up headers Andy Shevchenko
2023-02-08 17:33   ` Andy Shevchenko
2023-02-09 10:44   ` Linus Walleij
2023-02-09 10:44     ` Linus Walleij
2023-02-15 15:52 ` [PATCH v4 00/18] gpiolib cleanups Bartosz Golaszewski
2023-02-15 15:52   ` Bartosz Golaszewski
2023-02-15 15:59   ` Andy Shevchenko
2023-02-15 15:59     ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdYRTq35gJq3YODGh9S_JnH1jxSOT8mNnetyRQY9Z5LhWQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=SHA-cyfmac-dev-list@infineon.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=alex.aring@gmail.com \
    --cc=alexs@kernel.org \
    --cc=alim.akhtar@samsung.com \
    --cc=andrew@lunn.ch \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=arnd@arndb.de \
    --cc=aspriel@gmail.com \
    --cc=bartosz.golaszewski@linaro.org \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brgl@bgdev.pl \
    --cc=christophe.leroy@csgroup.eu \
    --cc=corbet@lwn.net \
    --cc=dalias@libc.org \
    --cc=davem@davemloft.net \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dipenp@nvidia.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=edumazet@google.com \
    --cc=franky.lin@broadcom.com \
    --cc=frowand.list@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gregory.clement@bootlin.com \
    --cc=hante.meuleman@broadcom.com \
    --cc=j-keerthy@ti.com \
    --cc=jmkrzyszt@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=kvalo@kernel.org \
    --cc=lee@kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc-tw-discuss@lists.sourceforge.net \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linux-wpan@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mchehab@kernel.org \
    --cc=michael@walle.cc \
    --cc=mika.westerberg@linux.intel.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mpe@ellerman.id.au \
    --cc=mun.yew.tham@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=npiggin@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=qiang.zhao@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=siyanteng@loongson.cn \
    --cc=src.res@email.cn \
    --cc=stefan@datenfreihafen.org \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    --cc=treding@nvidia.com \
    --cc=vincenzopalazzodev@gmail.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.