From: Linus Walleij <linus.walleij@linaro.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-iio <linux-iio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()
Date: Tue, 28 Sep 2021 16:30:09 +0200 [thread overview]
Message-ID: <CACRpkdYSKnk0v2FEPg5h4p_ODtepXoH9=a=8hiTa7BP3goaPKA@mail.gmail.com> (raw)
In-Reply-To: <20210928141956.2148-7-caihuoqing@baidu.com>
On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@baidu.com> wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> BTW, change the return value from 'ENXIO' to 'ENODEV',
> perfer ENODEV which means no such device.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> v2->v3: Update the changelog.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-iio <linux-iio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()
Date: Tue, 28 Sep 2021 16:30:09 +0200 [thread overview]
Message-ID: <CACRpkdYSKnk0v2FEPg5h4p_ODtepXoH9=a=8hiTa7BP3goaPKA@mail.gmail.com> (raw)
In-Reply-To: <20210928141956.2148-7-caihuoqing@baidu.com>
On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@baidu.com> wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> BTW, change the return value from 'ENXIO' to 'ENODEV',
> perfer ENODEV which means no such device.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> v2->v3: Update the changelog.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-iio <linux-iio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()
Date: Tue, 28 Sep 2021 16:30:09 +0200 [thread overview]
Message-ID: <CACRpkdYSKnk0v2FEPg5h4p_ODtepXoH9=a=8hiTa7BP3goaPKA@mail.gmail.com> (raw)
In-Reply-To: <20210928141956.2148-7-caihuoqing@baidu.com>
On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@baidu.com> wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> BTW, change the return value from 'ENXIO' to 'ENODEV',
> perfer ENODEV which means no such device.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> v2->v3: Update the changelog.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: Cai Huoqing <caihuoqing@baidu.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Vladimir Zapolskiy <vz@mleia.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
linux-iio <linux-iio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"open list:ARM/Amlogic Meson..."
<linux-amlogic@lists.infradead.org>,
MSM <linux-arm-msm@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: Make use of the helper function dev_err_probe()
Date: Tue, 28 Sep 2021 16:30:09 +0200 [thread overview]
Message-ID: <CACRpkdYSKnk0v2FEPg5h4p_ODtepXoH9=a=8hiTa7BP3goaPKA@mail.gmail.com> (raw)
In-Reply-To: <20210928141956.2148-7-caihuoqing@baidu.com>
On Tue, Sep 28, 2021 at 4:20 PM Cai Huoqing <caihuoqing@baidu.com> wrote:
> When possible use dev_err_probe help to properly deal with the
> PROBE_DEFER error, the benefit is that DEFER issue will be logged
> in the devices_deferred debugfs file.
> Using dev_err_probe() can reduce code size, and the error value
> gets printed.
>
> BTW, change the return value from 'ENXIO' to 'ENODEV',
> perfer ENODEV which means no such device.
>
> Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
> ---
> v2->v3: Update the changelog.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-28 14:30 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 14:19 [PATCH v3 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` [PATCH v3 2/9] iio: adc: imx7d_adc: " Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-29 16:26 ` Jonathan Cameron
2021-09-29 16:26 ` Jonathan Cameron
2021-09-29 16:26 ` Jonathan Cameron
2021-09-29 16:26 ` Jonathan Cameron
2021-09-28 14:19 ` [PATCH v3 3/9] iio: adc: lpc18xx_adc: " Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` [PATCH v3 4/9] iio: adc: max1118: " Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` [PATCH v3 5/9] iio: adc: max1241: " Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-29 16:40 ` Jonathan Cameron
2021-09-29 16:40 ` Jonathan Cameron
2021-09-29 16:40 ` Jonathan Cameron
2021-09-29 16:40 ` Jonathan Cameron
2021-09-28 14:19 ` [PATCH v3 6/9] iio: adc: meson_saradc: " Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-10-02 13:01 ` Martin Blumenstingl
2021-10-02 13:01 ` Martin Blumenstingl
2021-10-02 13:01 ` Martin Blumenstingl
2021-10-02 13:01 ` Martin Blumenstingl
2021-10-02 16:09 ` Jonathan Cameron
2021-10-02 16:09 ` Jonathan Cameron
2021-10-02 16:09 ` Jonathan Cameron
2021-10-02 16:09 ` Jonathan Cameron
2021-10-02 17:06 ` Martin Blumenstingl
2021-10-02 17:06 ` Martin Blumenstingl
2021-10-02 17:06 ` Martin Blumenstingl
2021-10-02 17:06 ` Martin Blumenstingl
2021-09-28 14:19 ` [PATCH v3 7/9] iio: adc: qcom-pm8xxx-xoadc: " Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:30 ` Linus Walleij [this message]
2021-09-28 14:30 ` Linus Walleij
2021-09-28 14:30 ` Linus Walleij
2021-09-28 14:30 ` Linus Walleij
2021-09-28 14:19 ` [PATCH v3 8/9] iio: adc: rockchip_saradc: " Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-29 16:55 ` Jonathan Cameron
2021-09-29 16:55 ` Jonathan Cameron
2021-09-29 16:55 ` Jonathan Cameron
2021-09-29 16:55 ` Jonathan Cameron
2021-09-28 14:19 ` [PATCH v3 9/9] iio: adc: ti-ads7950: " Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-28 14:19 ` Cai Huoqing
2021-09-29 16:20 ` [PATCH v3 1/9] iio: adc: ab8500-gpadc: " Jonathan Cameron
2021-09-29 16:20 ` Jonathan Cameron
2021-09-29 16:20 ` Jonathan Cameron
2021-09-29 16:20 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYSKnk0v2FEPg5h4p_ODtepXoH9=a=8hiTa7BP3goaPKA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=caihuoqing@baidu.com \
--cc=festevam@gmail.com \
--cc=heiko@sntech.de \
--cc=jbrunet@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=khilman@baylibre.com \
--cc=lars@metafoo.de \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.