From: Linus Walleij <linus.walleij@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: sean.wang@kernel.org, matthias.bgg@gmail.com,
light.hsieh@mediatek.com, linux-mediatek@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] pinctrl: mediatek: moore: Fix build error
Date: Thu, 21 Apr 2022 00:50:15 +0200 [thread overview]
Message-ID: <CACRpkdYVHPA7GyjyeOU_Q78dZR_VD1-=6pVX74j5FKee7cKpGQ@mail.gmail.com> (raw)
In-Reply-To: <20220409105958.37412-1-yuehaibing@huawei.com>
On Sat, Apr 9, 2022 at 1:00 PM YueHaibing <yuehaibing@huawei.com> wrote:
> If EINT_MTK is m and PINCTRL_MTK_V2 is y, build fails:
>
> drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_set_config':
> pinctrl-moore.c:(.text+0xa6c): undefined reference to `mtk_eint_set_debounce'
> drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_to_irq':
> pinctrl-moore.c:(.text+0xacc): undefined reference to `mtk_eint_find_irq'
>
> Select EINT_MTK for PINCTRL_MTK_V2 to fix this.
>
> Fixes: 8174a8512e3e ("pinctrl: mediatek: make MediaTek pinctrl v2 driver ready for buidling loadable module")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Good catch! Patch applied for fixes.
Yours,
Linus Walleij
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: sean.wang@kernel.org, matthias.bgg@gmail.com,
light.hsieh@mediatek.com, linux-mediatek@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] pinctrl: mediatek: moore: Fix build error
Date: Thu, 21 Apr 2022 00:50:15 +0200 [thread overview]
Message-ID: <CACRpkdYVHPA7GyjyeOU_Q78dZR_VD1-=6pVX74j5FKee7cKpGQ@mail.gmail.com> (raw)
In-Reply-To: <20220409105958.37412-1-yuehaibing@huawei.com>
On Sat, Apr 9, 2022 at 1:00 PM YueHaibing <yuehaibing@huawei.com> wrote:
> If EINT_MTK is m and PINCTRL_MTK_V2 is y, build fails:
>
> drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_set_config':
> pinctrl-moore.c:(.text+0xa6c): undefined reference to `mtk_eint_set_debounce'
> drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_to_irq':
> pinctrl-moore.c:(.text+0xacc): undefined reference to `mtk_eint_find_irq'
>
> Select EINT_MTK for PINCTRL_MTK_V2 to fix this.
>
> Fixes: 8174a8512e3e ("pinctrl: mediatek: make MediaTek pinctrl v2 driver ready for buidling loadable module")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Good catch! Patch applied for fixes.
Yours,
Linus Walleij
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Linus Walleij <linus.walleij@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: sean.wang@kernel.org, matthias.bgg@gmail.com,
light.hsieh@mediatek.com, linux-mediatek@lists.infradead.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] pinctrl: mediatek: moore: Fix build error
Date: Thu, 21 Apr 2022 00:50:15 +0200 [thread overview]
Message-ID: <CACRpkdYVHPA7GyjyeOU_Q78dZR_VD1-=6pVX74j5FKee7cKpGQ@mail.gmail.com> (raw)
In-Reply-To: <20220409105958.37412-1-yuehaibing@huawei.com>
On Sat, Apr 9, 2022 at 1:00 PM YueHaibing <yuehaibing@huawei.com> wrote:
> If EINT_MTK is m and PINCTRL_MTK_V2 is y, build fails:
>
> drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_set_config':
> pinctrl-moore.c:(.text+0xa6c): undefined reference to `mtk_eint_set_debounce'
> drivers/pinctrl/mediatek/pinctrl-moore.o: In function `mtk_gpio_to_irq':
> pinctrl-moore.c:(.text+0xacc): undefined reference to `mtk_eint_find_irq'
>
> Select EINT_MTK for PINCTRL_MTK_V2 to fix this.
>
> Fixes: 8174a8512e3e ("pinctrl: mediatek: make MediaTek pinctrl v2 driver ready for buidling loadable module")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Good catch! Patch applied for fixes.
Yours,
Linus Walleij
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-20 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 10:59 [PATCH -next] pinctrl: mediatek: moore: Fix build error YueHaibing
2022-04-09 10:59 ` YueHaibing
2022-04-09 10:59 ` YueHaibing
2022-04-20 22:50 ` Linus Walleij [this message]
2022-04-20 22:50 ` Linus Walleij
2022-04-20 22:50 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdYVHPA7GyjyeOU_Q78dZR_VD1-=6pVX74j5FKee7cKpGQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=light.hsieh@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.