All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Feng Kan <fkan@apm.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
	Abhijeet Dharmapurikar <adharmap@codeaurora.org>,
	Stephen Boyd <sboyd@codeaurora.org>, Phong Vo <pvo@apm.com>,
	Tin Huynh <tnhuynh@apm.com>, Y Vo <yvo@apm.com>,
	Thomas Gleixner <tglx@linutronix.de>, Toan Le <toanle@apm.com>,
	Bjorn Andersson <bjorn@kryo.se>,
	Jason Cooper <jason@lakedaemon.net>,
	Arnd Bergmann <arnd@arndb.de>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state
Date: Wed, 13 May 2015 13:58:37 +0200	[thread overview]
Message-ID: <CACRpkdYffHJEzksc5mg7JZdwTzShGaQofAmbmn65=_V3ot04Rg@mail.gmail.com> (raw)
In-Reply-To: <CAL85gmBrkonMcKdUVGmYx6zT3wSe-e2jPhnL_+Tkf3s4jsAiWg@mail.gmail.com>

On Wed, May 13, 2015 at 4:25 AM, Feng Kan <fkan@apm.com> wrote:

> Marc:
>
> Sorry for top posting. It seems with GIC-400, the get_irqstate is not a reliable
> way of accessing the GPIO status. In our case, the gpio interrupt status can
> only be read correctly with the SPISR register. So it seems we have to go
> back to the old way of mapping the SPISR portion of the GIC in our GPIO
> driver. We wanted to ask you if that is acceptable since SPISR in not
> standard in all GIC, perhaps we can treat it differently.

As GPIO maintainer I am curious about what this is...

Can you describe the scenario where your GPIO (!) driver needs
to be poking around in the GIC SPISR?

Yours,
Linus Walleij

WARNING: multiple messages have this Message-ID (diff)
From: linus.walleij@linaro.org (Linus Walleij)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state
Date: Wed, 13 May 2015 13:58:37 +0200	[thread overview]
Message-ID: <CACRpkdYffHJEzksc5mg7JZdwTzShGaQofAmbmn65=_V3ot04Rg@mail.gmail.com> (raw)
In-Reply-To: <CAL85gmBrkonMcKdUVGmYx6zT3wSe-e2jPhnL_+Tkf3s4jsAiWg@mail.gmail.com>

On Wed, May 13, 2015 at 4:25 AM, Feng Kan <fkan@apm.com> wrote:

> Marc:
>
> Sorry for top posting. It seems with GIC-400, the get_irqstate is not a reliable
> way of accessing the GPIO status. In our case, the gpio interrupt status can
> only be read correctly with the SPISR register. So it seems we have to go
> back to the old way of mapping the SPISR portion of the GIC in our GPIO
> driver. We wanted to ask you if that is acceptable since SPISR in not
> standard in all GIC, perhaps we can treat it differently.

As GPIO maintainer I am curious about what this is...

Can you describe the scenario where your GPIO (!) driver needs
to be poking around in the GIC SPISR?

Yours,
Linus Walleij

  reply	other threads:[~2015-05-13 11:58 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 11:01 [PATCH v4 0/3] genirq: Saving/restoring the irqchip state of an irq line Marc Zyngier
2015-03-18 11:01 ` Marc Zyngier
2015-03-18 11:01 ` [PATCH v4 1/3] genirq: Allow the irqchip state of an IRQ to be save/restored Marc Zyngier
2015-03-18 11:01   ` Marc Zyngier
2015-04-08 17:48   ` Bjorn Andersson
2015-04-08 17:48     ` Bjorn Andersson
2015-04-08 17:48     ` Bjorn Andersson
2015-04-13 16:18     ` Srinivas Kandagatla
2015-04-13 16:18       ` Srinivas Kandagatla
2015-04-13 16:18       ` Srinivas Kandagatla
2015-04-13 16:21       ` Marc Zyngier
2015-04-13 16:21         ` Marc Zyngier
2015-04-13 16:21         ` Marc Zyngier
2015-04-08 21:30   ` [tip:irq/core] " tip-bot for Marc Zyngier
2015-03-18 11:01 ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Marc Zyngier
2015-03-18 11:01   ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Marc Zyngier
2015-04-08 21:31   ` [tip:irq/core] irqchip: GIC: Add support for irq_[get, set] _irqchip_state() tip-bot for Marc Zyngier
2015-05-13  2:25   ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Feng Kan
2015-05-13  2:25     ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Feng Kan
2015-05-13  2:25     ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Feng Kan
2015-05-13 11:58     ` Linus Walleij [this message]
2015-05-13 11:58       ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Linus Walleij
2015-05-13 11:58       ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Linus Walleij
2015-05-13 15:44       ` Feng Kan
2015-05-13 15:44         ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Feng Kan
2015-05-13 15:44         ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Feng Kan
2015-05-14 10:32         ` Linus Walleij
2015-05-14 10:32           ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Linus Walleij
2015-05-14 10:32           ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Linus Walleij
2015-05-14 20:14           ` Feng Kan
2015-05-14 20:14             ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Feng Kan
2015-05-14 20:14             ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Feng Kan
2015-05-19  8:40             ` Linus Walleij
2015-05-19  8:40               ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Linus Walleij
2015-05-19  8:40               ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Linus Walleij
2015-05-19 10:01               ` Marc Zyngier
2015-05-19 10:01                 ` Marc Zyngier
2015-05-19 10:01                 ` Marc Zyngier
2015-05-19 15:01                 ` Linus Walleij
2015-05-19 15:01                   ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Linus Walleij
2015-05-19 15:01                   ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Linus Walleij
2015-05-19 21:45                 ` Feng Kan
2015-05-19 21:45                   ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get, set}_irqchip_state Feng Kan
2015-05-19 21:45                   ` [PATCH v4 2/3] irqchip: GIC: Add support for irq_{get,set}_irqchip_state Feng Kan
2015-05-20  7:58                   ` Marc Zyngier
2015-05-20  7:58                     ` Marc Zyngier
2015-05-20  7:58                     ` Marc Zyngier
2015-03-18 11:01 ` [PATCH v4 3/3] irqchip: GICv3: " Marc Zyngier
2015-03-18 11:01   ` [PATCH v4 3/3] irqchip: GICv3: Add support for irq_{get, set}_irqchip_state Marc Zyngier
2015-04-08 21:31   ` [tip:irq/core] irqchip: GICv3: Add support for irq_[get, set] _irqchip_state() tip-bot for Marc Zyngier
2015-04-13 14:12 ` [PATCH v4 0/3] genirq: Saving/restoring the irqchip state of an irq line Eric Auger
2015-04-13 14:12   ` Eric Auger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdYffHJEzksc5mg7JZdwTzShGaQofAmbmn65=_V3ot04Rg@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=adharmap@codeaurora.org \
    --cc=arnd@arndb.de \
    --cc=bjorn@kryo.se \
    --cc=fkan@apm.com \
    --cc=gnurou@gmail.com \
    --cc=jason@lakedaemon.net \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=pvo@apm.com \
    --cc=sboyd@codeaurora.org \
    --cc=tglx@linutronix.de \
    --cc=tnhuynh@apm.com \
    --cc=toanle@apm.com \
    --cc=yvo@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.